From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 4497937B2
 for <dev@dpdk.org>; Thu, 26 May 2016 15:19:47 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga103.fm.intel.com with ESMTP; 26 May 2016 06:19:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; d="scan'208";a="974997548"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.31.37])
 by fmsmga001.fm.intel.com with SMTP; 26 May 2016 06:19:44 -0700
Received: by  (sSMTP sendmail emulation); Thu, 26 May 2016 14:19:44 +0025
Date: Thu, 26 May 2016 14:19:43 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: dev@dpdk.org
Message-ID: <20160526131943.GH7708@bricha3-MOBL3>
References: <CAJ9nmBYsstDhTCB4H1V5zGFD7ffTeXd=L+v+pdCjqB5KJ6AEvQ@mail.gmail.com>
 <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
 <1463179589-82681-24-git-send-email-stephen.hurd@broadcom.com>
 <20160526124555.GF7708@bricha3-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160526124555.GF7708@bricha3-MOBL3>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2 24/40] bnxt: add HWRM ring alloc/free
 functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 May 2016 13:19:47 -0000

On Thu, May 26, 2016 at 01:45:55PM +0100, Bruce Richardson wrote:
> On Fri, May 13, 2016 at 03:46:13PM -0700, Stephen Hurd wrote:
> > Add HWRM calls to allocate and free TX/RX/CMPL rings along with
> > the associated structs and definitions.
> > 
> What are these RX/TX/CMPL rings used for? I assume they are different from the
> RX/TX rings used to send/receive packets, or am I missing something?
> 
> Also, I see some compilation errors after applying this patch in the series.
> gcc gives errors about "struct bnxt_ring_struct declared inside parameter list".
> 
I see a fix for this is made in patch 27, which is good. I just suggest squashing
that patch into this one.

/Bruce