From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 46DE1137C
 for <dev@dpdk.org>; Fri, 27 May 2016 21:56:56 +0200 (CEST)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1b6NsI-0006FW-N2; Fri, 27 May 2016 15:56:53 -0400
Date: Fri, 27 May 2016 15:56:44 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Panu Matilainen <pmatilai@redhat.com>
Message-ID: <20160527195644.GB13448@hmsreliant.think-freely.org>
References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com>
 <1464283037-21478-1-git-send-email-nhorman@tuxdriver.com>
 <1464283037-21478-6-git-send-email-nhorman@tuxdriver.com>
 <B27915DBBA3421428155699D51E4CFE202577E98@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B27915DBBA3421428155699D51E4CFE202577E98@IRSMSX103.ger.corp.intel.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCHv5 5/6] pmdinfo.py: Add tool to query binaries
 for	hw and other support information
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 May 2016 19:56:56 -0000

On Fri, May 27, 2016 at 02:38:54PM +0000, Mcnamara, John wrote:
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman
> > Sent: Thursday, May 26, 2016 6:17 PM
> > To: dev@dpdk.org
> > Cc: Neil Horman <nhorman@tuxdriver.com>; Richardson, Bruce
> > <bruce.richardson@intel.com>; Thomas Monjalon <thomas.monjalon@6wind.com>;
> > Stephen Hemminger <stephen@networkplumber.org>; Panu Matilainen
> > <pmatilai@redhat.com>
> > Subject: [dpdk-dev] [PATCHv5 5/6] pmdinfo.py: Add tool to query binaries
> > for hw and other support information
> 
> Hi Neil,
> 
> Could you make the Python code PEP8 (Style Guide for Python Code) compliant: 
> 
>     https://www.python.org/dev/peps/pep-0008/
> 
> You can use the pep8 tool to test code for compliance.
> 
> We have been using PEP8 recently as the standard for Python based submissions
> into DPDK. I'll submit a patch to add it to the DPDK Coding Style guide.
> 
> Thanks,
> 
> John.
> 

Sure, though only one of the scripts in the tools directly seems to even be
loosely compliant with the standard.