From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 3813858CF
 for <dev@dpdk.org>; Thu,  2 Jun 2016 14:33:41 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga101.fm.intel.com with ESMTP; 02 Jun 2016 05:33:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,406,1459839600"; d="scan'208";a="979430127"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.54])
 by fmsmga001.fm.intel.com with SMTP; 02 Jun 2016 05:33:39 -0700
Received: by  (sSMTP sendmail emulation); Thu, 02 Jun 2016 13:33:37 +0025
Date: Thu, 2 Jun 2016 13:33:37 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Message-ID: <20160602123337.GA14836@bricha3-MOBL3>
References: <1464858795-3152-1-git-send-email-thomas.monjalon@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1464858795-3152-1-git-send-email-thomas.monjalon@6wind.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] scripts: check commits with checkpatch
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jun 2016 12:33:41 -0000

On Thu, Jun 02, 2016 at 11:13:15AM +0200, Thomas Monjalon wrote:
> The new option -n allows to give a number of commits to check
> from the git HEAD.
> If neither -n nor patch files are given, the commits after
> origin/master are checked.
> 

Yep, I love it, exactly what I wanted to replace my own checkpatch script wrapper!

> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  scripts/checkpatches.sh | 45 ++++++++++++++++++++++++++++++++++++---------
>  1 file changed, 36 insertions(+), 9 deletions(-)
> 
> diff --git a/scripts/checkpatches.sh b/scripts/checkpatches.sh
<snip>
> @@ -74,17 +76,42 @@ if [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
>  	exit 1
>  fi
>  
> +total=0
>  status=0
> -for p in "$@" ; do
> -	! $verbose || printf '\n### %s\n\n' "$p"
> -	report=$($DPDK_CHECKPATCH_PATH $options "$p" 2>/dev/null)
> +
> +check () { # <patch> <commit> <title>
> +	total=$(($total + 1))
> +	! $verbose || printf '\n### %s\n\n' "$3"
> +	if [ -n "$1" ] ; then
> +		report=$($DPDK_CHECKPATCH_PATH $options "$1" 2>/dev/null)
> +	elif [ -n "$2" ] ; then
> +		report=$(git format-patch --stdout -1 $commit |
> +			$DPDK_CHECKPATCH_PATH $options - 2>/dev/null)
> +	fi

Testing this out here, I find that git format-patch includes the diff stats
in the output, which then can trigger long-line warnings for the commit message.

	WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
	#8:
	 examples/my-new-test-app/basicfwd.c | 342 +++++++++++++++++++++++++++++++++++++

To fix this, I suggest replacing "format-patch --stdout" with "show --format=email"
since that should give the same output just without the change stats.

With this one adjustment:

Acked-by: Bruce Richardson <bruce.richardson@intel.com>