From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 92BDD5960 for ; Fri, 3 Jun 2016 12:29:48 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 03 Jun 2016 03:29:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,411,1459839600"; d="scan'208";a="713295857" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.81]) by FMSMGA003.fm.intel.com with SMTP; 03 Jun 2016 03:29:44 -0700 Received: by (sSMTP sendmail emulation); Fri, 03 Jun 2016 11:29:44 +0025 Date: Fri, 3 Jun 2016 11:29:43 +0100 From: Bruce Richardson To: Neil Horman Cc: "Wiles, Keith" , Thomas Monjalon , Yuanhan Liu , "dev@dpdk.org" , "Tan, Jianfeng" , Stephen Hemminger , Christian Ehrhardt , Panu Matilainen , Olivier Matz Message-ID: <20160603102943.GC16616@bricha3-MOBL3> References: <20160602104106.GA12923@hmsreliant.think-freely.org> <2363376.b1CWhBpcZG@xps13> <75917C44-9CF7-4A0B-B8D3-CD7DC7425D49@intel.com> <20160602171120.GB12923@hmsreliant.think-freely.org> <7091836E-B9D5-4F99-ADDB-A47B4C7B5F7E@intel.com> <20160602200837.GC12923@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160602200837.GC12923@hmsreliant.think-freely.org> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [RFC] Yet another option for DPDK options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 10:29:49 -0000 On Thu, Jun 02, 2016 at 04:08:37PM -0400, Neil Horman wrote: > On Thu, Jun 02, 2016 at 07:41:10PM +0000, Wiles, Keith wrote: > > > > On 6/2/16, 12:11 PM, "Neil Horman" wrote: > > > > > > > >1) The definition of a config structure that can be passed to rte_eal_init, > > >defining the configuration for that running process > > > > Having a configuration structure means we have to have an ABI change to that structure anytime we add or remove an option. I was thinking a very simple DB of some kind would be better. Have the code query the DB to obtain the needed information. The APIs used to query and set the DB needs to be very easy to use as well. > > Thats a fair point. A decent starting point is likely a simple struct that > looks like this: > > struct key_vals { > char *key; > union { > ulong longval; > void *ptrval; > } value; > }; > > struct config { > size_t count; > struct key_vals kvp[0]; > }; > > > > > Maybe each option can define its own structure if needed or just a simple variable type can be used for the basic types (int, string, bool, …) > > > Well, if you have config sections that require mulitiple elements, I'd handle > that with naming, i.e. if you have a config group that has an int and char > value, I'd name them "group.intval", and "group.charval", so they are > independently searchable, but linked from a nomenclature standpoint. > > > Would this work better in the long run, does a fixed structure still make sense? > > > No. I think you're ABI concerns are valid, but the above is likely a good > starting point to address them. > > Best > Neil I'll throw out one implementation idea here that I looked at previously, for the reason that it was simple enough implement with existing code. We already have the cfgfile library which works with name/value pairs read from ini files on disk. However, it would be easy enough to add couple of APIs to that to allow the user to "set" values inside an ini structure as well. With that done we can then just add a new eal_init api which takes a single "struct rte_cfgfile *" as parameter. For those apps that want to just use inifiles for configuration straight, they can then do: cfg = rte_cfgfile_load("my_cfg_file"); rte_eal_newinit(cfg); Those who want a different config can instead do: cfg = rte_cfgfile_new(); rte_cfgfile_add_section(cfg, "dpdk"); foreach_eal_setting_wanted: rte_cfgfile_set(cfg, "dpdk", mysetting, myvalue); rte_eal_newinit(cfg); We can standardize on a sectionname, or a couple of standard section names that are used by DPDK, so that the rest of the config file can contain other data for the app itself. What do people think. I mainly like it because it gives us good reuse of what is already there, and enhances our existing library. As well as this it makes it trivially easy for apps to use ini files - which seem to be very popular here - while still giving flexibility for others to use whatever other config format their app prefers. /Bruce