From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.228.170]) by dpdk.org (Postfix) with ESMTP id 7B4FA5902 for ; Fri, 3 Jun 2016 23:41:38 +0200 (CEST) Received: by mail.mhcomputing.net (Postfix, from userid 1000) id 0A566D7; Fri, 3 Jun 2016 14:41:37 -0700 (PDT) Date: Fri, 3 Jun 2016 14:41:37 -0700 From: Matthew Hall To: Neil Horman Cc: "Wiles, Keith" , Arnon Warshavsky , Panu Matilainen , "Richardson, Bruce" , Thomas Monjalon , Yuanhan Liu , "dev@dpdk.org" , "Tan, Jianfeng" , Stephen Hemminger , Christian Ehrhardt , Olivier Matz Message-ID: <20160603214137.GC16022@mhcomputing.net> References: <8CE01283-1E89-4302-BE7D-486975B43EF6@intel.com> <20160603174437.GC12627@hmsreliant.think-freely.org> <62A67FEB-AE18-43B1-8D15-27F23D5C8A7D@intel.com> <20160603183819.GD12627@hmsreliant.think-freely.org> <20160603191804.GE12627@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160603191804.GE12627@hmsreliant.think-freely.org> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [RFC] Yet another option for DPDK options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 21:41:38 -0000 On Fri, Jun 03, 2016 at 03:18:04PM -0400, Neil Horman wrote: > I'm not opposed to default values, but it seems to me that if we are splitting > out a configuration storage library from dpdk, part of the initzliation of that > library can be installing default values. That is to say, instead of having the > code specific areas assume a default value if none is present in the config, an > init function for the configuration storage library would just populate the > keystore. That way all the dpdk itself has to do is a key lookup. > > Neil I don't think this provides as much mental locality of reference for people reading the code. But, an unwanted default argument can be filled with 0 / NULL / false as needed. Matthew.