From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 77C01376D for ; Mon, 6 Jun 2016 10:00:33 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 06 Jun 2016 01:00:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,426,1459839600"; d="scan'208";a="969660117" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga001.jf.intel.com with ESMTP; 06 Jun 2016 01:00:16 -0700 Date: Mon, 6 Jun 2016 16:01:02 +0800 From: Yuanhan Liu To: Jianfeng Tan Cc: dev@dpdk.org, Huawei Xie , rich.lane@bigswitch.com, mst@redhat.com, nakajima.yoshihiro@lab.ntt.co.jp, p.fedin@samsung.com, ann.zhuangyanying@huawei.com, mukawa@igel.co.jp, nhorman@tuxdriver.com Message-ID: <20160606080102.GZ10038@yliu-dev.sh.intel.com> References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com> <1464861277-130265-1-git-send-email-jianfeng.tan@intel.com> <1464861277-130265-7-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464861277-130265-7-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v6 6/7] virtio-user: add new virtual pci driver for virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2016 08:00:33 -0000 On Thu, Jun 02, 2016 at 09:54:36AM +0000, Jianfeng Tan wrote: > + > + desc_addr = (uint64_t)vq->mz->addr; > + avail_addr = desc_addr + vq->vq_nentries * sizeof(struct vring_desc); > + used_addr = RTE_ALIGN_CEIL(avail_addr + offsetof(struct vring_avail, > + ring[vq->vq_nentries]), > + VIRTIO_PCI_VRING_ALIGN); > + > + dev->vrings[queue_idx].num = vq->vq_nentries; > + dev->vrings[queue_idx].desc = (void *)desc_addr; > + dev->vrings[queue_idx].avail = (void *)avail_addr; > + dev->vrings[queue_idx].used = (void *)used_addr; That would break 32 bit build. please also do more build and function test, with and without CONFIG_RTE_VIRTIO_VDEV enabled, to make sure we will not break anything. I'm sure you will meet build error without that option enabled. BTW, let's be consistent with using VIRTIO_USER_DEV instead of VDEV or VIRTIO_VDEV? Another thing that might be a bit late to ask is that how about removing the vhost-net support? I mean, it's DPDK; if user stick to using DPDK virtio-user, he will stick to using DPDK vhost-user as well, but not the vhost-net. So, let's keep it being simple first. And if there is really a need for vhost-net, we can add it back later, easily. Makes sense? I also would suggest you do a rebase based on my latest tree. --yliu