From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 85765803B
 for <dev@dpdk.org>; Tue,  7 Jun 2016 14:44:48 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga101.jf.intel.com with ESMTP; 07 Jun 2016 05:44:47 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,433,1459839600"; d="scan'208";a="715219890"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by FMSMGA003.fm.intel.com with ESMTP; 07 Jun 2016 05:44:46 -0700
Date: Tue, 7 Jun 2016 20:45:44 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org, huawei.xie@intel.com,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 Traynor Kevin <kevin.traynor@intel.com>,
 Rich Lane <rich.lane@bigswitch.com>, Tetsuya Mukawa <mukawa@igel.co.jp>
Message-ID: <20160607124544.GJ10038@yliu-dev.sh.intel.com>
References: <1463117111-27050-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1465271530-27878-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1465271530-27878-9-git-send-email-yuanhan.liu@linux.intel.com>
 <c8226324-9f15-12d5-b692-88d481bed391@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c8226324-9f15-12d5-b692-88d481bed391@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v3 08/20] vhost: introduce new API to export
	numa node
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jun 2016 12:44:48 -0000

On Tue, Jun 07, 2016 at 02:42:58PM +0300, Panu Matilainen wrote:
> On 06/07/2016 06:51 AM, Yuanhan Liu wrote:
> >Introduce a new API rte_vhost_get_numa_node() to get the numa node
> >from which the virtio_net struct is allocated.
> >
> >Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >Tested-by: Rich Lane <rich.lane@bigswitch.com>
> >Acked-by: Rich Lane <rich.lane@bigswitch.com>
> >---
> > drivers/net/vhost/rte_eth_vhost.c      | 13 ++++---------
> > lib/librte_vhost/rte_vhost_version.map |  7 +++++++
> > lib/librte_vhost/rte_virtio_net.h      | 12 ++++++++++++
> > lib/librte_vhost/virtio-net.c          | 26 ++++++++++++++++++++++++++
> > 4 files changed, 49 insertions(+), 9 deletions(-)
> >
> [...]
> >diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> >index 3d8709e..bf7b000 100644
> >--- a/lib/librte_vhost/rte_vhost_version.map
> >+++ b/lib/librte_vhost/rte_vhost_version.map
> >@@ -20,3 +20,10 @@ DPDK_2.1 {
> > 	rte_vhost_driver_unregister;
> >
> > } DPDK_2.0;
> >+
> >+DPDK_16.07 {
> >+	global:
> >+
> >+	rte_vhost_get_numa_node;
> >+
> >+} DPDK_16.04;
> 
> This fails to compile in shared library configuration:
> 
> LD librte_vhost.so.3.1
> /usr/bin/ld: unable to find version dependency `DPDK_16.04'
> collect2: error: ld returned 1 exit status
> 
> Problem obviously being that DPDK_16.04 does not exist, the most recent
> version symbol for librte_vhost is DPDK_2.1 so you need to inherit from that
> instead.

Panu, thanks for the catching, and will fix it.

	--yliu