From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AF1BC9AF6 for ; Wed, 8 Jun 2016 12:02:12 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 08 Jun 2016 03:02:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,438,1459839600"; d="scan'208";a="118171551" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.95]) by fmsmga004.fm.intel.com with SMTP; 08 Jun 2016 03:02:09 -0700 Received: by (sSMTP sendmail emulation); Wed, 08 Jun 2016 11:02:08 +0025 Date: Wed, 8 Jun 2016 11:02:08 +0100 From: Bruce Richardson To: Stephen Hurd Cc: dev@dpdk.org, ajit.khaparde@broadcom.com Message-ID: <20160608100208.GA11724@bricha3-MOBL3> References: <1465250923-78695-1-git-send-email-stephen.hurd@broadcom.com> <1465250923-78695-30-git-send-email-stephen.hurd@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1465250923-78695-30-git-send-email-stephen.hurd@broadcom.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 30/39] bnxt: add start/stop/link update operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 10:02:13 -0000 On Mon, Jun 06, 2016 at 03:08:34PM -0700, Stephen Hurd wrote: > From: Ajit Khaparde > > This patch adds code to add the start, stop and link update dev_ops. > The BNXT driver will now minimally pass traffic with testpmd. > > v4: > - Fix issues pointed out by checkpatch. > - Shorten the string passed for reserving memzone > when default completion ring is created. > > Signed-off-by: Ajit Khaparde > Reviewed-by: David Christensen > Signed-off-by: Stephen Hurd > --- > drivers/net/bnxt/bnxt_ethdev.c | 269 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 269 insertions(+) > I get compilation errors after applying this patch: == Build drivers/net/bnxt CC bnxt_ethdev.o /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c: In function ‘bnxt_init_chip’: /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:135:7: error: implicit declaration of function ‘bnxt_alloc_hwrm_rings’ [-Werror=implicit-function-declaration] rc = bnxt_alloc_hwrm_rings(bp); ^ /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:135:2: error: nested extern declaration of ‘bnxt_alloc_hwrm_rings’ [-Werror=nested-externs] rc = bnxt_alloc_hwrm_rings(bp); ^ /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c: In function ‘bnxt_init_nic’: /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:233:2: error: implicit declaration of function ‘bnxt_init_ring_grps’ [-Werror=implicit-function-declaration] bnxt_init_ring_grps(bp); ^ /home/bruce/next-net/dpdk-next-net/drivers/net/bnxt/bnxt_ethdev.c:233:2: error: nested extern declaration of ‘bnxt_init_ring_grps’ [-Werror=nested-externs] cc1: all warnings being treated as errors /home/bruce/next-net/dpdk-next-net/mk/internal/rte.compile-pre.mk:126: recipe for target 'bnxt_ethdev.o' failed make[5]: *** [bnxt_ethdev.o] Error 1