From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 441A19602
 for <dev@dpdk.org>; Wed,  8 Jun 2016 12:31:34 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga103.fm.intel.com with ESMTP; 08 Jun 2016 03:31:33 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,438,1459839600"; d="scan'208";a="971345811"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.95])
 by orsmga001.jf.intel.com with SMTP; 08 Jun 2016 03:31:32 -0700
Received: by  (sSMTP sendmail emulation); Wed, 08 Jun 2016 11:31:30 +0025
Date: Wed, 8 Jun 2016 11:31:30 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Stephen Hurd <stephen.hurd@broadcom.com>, dev@dpdk.org,
 ajit.khaparde@broadcom.com
Message-ID: <20160608103129.GC11724@bricha3-MOBL3>
References: <1465250923-78695-1-git-send-email-stephen.hurd@broadcom.com>
 <1584764.9XWLYtHf7Q@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1584764.9XWLYtHf7Q@xps13>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v4 01/39] bnxt: new driver for Broadcom
 NetXtreme-C devices
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2016 10:31:34 -0000

On Tue, Jun 07, 2016 at 08:25:44AM +0200, Thomas Monjalon wrote:
> Hi Stephen,
> Reminder from http://dpdk.org/dev#send:
> 
> git send-email -39 -v4 --cover-letter --annotate
> 	--in-reply-to <Message-ID of the previous patch>
> 
> Please do not forget --in-reply-to. Thanks

Three other minor style updates as well that would make my life a little easier:

* The sign-off type tags at the bottom of the email are kept in logical
chronological order (irrespective of actual chronological order). This means
that all signed-off-by tags go together followed by a reviewed-by tag afterwards.

* Watch out for initial caps at the start of a commit title. [This will be caught
by the check-git-log.sh script if you want to run that]

* The history updates from vN to vN+1 are best put after the signoffs and prefixed
with a cutline, so that they get stripped automatically when the patch is applied.
Otherwise I have to delete them manually from the commit message. The format of
the messages is therefore best done as:

	bnxt: <title>

	<commit message>

	Signed-off-by: <author1>
	Signed-off-by: <author2>
	Reviewed-by: <reviewer1>

	---
	vN changes
	<description of changes>

Thanks,
/Bruce