From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 99D30B44B
 for <dev@dpdk.org>; Wed,  8 Jun 2016 19:13:37 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 08 Jun 2016 09:39:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,440,1459839600"; d="scan'208";a="824273143"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.95])
 by orsmga003.jf.intel.com with SMTP; 08 Jun 2016 09:39:15 -0700
Received: by  (sSMTP sendmail emulation); Wed, 08 Jun 2016 17:39:14 +0025
Date: Wed, 8 Jun 2016 17:39:14 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: helin.zhang@intel.com, dev@dpdk.org, yulong.pei@intel.com,
 andrey.chilikin@intel.com
Message-ID: <20160608163914.GB10096@bricha3-MOBL3>
References: <1463037664-31365-1-git-send-email-jingjing.wu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1463037664-31365-1-git-send-email-jingjing.wu@intel.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] i40e: fix link management
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2016 17:13:38 -0000

On Thu, May 12, 2016 at 03:21:04PM +0800, Jingjing Wu wrote:
> Previously, there was a known issue "On Intel® 40G Ethernet
> Controller stopping the port does not really down the port link."
> There were two reasons why the port is always kept up.
> 1. Old version Firmware would cause issue when call "Set PHY config
> command" on 40G NIC.
> 2. Because linux kernel i40e driver didn’t call "Set PHY config
> command" when ifconfig up/down, and it assumes the link always up.
> While ports are forced down when DPDK quit. So if the port is switched
> to controlled by kernel driver, the port will not be up through
> "ifconfig <ethx> up".
> 
> This patch fixes this issue by reopening "Set PHY config command"
> because:
> 1. New firmware issue is already fixed.
> 2. After DPDK quit, "ethtool -s <ethx> autoneg on" can be used to
> turn on the auto negotiation, and then port can be up through
> "ifconfig <ethx> up" in new version kernel i40e driver( >1.4.X ).
> 
> Fixes: 2f1e22817420 ("i40e: skip link control as firmware workaround")
> Fixes: 16c979f9adf2 ("i40e: disable setting of PHY configuration")
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

Patch applied to dpdk-next-net/rel_16_07, with some commit message cleanups
applied.

/Bruce