From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikita Kozlov <nikita@elyzion.net>
Cc: dev@dpdk.org, Nikita Kozlov <nikita@gandi.net>
Subject: Re: [dpdk-dev] [PATCH 2/3] librte_eal: Import FreeBSD sys/tree.h into librte_eal/common
Date: Wed, 8 Jun 2016 17:58:48 -0700 [thread overview]
Message-ID: <20160608175848.28bff0d1@xeon-e3> (raw)
In-Reply-To: <1465433634-6667-3-git-send-email-nikita@elyzion.net>
On Thu, 9 Jun 2016 02:53:53 +0200
Nikita Kozlov <nikita@elyzion.net> wrote:
> This structure is used inside the rte_lpm6 lib for storing added rules.
> It's imported from FreeBSD-10.3 from /usr/include/sys/tree.h, another
> solution could have been to use on Linux the version from libbsd but it
> would create an external dependency.
>
> Signed-off-by: Nikita Kozlov <nikita@gandi.net>
Using Red-black tree is a good idea, and we have been doing it for a while
both on v4 and v6.
But this is not the way to handle it.
Please don't copy a header file which is available already on both BSD and Linux.
next prev parent reply other threads:[~2016-06-09 0:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 0:53 [dpdk-dev] [PATCH 0/3] lpm6: speed improvement on delete rule Nikita Kozlov
2016-06-09 0:53 ` [dpdk-dev] [PATCH 1/3] lpm6 speed inmprovement " Nikita Kozlov
2016-06-09 0:53 ` [dpdk-dev] [PATCH 2/3] librte_eal: Import FreeBSD sys/tree.h into librte_eal/common Nikita Kozlov
2016-06-09 0:58 ` Stephen Hemminger [this message]
2016-06-09 7:25 ` Thomas Monjalon
2016-06-09 14:54 ` Nikita Kozlov
2016-06-09 15:14 ` Thomas Monjalon
2016-06-09 0:53 ` [dpdk-dev] [PATCH 3/3] test_lpm6: make test_lpm6* compatible with the new rte_lpm6.c lib Nikita Kozlov
2016-08-24 22:59 ` [dpdk-dev] [PATCH v2 0/2] lpm6: speed improvement on delete rule Nikita Kozlov
2016-09-16 13:15 ` Nikita Kozlov
2016-12-23 6:07 ` Paras Kumar
2017-02-22 15:23 ` Bruce Richardson
2016-08-24 22:59 ` [dpdk-dev] [PATCH v2 1/2] lpm6: speed inmprovement " Nikita Kozlov
2016-08-24 22:59 ` [dpdk-dev] [PATCH v2 2/2] test_lpm6: make test_lpm6* compatible with the new rte_lpm6.c lib Nikita Kozlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608175848.28bff0d1@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=nikita@elyzion.net \
--cc=nikita@gandi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).