From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 072E9567B for ; Thu, 9 Jun 2016 02:58:38 +0200 (CEST) Received: by mail-pf0-f176.google.com with SMTP id c2so7687073pfa.2 for ; Wed, 08 Jun 2016 17:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=shca+fk/7MzSlXw89ixMohOEKmbCATrZya3Tp4nmAco=; b=14JFLEvDmnkPnQVWPKhBhXn3+InCPXGy2JX0ZHlQisQYTYrToq++Y8FMse/6udePWQ um9dyz/lMNaqJqLLcg/rs2Vn7Znl72gwFZQkJXKFZY5yTupwMJoLqy64ZNUYGxGRrNSH aH0Lb89syp72ww4V/ZlePVxUjv4cH3JqaygVN297xPYL505mM01ujXfOoufoc97ViXHb 8+xoUjnsOUgpxj4U+KBRowZsSc3SE27s6xZMsK1dSQaLWQG8R0QEO0n+HMzO2seg2dfm HqGB4Svm5EAEDpoZPPENj1Hhbtm/FS+ADrMhjLWZVhbOrisxtnsm+jvfNayqVtslrvAW lCig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=shca+fk/7MzSlXw89ixMohOEKmbCATrZya3Tp4nmAco=; b=VFVSoFktN3foaymuvHd9wVST4oihM1wrOfr3mWuzM4jk4Wg56dKPYCrh0ZmTcPyRYS 61sD+b7fSxVNifK9HT+JQKPVoMCfCgxWCUlk5CQZl0H2AkqX5TfFGUp0UO3tCzK0A81G ka6GXrJsfNIFY55rxLOfOARMq+/MioKTVINTznh3QRmyXvTppEmlGLoFES+eRE6Gcany XVtToIuoUl7aVbVV+gRiuocd8WYoDx7h3Q/N/ic6y1h4BZg/YsiQrlfDKKefQDRYrKpn 9LMGlN6+QpcbD5nnVTGf13KZ8aLcQncxx+op+qWf6vAqmnIcRVchEbWVly25+tFtD5e9 ePkA== X-Gm-Message-State: ALyK8tJdHRYfbMuUTglzu9Zl+chuloEp1geyTYXFkgxrMob67UQ6FHKsUgI7toBgd+z3hw== X-Received: by 10.98.64.21 with SMTP id n21mr1435733pfa.161.1465433917239; Wed, 08 Jun 2016 17:58:37 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id z12sm5184189pfj.1.2016.06.08.17.58.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jun 2016 17:58:36 -0700 (PDT) Date: Wed, 8 Jun 2016 17:58:48 -0700 From: Stephen Hemminger To: Nikita Kozlov Cc: dev@dpdk.org, Nikita Kozlov Message-ID: <20160608175848.28bff0d1@xeon-e3> In-Reply-To: <1465433634-6667-3-git-send-email-nikita@elyzion.net> References: <1465433634-6667-1-git-send-email-nikita@elyzion.net> <1465433634-6667-3-git-send-email-nikita@elyzion.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] librte_eal: Import FreeBSD sys/tree.h into librte_eal/common X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 00:58:38 -0000 On Thu, 9 Jun 2016 02:53:53 +0200 Nikita Kozlov wrote: > This structure is used inside the rte_lpm6 lib for storing added rules. > It's imported from FreeBSD-10.3 from /usr/include/sys/tree.h, another > solution could have been to use on Linux the version from libbsd but it > would create an external dependency. > > Signed-off-by: Nikita Kozlov Using Red-black tree is a good idea, and we have been doing it for a while both on v4 and v6. But this is not the way to handle it. Please don't copy a header file which is available already on both BSD and Linux.