From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B20342935 for ; Thu, 9 Jun 2016 16:11:30 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 09 Jun 2016 07:11:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,445,1459839600"; d="scan'208";a="994328727" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.71]) by orsmga002.jf.intel.com with SMTP; 09 Jun 2016 07:11:09 -0700 Received: by (sSMTP sendmail emulation); Thu, 09 Jun 2016 15:11:08 +0025 Date: Thu, 9 Jun 2016 15:11:08 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Jerin Jacob , Ferruh Yigit , dev@dpdk.org Message-ID: <20160609141107.GA12520@bricha3-MOBL3> References: <1464540424-12631-1-git-send-email-jerin.jacob@caviumnetworks.com> <20160608150837.GA24684@bricha3-MOBL3> <20160609104922.GA27938@localhost.localdomain> <52365655.6dH803SFzQ@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52365655.6dH803SFzQ@xps13> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 00/20] DPDK PMD for ThunderX NIC device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 14:11:31 -0000 On Thu, Jun 09, 2016 at 04:02:17PM +0200, Thomas Monjalon wrote: > 2016-06-09 16:19, Jerin Jacob: > > On Wed, Jun 08, 2016 at 04:08:37PM +0100, Bruce Richardson wrote: > > > On Wed, Jun 08, 2016 at 03:42:14PM +0200, Thomas Monjalon wrote: > > > > 2016-06-08 18:13, Jerin Jacob: > > > > > On Wed, Jun 08, 2016 at 01:30:28PM +0100, Ferruh Yigit wrote: > > > > > > Hi Jerin, > > > > > > > > > > > > In patch subject, as tag, other drivers are using only driver name, and > > > > > > Intel drivers also has "driver/base", since base code has some special > > > > > > case. For thunderx, what do you think about keeping subject as: > > > > > > "thunderx: ...." > > > > > > > > > > > > > > > > Hi Ferruh, > > > > > > > > > > We may add crypto or other builtin ThunderX HW accelerated block drivers > > > > > in future to DPDK. > > > > > So that is the reason why I thought of keeping the subject as thunderx/nicvf. > > > > > If you don't have any objection then I would like to keep it as > > > > > thunderx/nicvf or just nicvf. > > > > > > > > I don't like the name nicvf but I guess that's the official name? > > > > > > > > Thus I agree the title should be thunderx/nicvf or thunderx_nicvf. > > > > > > I think I'd prefer the underscore version. > > > > underscore option looks bit odd when comparing to exiting other git logs. > > as Ferruh suggested "net/thunderx:" looks good to me. If their no > > objections I would like to go with "net/thunderx:" > > net/thunderx would be easy to parse if all other drivers were using > net/ or crypto/ prefixes. > Do we want to add these prefixes to driver commits? I would be in favour of that going forward. It would avoid problems between ring library and ring pmd, and vhost library and vhost pmd also. /Bruce