From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0B4C82716 for ; Thu, 9 Jun 2016 17:50:29 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 09 Jun 2016 08:50:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,445,1459839600"; d="scan'208";a="998652898" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.71]) by fmsmga002.fm.intel.com with SMTP; 09 Jun 2016 08:50:14 -0700 Received: by (sSMTP sendmail emulation); Thu, 09 Jun 2016 16:50:13 +0025 Date: Thu, 9 Jun 2016 16:50:13 +0100 From: Bruce Richardson To: Zhe Tao Cc: dev@dpdk.org, jingjing.wu@intel.com Message-ID: <20160609155013.GF12520@bricha3-MOBL3> References: <1458895321-21896-1-git-send-email-zhe.tao@intel.com> <1464110886-9504-1-git-send-email-zhe.tao@intel.com> <1464110886-9504-2-git-send-email-zhe.tao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464110886-9504-2-git-send-email-zhe.tao@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v8 1/3] i40e: support floating VEB config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 15:50:30 -0000 On Wed, May 25, 2016 at 01:28:04AM +0800, Zhe Tao wrote: > Add the new floating related argument option in the devarg. > Using this parameter, all the samples can decide whether to use legacy VEB/VEPA > or floating VEB. > To enable this feature, the user should pass a devargs parameter to the EAL > like "-w 84:00.0,enable_floating=1", and the application will make sure the PMD > will use the floating VEB feature for all the VFs created by this PF device. > > Signed-off-by: Zhe Tao > --- > drivers/net/i40e/i40e_ethdev.c | 44 ++++++++++++++++++++++++++++++++++++++++++ > drivers/net/i40e/i40e_ethdev.h | 6 ++++++ > 2 files changed, 50 insertions(+) I don't think we should ever use the word "floating" in this context without the word "VEB" on it as well, because it's really meaningless - being an adjective, it always requires a noun will it. This applies both to cmdline arguments and to commit messages. Secondly, these patches really could do with an explanation of what a floating VEB is and what it can do vs a non-floating VEB. I know that in the second patch you refer to standards which define VEBs, but: a) why is that reference not in patch 1? b) when I tried looking it up the spec requires a login for the IEEE site, and a google search for "floating VEB" only brings up links to these patches in patchwork. Regards, /Bruce