From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 16F5229CB for ; Fri, 10 Jun 2016 23:18:22 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 10 Jun 2016 14:18:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,452,1459839600"; d="scan'208";a="973242653" Received: from bmoreill-mobl.ger.corp.intel.com ([10.252.28.251]) by orsmga001.jf.intel.com with SMTP; 10 Jun 2016 14:18:17 -0700 Received: by (sSMTP sendmail emulation); Fri, 10 Jun 2016 22:18:14 +0025 Date: Fri, 10 Jun 2016 22:18:14 +0100 From: Bruce Richardson To: John Daley Cc: dev@dpdk.org, bruce.richarsdon@intel.com Message-ID: <20160610211813.GA15176@bricha3-MOBL3> References: <1464071579-30072-1-git-send-email-johndale@cisco.com> <1464913377-30879-1-git-send-email-johndale@cisco.com> <1464913377-30879-8-git-send-email-johndale@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464913377-30879-8-git-send-email-johndale@cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 07/13] enic: use Tx completion messages instead of descriptors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2016 21:18:23 -0000 On Thu, Jun 02, 2016 at 05:22:51PM -0700, John Daley wrote: > The NIC can either DMA a separate completion message for each > completed send or periodically just DMA an index of the last > completed send. Switch to the second method which improves > cache locality and performance. > > Signed-off-by: John Daley Can you perhaps send me an updated wording for this commit message as the title and commit message conflict. The title says to use completion messages not descriptors, while the body talks about moving away from a completion message way of working. Is the former method a descriptor writeback method, while the latter a head pointer writeback? If so, I think the title could be: "enic: use Tx head pointer not descriptor writeback" or something similar. Again, if you send on the updated commit text, I'll just update it on apply. I'd ideally like to get this patchset pushed to next-net first thing Monday. /Bruce