DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: helin.zhang@intel.com, jingjing.wu@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: fix unchecked return value
Date: Mon, 13 Jun 2016 11:09:56 +0100	[thread overview]
Message-ID: <20160613100955.GB13464@bricha3-MOBL3> (raw)
In-Reply-To: <1464074734-199475-1-git-send-email-danielx.t.mrzyglod@intel.com>

On Tue, May 24, 2016 at 09:25:34AM +0200, Daniel Mrzyglod wrote:
> Calling i40e_switch_rx_queue without checking return value.
> Fixed by add warning log information if return failed.
> 
> Fixes: 71d35259ff67 ("i40e: tear down flow director")
> Coverity ID 13198
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
>  drivers/net/i40e/i40e_fdir.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
> index 8aa41e5..ce6d916 100644
> --- a/drivers/net/i40e/i40e_fdir.c
> +++ b/drivers/net/i40e/i40e_fdir.c
> @@ -288,12 +288,15 @@ i40e_fdir_teardown(struct i40e_pf *pf)
>  {
>  	struct i40e_hw *hw = I40E_PF_TO_HW(pf);
>  	struct i40e_vsi *vsi;
> +	int err = I40E_SUCCESS;
>  
>  	vsi = pf->fdir.fdir_vsi;
>  	if (!vsi)
>  		return;
>  	i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
> -	i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
> +	err = i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
> +	if (err)
> +		PMD_DRV_LOG(WARNING, "Failed to do FDIR RX switch off.");
>  	i40e_dev_rx_queue_release(pf->fdir.rxq);

Please see my comments to the equivalent fix on the TX side, as I believe they
apply here too.

Ref: http://dpdk.org/dev/patchwork/patch/12940/

/Bruce

      parent reply	other threads:[~2016-06-13 10:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24  7:25 Daniel Mrzyglod
2016-05-25 10:42 ` Thomas Monjalon
2016-05-26  9:27   ` Mcnamara, John
2016-06-13 10:09 ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160613100955.GB13464@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=danielx.t.mrzyglod@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).