From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2DA38558D for ; Mon, 13 Jun 2016 17:46:55 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 13 Jun 2016 08:46:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,466,1459839600"; d="scan'208";a="121028069" Received: from lculbert-sp4.amr.corp.intel.com ([10.252.8.8]) by fmsmga004.fm.intel.com with SMTP; 13 Jun 2016 08:46:52 -0700 Received: by (sSMTP sendmail emulation); Mon, 13 Jun 2016 16:46:51 +0025 Date: Mon, 13 Jun 2016 16:46:51 +0100 From: Bruce Richardson To: Jerin Jacob Cc: dev@dpdk.org, thomas.monjalon@6wind.com, ferruh.yigit@intel.com Message-ID: <20160613154650.GJ15736@bricha3-MOBL3> References: <1465317632-11471-2-git-send-email-jerin.jacob@caviumnetworks.com> <1465826143-22159-1-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465826143-22159-1-git-send-email-jerin.jacob@caviumnetworks.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 00/19] DPDK PMD for ThunderX NIC device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2016 15:46:55 -0000 On Mon, Jun 13, 2016 at 07:25:24PM +0530, Jerin Jacob wrote: > This patch set provides the initial version of DPDK PMD for the > built-in NIC device in Cavium ThunderX SoC family. > > Implemented features and ThunderX nicvf PMD documentation added > in doc/guides/nics/overview.rst and doc/guides/nics/thunderx.rst > respectively in this patch set. > > These patches are checked using checkpatch.sh with following > additional ignore option: > options="$options --ignore=CAMELCASE,BRACKET_SPACE" > CAMELCASE - To accommodate PRIx64 > BRACKET_SPACE - To accommodate AT&T inline line assembly in two places > Hi Jerin, other than the fact that patch 1 is very big, this set looks pretty ok to me. However, as a general comment on the series: the commit titles are overly low-level, as they refer too much to function/structure names e.g. patches 4 through 10. If you run the script "check-git-log.sh" on your patchset this will be flagged. What is expected in commit titles is that the change introduced by the path is explained without directly using the function names. Regards, /Bruce