From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <viktorin@rehivetech.com>
Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16])
 by dpdk.org (Postfix) with ESMTP id C2983FE5
 for <dev@dpdk.org>; Mon, 13 Jun 2016 16:31:17 +0200 (CEST)
Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz
 [147.229.13.147])
 by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3rSwFK3hJXzYb;
 Mon, 13 Jun 2016 16:31:17 +0200 (CEST)
Date: Mon, 13 Jun 2016 16:26:10 +0200
From: Jan Viktorin <viktorin@rehivetech.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: David Marchand <david.marchand@6wind.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>, Bruce Richardson <bruce.richardson@intel.com>,
 Declan Doherty <declan.doherty@intel.com>, "jianbo.liu@linaro.org"
 <jianbo.liu@linaro.org>, "jerin.jacob@caviumnetworks.com"
 <jerin.jacob@caviumnetworks.com>, Keith Wiles <keith.wiles@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>, "dev@dpdk.org"
 <dev@dpdk.org>
Message-ID: <20160613162610.5cbf10e5@pcviktorin.fit.vutbr.cz>
In-Reply-To: <DB5PR0401MB2054EF431DB882F4ABE82C3B90530@DB5PR0401MB2054.eurprd04.prod.outlook.com>
References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com>
 <1462542490-15556-20-git-send-email-viktorin@rehivetech.com>
 <DB5PR0401MB2054EF431DB882F4ABE82C3B90530@DB5PR0401MB2054.eurprd04.prod.outlook.com>
Organization: RehiveTech
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v1 19/28] eal/soc: add drv_flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2016 14:31:17 -0000

On Mon, 13 Jun 2016 14:21:40 +0000
Shreyansh Jain <shreyansh.jain@nxp.com> wrote:

> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jan Viktorin
> > Sent: Friday, May 06, 2016 7:18 PM
> > To: dev@dpdk.org
> > Cc: Jan Viktorin <viktorin@rehivetech.com>; David Marchand
> > <david.marchand@6wind.com>; Thomas Monjalon <thomas.monjalon@6wind.com>;
> > Bruce Richardson <bruce.richardson@intel.com>; Declan Doherty
> > <declan.doherty@intel.com>; jianbo.liu@linaro.org;
> > jerin.jacob@caviumnetworks.com; Keith Wiles <keith.wiles@intel.com>; Stephen
> > Hemminger <stephen@networkplumber.org>
> > Subject: [dpdk-dev] [PATCH v1 19/28] eal/soc: add drv_flags
> > 
> > The flags are copied from the PCI ones. They should be refactorized into a
> > general set of flags in the future.
> > 
> > Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> > ---
> >  lib/librte_eal/common/include/rte_soc.h | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/lib/librte_eal/common/include/rte_soc.h
> > b/lib/librte_eal/common/include/rte_soc.h
> > index 49cfeb7..50a3b35 100644
> > --- a/lib/librte_eal/common/include/rte_soc.h
> > +++ b/lib/librte_eal/common/include/rte_soc.h
> > @@ -125,8 +125,18 @@ struct rte_soc_driver {
> >  	soc_devinit_t *devinit;            /**< Device initialization */
> >  	soc_devuninit_t *devuninit;        /**< Device uninitialization */
> >  	const struct rte_soc_id *id_table; /**< ID table, NULL terminated */
> > +	uint32_t drv_flags;                /**< Control handling of device */
> >  };
> > 
> > +/** Device needs to map its resources by EAL */
> > +#define RTE_SOC_DRV_NEED_MAPPING 0x0001
> > +/** Device needs to be unbound event if no module is provieded */  
> 
> Comment should read "Device needs to be unbound even if no module is provided"

OK, thanks.

> 
> > +#define RTE_SOC_DRV_FORCE_UNBIND 0x0004
> > +/** Device driver supports link state interrupt */
> > +#define RTE_SOC_DRV_INTR_LSC	 0x0008
> > +/** Device driver supports detaching capability */
> > +#define RTE_SOC_DRV_DETACHABLE	 0x0010
> > +
> >  /**
> >   * A structure describing a SoC mapping.
> >   */
> > --
> > 2.8.0  
>