From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 517438D97 for ; Tue, 14 Jun 2016 13:58:25 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 14 Jun 2016 04:58:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,470,1459839600"; d="scan'208";a="827766312" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 14 Jun 2016 04:58:23 -0700 Date: Tue, 14 Jun 2016 20:00:32 +0800 From: Yuanhan Liu To: dev@dpdk.org Cc: huawei.xie@intel.com, Thomas Monjalon , Panu Matilainen , Traynor Kevin , Rich Lane , Tetsuya Mukawa Message-ID: <20160614120032.GW10038@yliu-dev.sh.intel.com> References: <1463117111-27050-1-git-send-email-yuanhan.liu@linux.intel.com> <1465271530-27878-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465271530-27878-1-git-send-email-yuanhan.liu@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 11:58:25 -0000 Applied to dpdk-next-virtio. --yliu On Tue, Jun 07, 2016 at 11:51:50AM +0800, Yuanhan Liu wrote: > v3: - adapted the new vhost ABI/API changes to tep_term example, to make > sure not break build at least. > - bumped the ABI version to 3 > > NOTE: I created a branch at dpdk.org [0] for more conveinient testing: > > [0]: git://dpdk.org/next/dpdk-next-virtio for-testing > > > Every time we introduce a new feature to vhost, we are likely to break > ABI. Moreover, some cleanups (such as the one from Ilya to remove vec_buf > from vhost_virtqueue struct) also break ABI. > > This patch set is meant to resolve above issue ultimately, by hiding > virtio_net structure (as well as few others) internaly, and export the > virtio_net dev strut to applications by a number, vid, like the way > kernel exposes an fd to user space. > > Back to the patch set, the first part of this set makes some changes to > vhost example, vhost-pmd and vhost, bit by bit, to remove the dependence > to "virtio_net" struct. And then do the final change to make the current > APIs to adapt to using "vid". > > After that, "vrtio_net_device_ops" is the only left open struct that an > application can acces, therefore, it's the only place that might introduce > potential ABI breakage in future for extension. Hence, I made few more > (5) space reservation, to make sure we will not break ABI for a long time, > and hopefuly, forever. > > The last bit of this patch set is some cleanups, including the one from > Ilya. > > v2: - exported ifname as well to fix a vhost-pmd issue reported by Rich > - separated the big patch that introduces several new APIs into some > small patches. > - updated release note > - updated version.map > > Thanks. > > --yliu > > --- > Ilya Maximets (1): > vhost: make buf vector for scatter Rx local > > Yuanhan Liu (19): > vhost: declare backend with int type > vhost: set/reset dev flags internally > vhost: declare device fh as int > examples/vhost: make a copy of virtio device id > vhost: rename device fh to vid > vhost: get device by vid only > vhost: move vhost device ctx to cuse > vhost: introduce new API to export numa node > vhost: introduce new API to export number of queues > vhost: introduce new API to export ifname > vhost: introduce new API to export queue free entries > vhost: remove dependency on priv field > vhost: export vid as the only interface to applications > vhost: hide internal structs/macros/functions > vhost: remove unnecessary fields > vhost: remove virtio-net.h > vhost: reserve few more space for future extension > examples/tep_term: adapt to new vhost ABI/API changes > vhost: per device virtio net header len > > doc/guides/rel_notes/release_16_07.rst | 11 +- > drivers/net/vhost/rte_eth_vhost.c | 79 ++++----- > examples/tep_termination/main.c | 83 +++++----- > examples/tep_termination/main.h | 5 +- > examples/tep_termination/vxlan_setup.c | 20 +-- > examples/tep_termination/vxlan_setup.h | 6 +- > examples/vhost/main.c | 116 +++++++------ > examples/vhost/main.h | 3 +- > lib/librte_vhost/Makefile | 2 +- > lib/librte_vhost/rte_vhost_version.map | 10 ++ > lib/librte_vhost/rte_virtio_net.h | 223 +++++++------------------ > lib/librte_vhost/vhost-net.h | 201 ++++++++++++++++++---- > lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 83 +++++----- > lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 30 ++-- > lib/librte_vhost/vhost_cuse/virtio-net-cdev.h | 12 +- > lib/librte_vhost/vhost_rxtx.c | 133 ++++++++------- > lib/librte_vhost/vhost_user/vhost-net-user.c | 53 +++--- > lib/librte_vhost/vhost_user/vhost-net-user.h | 2 + > lib/librte_vhost/vhost_user/virtio-net-user.c | 64 +++---- > lib/librte_vhost/vhost_user/virtio-net-user.h | 18 +- > lib/librte_vhost/virtio-net.c | 229 +++++++++++++++++--------- > lib/librte_vhost/virtio-net.h | 43 ----- > 22 files changed, 752 insertions(+), 674 deletions(-) > delete mode 100644 lib/librte_vhost/virtio-net.h > > -- > 1.9.0