From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 49430C50A
 for <dev@dpdk.org>; Thu, 16 Jun 2016 11:46:31 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP; 16 Jun 2016 02:46:30 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,478,1459839600"; d="scan'208";a="998817979"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.182])
 by orsmga002.jf.intel.com with SMTP; 16 Jun 2016 02:46:28 -0700
Received: by  (sSMTP sendmail emulation); Thu, 16 Jun 2016 10:46:27 +0025
Date: Thu, 16 Jun 2016 10:46:27 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
 Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Message-ID: <20160616094627.GC11016@bricha3-MOBL3>
References: <1465250923-78695-1-git-send-email-stephen.hurd@broadcom.com>
 <1465944971-113413-1-git-send-email-stephen.hurd@broadcom.com>
 <1465944971-113413-2-git-send-email-stephen.hurd@broadcom.com>
 <57618188.8090804@intel.com>
 <CAJ9nmBYKgc=rmTvMaXK+GG9xh_C5cAwk-ECnvPYMnaX9BmY=TQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJ9nmBYKgc=rmTvMaXK+GG9xh_C5cAwk-ECnvPYMnaX9BmY=TQ@mail.gmail.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v5 02/38] bnxt: add HWRM init code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2016 09:46:31 -0000

On Wed, Jun 15, 2016 at 01:28:13PM -0700, Stephen Hurd wrote:
> On Wed, Jun 15, 2016 at 9:25 AM, Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> 
> >
> > Hi Stephen,
> >
> > I run basic checks on the patch set, mainly it compiles and applies
> > fine, overall patch set looks good.
> >
> > Only get following checkpatch warning:
> > Only v5,02/38 has one WARNING:MACRO_WITH_FLOW_CONTROL
> >
> 
> This is intentional, is this style of copy/paste avoidance not allowed?
> 
It's fine. Some checkpatch exceptions like this are allowed when they make sense.

Regards,
/Bruce