From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0091.outbound.protection.outlook.com [157.56.110.91]) by dpdk.org (Postfix) with ESMTP id EE86EC63C for ; Thu, 16 Jun 2016 13:18:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iDvaM1ZFAv5hofiJpONzOXB05fj2nPyguYYw4ao83Sw=; b=ZVCWpxy1bFgwqmPrYxWpGgLDCwsztGDMJetHjRjhwEd8TxLE2/F0IUkExC8XfMkcouXTloUtFnwrNvXQftqpSxmO9CyhcM+jPNX3TMG6arb0E2vsltREkYTjNE9GGYXQEopaoQwM6WHA2nbSb7SaAFSCBu2Au8ebX99ZDABPjus= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.171.152.114) by BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) with Microsoft SMTP Server (TLS) id 15.1.517.8; Thu, 16 Jun 2016 11:17:57 +0000 Date: Thu, 16 Jun 2016 16:47:39 +0530 From: Jerin Jacob To: Bruce Richardson CC: , , Message-ID: <20160616111737.GA27345@localhost.localdomain> References: <1465826143-22159-1-git-send-email-jerin.jacob@caviumnetworks.com> <1465931200-23912-1-git-send-email-jerin.jacob@caviumnetworks.com> <20160615143925.GD11536@bricha3-MOBL3> <20160616093059.GA21920@localhost.localdomain> <20160616105827.GF11016@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160616105827.GF11016@bricha3-MOBL3> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [122.171.152.114] X-ClientProxiedBy: MA1PR01CA0035.INDPRD01.PROD.OUTLOOK.COM (10.164.117.42) To BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) X-MS-Office365-Filtering-Correlation-Id: 38129d86-06fb-41c2-b86a-08d395d7df99 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 2:iUPg3bBOssLgjvJkEVQEuiC2CRDtZ4JrLFvhzCTm2TthioK9zzv0BNlQqOt1MOt9IdQLm0+1Se19k5AIMzGLTg9ZQ7vtzFEI+7iuZ5h9VmpsdEJ8nS6WCkq1OzBB3O9TNTVxzoegIE+UpOZOtDTkmjO92QV3+syI9+YPWiX2bREFZ5y5KLv16Zvd6kwoclyE; 3:VoTZyrBYg8Lc/4skv7loL4xo0PFokd5KUXD/hujQ0ffDfLY1rZenPzdiD9cNYCIlKLfi03q74r+m2GLWC0rsyi0t/JrKYdhowDZxLLadFEQLpv0RYn0m3TdQYth88q58 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 25:dUDa4iA0rRKOuSq8nsk/+lCgbU1spajrATdKucGKpxMTfMMaUXdvGLvdxftA4J+hu8V0xMkjeuWEDZga9ZZKqKbVNOnft0+IAIfiK+CnttWx2PmR4e9luTStzbN5wpBfNRkYai/bYunr3BdNXtj525X3SWx+r/6WrYCT41jNThjNKmUGPM6uqTFqMI/TZPaHF11qu9da50q8iv7sW4UUCcNgxm1nUFwaKn7o0ZNx6wfGJJ2NuR6hAPiV8GQ9tmGKTjv7/UzcADfCQNfNv8UvL8Y8RymYsDBc3FQjIbO6Sr8MOa9jX1Gq6dBGNfZMV2wWBMa/9sBbcxRDP37K697eV2cdBh76s/1xrTvqtVtPqUrtCbTweB2FQGizMhftnPUSn1Pc4MgVLWDR0WFNebK6eu42fFCBmR3L/kCjmeVfGW5mGvblcrEgQZWrcrsskBRt7bS5AipUtEuRs2mcKU/rwiT5bNngvSNZecZcwrD83kmNzvmbgKtCUDsuHPtpMaHop0kcBMJCpcYv1qmzkTDqTyrJ9ccyPputnrM/WNcqwBCAYJZ4DjGU8PdgbgPz5rQMB1QTMW44PZQDgkZds5h4rCC53p6MqPW9ZOJY8iFVszIAf19TS8zJNzh3Yih5hHg9eyxve35UNWEXqCu6nzwNVH1/6/uArZSpkRFmZCHSvvxxTleoo9vO8szQC9tzOt0p21+eAHmpGU2nZR0DPw1whD7FXU1I1y/19syuzi6kMvX8nymnzcyFrp4wWs92LeyZI+H0V5hLLuwIenIclrgodtlKHH/V1TXj2SrAb+5IzJCiG5GQN9H1479GAEwR75NL4mW/kSISJ2wnspLbSkZ1dw== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 20:cAXsPO5xaFLEYeqDe3v6QmAFb7O7ppZqrYNDQWsn8DMX4oorzkd0KjwRMo35QZO9jNuTiPL4tSJ4wmDcGNziPNIX4l3uoBoPKwXT+0qIHxoF5Kq4kX8Yph12IRLkocumQAO/Uq03vorRbETpA3TjScPymXSZdpfv/R+45gAgMeFetwdYugWp4LjEpgJ7wuA2ssy1OcDK1sOjzTSalPaoPxJUah18N/Xqt/WCayzWyt9ShiK3iFFdtX9DTHX69m9xg8d/S5sm6WJLZ2yev6ApTiejFY6XvZSq1WWi1w2ErILjJKaMrXi5ZPyU3244vfyGyVvoFTTYvfnnR3Gc2X7mGHq4mS1TKwz07+CwQwrQZsxbxIoLV6TthsY6vAAgbAv2mY9pvV7QzQSV9AsuYRq2Az7BAxPUAWBkUIe5G3pRRS1NF39+vrGfqueJE72lG+bNscj0UEHa5DI5YAwi8rGzhPQ5OtdtC4Grf4A4TzZ+LryAz9ko3IdzJKyQugcx3pzTdO3H1RwmbsNEUCeQIB5vXqtsC49rJopFKAek+4so1UgBfPD1F8Twpy5ZVHqc84jCWhv2AeH2jhAuq52EZLpt9s5vuhUJw1yfP1F5GbRiwCs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BLUPR0701MB1716; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 4:EYh0bwG8JBK4vL+LC55S6JQr8ZRNeY3e423BAd9N1Xg9p1dfF4T5qSn+w1QI4pSZGDZYHhCR8IcXtZNPr8fn2KFq0vn0V/V00T68PYcA1m8xJaR5XSXMj6RXRmCNcZTPgaR+Us/tnnWTni7/Wbgb6mgtaFI8pKHL70TWyZuJ2LeNo9iVxMW4x7p/sGR8Ih/+0tri6271vQVA15jEACkt5GN664p4EISdrEMPKdzCduD5Ag79wDaFQO4yd1+hpKlS6iztC+CJyIT9gj45DNq65AHM8/LfiJa4ylhZHvWFo3C+1Ch9POIiHSXejLsmN/11CsXVOU9ZnPWWMaycXBzZX7bstP5QVLZXVxgX6B3P8J6lL4hsZu+zDp3M63CEkQOY X-Forefront-PRVS: 09752BC779 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(199003)(24454002)(52544003)(189002)(19580395003)(47776003)(68736007)(33656002)(4001350100001)(97736004)(3846002)(23726003)(6116002)(92566002)(575784001)(586003)(66066001)(110136002)(9686002)(83506001)(42186005)(106356001)(93886004)(50986999)(54356999)(76176999)(46406003)(15395725005)(105586002)(61506002)(81156014)(189998001)(101416001)(2950100001)(50466002)(5008740100001)(15975445007)(77096005)(8676002)(81166006)(1076002)(4326007)(97756001)(2906002)(5004730100002)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1716; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; CAT:NONE; LANG:en; CAT:NONE; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1716; 23:aao5AO5OaX3R2iVwiEftFZmbHdZ1yuL/U1Ixber?= =?us-ascii?Q?RxCOoBcrW5yJ4fjR5r+M5/lgyrW8170VUo0dlzaqvgFdOhSHhLMWhHa9T3Pc?= =?us-ascii?Q?YjlHzV+DoNLATOfWc/HUMkV1CesHul/7aoVViprCmTfxvvunvU1OoA4UECSF?= =?us-ascii?Q?EUo9p83ykYNWJyNf0fWKXs/X4u6llBiCe8AO6dV6+uCidpcUD2dC+WxYNvVE?= =?us-ascii?Q?f7kROdpAM2LGjOJSsiQK9/5PyjBpp5c8n5mBCIeBkYJHTcTsH3ENv7I+nn3D?= =?us-ascii?Q?x627w9LoVezh2dUnsakJPwBtx9oWF5UbkPJLmiNuRodp+FFbE9FEAOuPgiSO?= =?us-ascii?Q?XglQKKb7IXqOswaUeRHWJZbprYGBXTmTkAOWEfbNcKV8TniGFjx+NJBKgaIY?= =?us-ascii?Q?1oDiWlbts/k+S9GT62UIK1oVmIqfMsMpzncZUKqHenRJ/TYbm+gfpgT/E5Es?= =?us-ascii?Q?EQigRiUF3oaQX3u8M3xs9SXcH06FJottwDy9mY3jKg15FGm3oyTvniVmq+tA?= =?us-ascii?Q?8mejH3dPjQJ4uz32voJTUJvkeR3OoLEYq+ZKKVnRo+AAnESsMXarJyrCaHhW?= =?us-ascii?Q?5ruoYfxwdQ+0Mpy3HddJ4NO/f77fp/rdJNFgXLoGrvQCOeSgLKQUrxLfuizS?= =?us-ascii?Q?gbmRNStQu9wUyrLZvLmsvwovrQIyUcTjrC33MLUmQ/CZGz+p9MWTu9T5s5C5?= =?us-ascii?Q?22tVc+q1J5u5JJ7BXurN1dl6n82pugcTE7KL0aXFu41EG5MsPRApEuGdtqaU?= =?us-ascii?Q?2/HOc0NJm/mVA42HHuX9qLyIDFO27gDq4R1XDAooivxXX+1FLnU6EIGFx1DN?= =?us-ascii?Q?BuzEpUffHAeu2F68Gc7GLRe9FNBlGDeV1YfGdEJwv4XsB060vHpw8jH6khYX?= =?us-ascii?Q?5JomcbxoZAExm01kQD9pZdGmDZZ9h8C+aZ+Xd4xE8jKmR28hxt4tsI/ezUBd?= =?us-ascii?Q?dmmVj5mqYOMLgH2bc8agXSilOFcF1eH0WZmYZ7Ulu/p9fxZ5EqtjGYKKNKvB?= =?us-ascii?Q?YpQT+pAHuxiNIkbwZ7bupP0VVY+toveGhQtc0hU1lfPsBkl7W8hkl0Xf9nVr?= =?us-ascii?Q?nMesryfNI9fR6GzTFSaTGrWP5clpQqcGpKhe+Fg+cay0nrpDDJzMKHJRaAy6?= =?us-ascii?Q?KBexnFoEnn23G9rp3fxTtr8TtzrzmvOQ1OzfWvC9PUl1jo82O6AKvh4ds2vh?= =?us-ascii?Q?B5Z8X1WQHPmt6RCsjPPfHdRNIp7k8TZkmkSicyPfGGdB6r7bw5BTI/1ioDZs?= =?us-ascii?Q?EPa3IaTKYUYjwmyTAtqayshBLNKdhEvkLN2Uy+Xrd?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 6:d0CD3uRyWlYFUprP3pM+xPBPRnfKhhyqCdTnOsOpFQiv+9n/y+1rtm8FOoFuZEqKtfa2U0T5UT+RB0hGFCocoyytmanIIq2l/uaJCg4aagdF2p5uJfyThDNPzLEYdtlGrtxg3sNtGSzCUMlykuObHej5DLWMHhc1J4gxOgGsZUeKj44pZspwx+DoYiMRkk6KdKvPtgYfnxiOi7M5wefY9179MnrzjFPauAftU7/L4eWVXBHTJzroXJlxyXScFkCO1/E8Cb+c2oXAzrIBvGOQUFPY8nbUlj58D8f69q3RDik=; 5:KqVvHkMu0eBBRHS3gL3ybu9eSb+cXqNql7Y5xHVrbFI3nq7+qDX3FeE9ujKxbcZJL2DjfJDQGC6WtMvxc1vpKh7BBM6Uaemk8Ssg5/enJzXDrTehpFkVfbgUZkv1WaTr2Hdz1WYdoUoagjWg2sFphw==; 24:8V7UCKHI8wvxeuCcjg2cAulzTPMmSlJePN8DH+mcm0jAvPwPkHDcGPURHzhW3gOMwPiRkoQ38JEdSQJSOpd3tzl0nkwctXokHUnQ/EupefA=; 7:teyk1MOQpjAFglZ/CahlU7MvvOLJp3MmGPBQfEN1kJBYPxcUdkp59u2BwyPEA8F5qGo/gOLMJJMmuDUO1+UpVQyfl4DCsdD9OdSD5zl1AFOXFyurN0SmHEk78BbSKlJonGgiOxh1xWZkz1R647TbTp++REXjoHjlwjYkCjzSvO69L5v3A+fz2uPra8YdyNNCrRPMUlH2jrpzyKvXdunyMA== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2016 11:17:57.2052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1716 Subject: Re: [dpdk-dev] [PATCH v5 00/25] DPDK PMD for ThunderX NIC device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2016 11:18:01 -0000 On Thu, Jun 16, 2016 at 11:58:27AM +0100, Bruce Richardson wrote: > On Thu, Jun 16, 2016 at 03:01:02PM +0530, Jerin Jacob wrote: > > On Wed, Jun 15, 2016 at 03:39:25PM +0100, Bruce Richardson wrote: > > > On Wed, Jun 15, 2016 at 12:36:15AM +0530, Jerin Jacob wrote: > > > > This patch set provides the initial version of DPDK PMD for the > > > > built-in NIC device in Cavium ThunderX SoC family. > > > > > > > > Implemented features and ThunderX nicvf PMD documentation added > > > > in doc/guides/nics/overview.rst and doc/guides/nics/thunderx.rst > > > > respectively in this patch set. > > > > > > > > These patches are checked using checkpatch.sh with following > > > > additional ignore option: > > > > options="$options --ignore=CAMELCASE,BRACKET_SPACE" > > > > CAMELCASE - To accommodate PRIx64 > > > > BRACKET_SPACE - To accommodate AT&T inline line assembly in two places > > > > > > > > This patch set is based on DPDK 16.07-RC1 > > > > and tested with git HEAD change-set > > > > ca173a909538a2f1082cd0dcb4d778a97dab69c3 along with > > > > following depended patch > > > > > > > > http://dpdk.org/dev/patchwork/patch/11826/ > > > > ethdev: add tunnel and port RSS offload types > > > > > > > Hi Jerin, > > > > > > hopefully a final set of comments before merge on this set, as it's looking > > > very good now. > > > > > > * Two patches look like they need to be split, as they are combining multiple > > > functions into one patch. They are: > > > [dpdk-dev,v5,16/25] net/thunderx: add MTU set and promiscuous enable support > > > [dpdk-dev,v5,20/25] net/thunderx: implement supported ptype get and Rx queue count > > > For the other patches which add multiple functions, the functions seem to be > > > logically related so I don't think there is a problem > > > > > > * check-git-logs.sh is warning about a few of the commit messages being too long. > > > Splitting patch 20 should fix one of those, but there are a few remaining. > > > A number of titles refer to ThunderX in the message, but this is probably > > > unnecessary, as the prefix already contains "net/thunderx" in it. > > > > OK. I will send the next revision. > > > > Please hold off a few hours, as I'm hoping to merge in the bnxt driver this > afternoon. If all goes well, I would appreciate it if you could base your patchset > off the rel_16_07 tree with that set applied - save me having to resolve conflicts > in files like the nic overview doc, which is always a pain to try and edit. :-) OK. I will re-base the changes once you have done with bnxt merge. Let me know once its done. > > Regards, > /Bruce