From: Bruce Richardson <bruce.richardson@intel.com>
To: Jianbo Liu <jianbo.liu@linaro.org>
Cc: "Xu, Qian Q" <qian.q.xu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: avoid unnessary break when checking at the tail of rx hwring
Date: Fri, 17 Jun 2016 11:09:23 +0100 [thread overview]
Message-ID: <20160617100922.GA14948@bricha3-MOBL3> (raw)
In-Reply-To: <CAP4Qi3_POihX25PHyxyxqkOXGA8JZJYwQeBK7NeZU9GJjA25Ag@mail.gmail.com>
On Mon, Mar 28, 2016 at 04:48:17PM +0800, Jianbo Liu wrote:
> Hi Qian,
>
> On 28 March 2016 at 10:30, Xu, Qian Q <qian.q.xu@intel.com> wrote:
> > Jianbo
> > Could you tell me the case that can reproduce the issue? We can help evaluate the impact of performance on ixgbe, but I'm not sure how to check if your patch really fix a problem because I don’t know how to reproduce the problem! Could you first teach me on how to reproduce your issue? Or you may not reproduce it by yourself?
> >
> It is more an refactoring to original design than fixing an issue. So
> I don't know how to reproduce either.
> Can you use your usual performance testing cases first, and see if
> there is any impact or improvement?
>
Since there is no further discussion or update on this patch, I'm going to mark
it as rejected in patchwork, rather than have it live on as a zombie patch.
If this change is wanted for 16.11 or any subsequent release, please resubmit
it for consideration with any performance data justifications (and a reference
back to this thread).
Thanks,
/Bruce
prev parent reply other threads:[~2016-06-17 10:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 14:25 Jianbo Liu
2016-03-16 6:06 ` Lu, Wenzhuo
2016-03-16 7:51 ` Jianbo Liu
2016-03-16 11:14 ` Bruce Richardson
2016-03-17 2:20 ` Jianbo Liu
2016-03-18 10:03 ` Bruce Richardson
2016-03-21 2:26 ` Jianbo Liu
2016-03-22 14:27 ` Ananyev, Konstantin
2016-03-25 8:53 ` Jianbo Liu
2016-03-28 2:30 ` Xu, Qian Q
2016-03-28 8:48 ` Jianbo Liu
2016-06-17 10:09 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617100922.GA14948@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jianbo.liu@linaro.org \
--cc=konstantin.ananyev@intel.com \
--cc=qian.q.xu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).