From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 47FEBCC6C
 for <dev@dpdk.org>; Fri, 17 Jun 2016 12:09:29 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP; 17 Jun 2016 03:09:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,483,1459839600"; d="scan'208";a="977826787"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.182])
 by orsmga001.jf.intel.com with SMTP; 17 Jun 2016 03:09:23 -0700
Received: by  (sSMTP sendmail emulation); Fri, 17 Jun 2016 11:09:23 +0025
Date: Fri, 17 Jun 2016 11:09:23 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jianbo Liu <jianbo.liu@linaro.org>
Cc: "Xu, Qian Q" <qian.q.xu@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20160617100922.GA14948@bricha3-MOBL3>
References: <6A0DE07E22DDAD4C9103DF62FEBC09090343BBF2@shsmsx102.ccr.corp.intel.com>
 <CAP4Qi39rHsZR3qMBnRJgcoWGVjS8eDYcvfPoLxCZX1KBJm2eqQ@mail.gmail.com>
 <20160316111454.GB24668@bricha3-MOBL3>
 <CAP4Qi3-XTE4wEmPCbrFi7KPAr0vFW3ttn86yr3KsC7=qsir6+Q@mail.gmail.com>
 <20160318100358.GA4848@bricha3-MOBL3>
 <CAP4Qi39tLm3_LDySikA96mjxxXJVbNkCNg96QkNeYc=R0cqjbg@mail.gmail.com>
 <2601191342CEEE43887BDE71AB97725836B1FAE1@irsmsx105.ger.corp.intel.com>
 <CAP4Qi39BKcnT6Z0LNR1Ny38+qs8jz9=kES_a6vyBrTWt5wPqTg@mail.gmail.com>
 <82F45D86ADE5454A95A89742C8D1410E032143C2@shsmsx102.ccr.corp.intel.com>
 <CAP4Qi3_POihX25PHyxyxqkOXGA8JZJYwQeBK7NeZU9GJjA25Ag@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAP4Qi3_POihX25PHyxyxqkOXGA8JZJYwQeBK7NeZU9GJjA25Ag@mail.gmail.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] ixgbe: avoid unnessary break when checking
 at the tail of rx hwring
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jun 2016 10:09:29 -0000

On Mon, Mar 28, 2016 at 04:48:17PM +0800, Jianbo Liu wrote:
> Hi Qian,
> 
> On 28 March 2016 at 10:30, Xu, Qian Q <qian.q.xu@intel.com> wrote:
> > Jianbo
> > Could you tell me the case that can reproduce the issue? We can help evaluate the impact of performance on ixgbe, but I'm not sure how to check if your patch really fix a problem because I don’t know how to reproduce the problem! Could you first teach me on how to reproduce your issue? Or you may not reproduce it by yourself?
> >
> It is more an refactoring to original design than fixing an issue. So
> I don't know how to reproduce either.
> Can you use your usual performance testing cases first, and see if
> there is any impact or improvement?
> 

Since there is no further discussion or update on this patch, I'm going to mark
it as rejected in patchwork, rather than have it live on as a zombie patch.

If this change is wanted for 16.11 or any subsequent release, please resubmit
it for consideration with any performance data justifications (and a reference
back to this thread).

Thanks,
/Bruce