From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by dpdk.org (Postfix) with ESMTP id 9993B2BAB for ; Mon, 20 Jun 2016 18:19:26 +0200 (CEST) Received: by mail-pa0-f49.google.com with SMTP id wo6so15895825pac.3 for ; Mon, 20 Jun 2016 09:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zkCVkeQHBoI9vCHiKf+DPuuObOAmLmgU1TTS3P/o+VM=; b=aOE1wEtIzNSVmwSc6xKT9/cHYAkd2o2320Ct7OX9PSI5RAJ7zCPKi0GwoyFLwsfBJf wTZdfUasWV691jiX7AOvL77fdNLoVUPYz9gh9mPR4el4Fmg1N9r1LoPPzTKnsYZFuRf1 xHmN+kw4IkXdtya/g4wjWGAZO05pNMDJ60HHSoEvnwmVyWHIM8/O0qqwXyw2FRbCt0op vJUSV5qYaFvYrh5JufrDEeXH2hTV7cmdJ2iw9mkRHBdxXa1JOIwp06DJZO0RpMt6Ve0Y 7nGdTAyGunJVmT+M2GEFTEElQ9iA9Sywitw8vcJN2HrmL2CoqqQn7eJtzAzeI0yfd34x jhaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zkCVkeQHBoI9vCHiKf+DPuuObOAmLmgU1TTS3P/o+VM=; b=EN8JYt2BHaWpP8ZzUXUQTBrN2Znyl7fxnk9Ht0vLPD5C2BRS4H/JQ2ddRns48NpV1p znzb86khXVM+n9PnGcFYXA+G7E1BILP9ap4qB5Ym7KVs5yd2gx6hXGvNdvUIVj96ITTh cqmpuRlJGlPx8oaaq1I1E4rcq+7bktsqK7bJMbir5Tw0OUsUK1gH7E89GHep0tTfko/z SOMVbaeMMVGPRTl+ZDRjqh5kvJkdFtbKDEN44C+Ws7z2b3R+mjsG+FEeJGdQNPTvA4p6 o/qF1zGiuKC/ODMb/E7P9zJOselqEMff1mQX4WwJ5sMmAZI9lq+ZhJnGFCVlHB/mywkl cQdw== X-Gm-Message-State: ALyK8tLNvJfCq2gg505PP3KhIzC+Nmo3bylUFc3/OFgDQ7aZTPONbtVgkq6eo/lEIN6Bcw== X-Received: by 10.66.185.229 with SMTP id ff5mr22457094pac.132.1466439565928; Mon, 20 Jun 2016 09:19:25 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id m8sm42417578pfi.27.2016.06.20.09.19.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jun 2016 09:19:25 -0700 (PDT) Date: Mon, 20 Jun 2016 09:19:40 -0700 From: Stephen Hemminger To: Simon Kagstrom Cc: olivier.matz@6wind.com, dev@dpdk.org Message-ID: <20160620091940.75a37c54@xeon-e3> In-Reply-To: <20160620124435.23d43f28@miho> References: <20160620124435.23d43f28@miho> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] PATCH] mbuf: rte_pktmbuf_dump: don't add 0x when using %p in format strings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 16:19:27 -0000 On Mon, 20 Jun 2016 12:44:35 +0200 Simon Kagstrom wrote: > I.e., avoid dump messages with double 0x0x, e.g., > > dump mbuf at 0x0x7fac7b17c800, phys=17b17c880, buf_len=2176 > pkt_len=2064, ol_flags=0, nb_segs=1, in_port=255 > segment at 0x0x7fac7b17c800, data=0x0x7fac7b17c8f0, data_len=2064 > > Signed-off-by: Simon Kagstrom Agreed. Many other places have same glitch. $ git grep '0x%p' drivers/net/vmxnet3/vmxnet3_rxtx.c: "RXQ: cmd0 base : 0x%p cmd1 base : 0x%p comp ring base : 0x%p.", drivers/net/vmxnet3/vmxnet3_rxtx.c: PMD_TX_LOG(DEBUG, "TXQ: cmd base : 0x%p comp ring base : 0x%p data ring base : 0x%p.", lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c: printk(KERN_DEBUG "ixgbe_get_regs_2 0x%p\n", hw->hw_addr); lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("tx_phys: 0x%016llx, tx_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("rx_phys: 0x%016llx, rx_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("alloc_phys: 0x%016llx, alloc_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("free_phys: 0x%016llx, free_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("req_phys: 0x%016llx, req_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("resp_phys: 0x%016llx, resp_q addr: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("mbuf_phys: 0x%016llx, mbuf_kva: 0x%p\n", lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("mbuf_va: 0x%p\n", dev_info.mbuf_va); lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_DBG("PCI found: pci=0x%p, lad_dev=0x%p\n", lib/librte_mbuf/rte_mbuf.c: fprintf(f, "dump mbuf at 0x%p, phys=%"PRIx64", buf_len=%u\n", lib/librte_mbuf/rte_mbuf.c: fprintf(f, " segment at 0x%p, data=0x%p, data_len=%u\n",