From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.Jacob@cavium.com> Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0100.outbound.protection.outlook.com [65.55.169.100]) by dpdk.org (Postfix) with ESMTP id D39066CCD for <dev@dpdk.org>; Mon, 20 Jun 2016 16:22:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1YxXptXOGmwJYSrSGV/tCpUDoz8nR1vITJHv6V99K7M=; b=Tbp4Rc7ILnzuvHaJUuBP/oVHYoPEeXh9NHLo7edzD5iBY96cBRns6AHfk8I0EFPMQ+B1/AEfAxCnfvwN7qaPTeUBcmnv6dm2G0i99P4zRtW/wfCjKf0Zr/nYg46Hzk/QL6ILJPEKDy+O9i8B7z/PBIAlbnjbUOwMH0/YnliRmd8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.166.159.122) by BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) with Microsoft SMTP Server (TLS) id 15.1.517.8; Mon, 20 Jun 2016 14:22:25 +0000 Date: Mon, 20 Jun 2016 19:52:07 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> CC: Thomas Monjalon <thomas.monjalon@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>, "Hunt, David" <david.hunt@intel.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "viktorin@rehivetech.com" <viktorin@rehivetech.com>, "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com> Message-ID: <20160620142205.GA4118@localhost.localdomain> References: <1463669335-30378-1-git-send-email-david.hunt@intel.com> <1466428091-115821-2-git-send-email-david.hunt@intel.com> <20160620132506.GA3301@localhost.localdomain> <3416153.NDoMD8TpjF@xps13> <2601191342CEEE43887BDE71AB97725836B73750@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB97725836B73750@irsmsx105.ger.corp.intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [122.166.159.122] X-ClientProxiedBy: MAXPR01CA0044.INDPRD01.PROD.OUTLOOK.COM (10.164.146.144) To BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) X-MS-Office365-Filtering-Correlation-Id: c43f19bf-08ac-445d-3a34-08d399164f2d X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 2:56EOiIP0jSecSA8qsrw4pOXyfX6h2mF5TKEmiQ0aKTZv2V8g9YnYg0jOuG29Lk3nmUvgMcNbo0iHZVxFmyJoX6ucOQTF7POnOD+nCCzz8iNH7PWq1ALYzG8fIOE6sOXArS6CyOlp+ouJggHoMAORGcxyE8rPuWvYD6rGbK8vhJ1KRic6wVEekuoBOznenr6B; 3:x+p6KKfHtCWo+rE88d5OlAQ76E5C6eudlqp6KGXQHV46sjtK6qVOgj53O5KJ6yO8i/UV+aenNxV+6MPdQtztxdfSU818QjNdQtzgyc1UEaTUYjE7bMNHu/Zixps2KpOF X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 25:4cSEaOcIjyM81geQgS/kVWa4DmHV6GhROyndJJ/eDzhYGR+yw/heQPrgZ59oq3eI554+3//9aYF6gpJD7hEIjqygzZLzphtu7KQ/YfT48S4MBrJu61OYTN8vRCLzmml9YmtHro2/v2Blcwp6XjXkO7XiiPLnSU4Tf9xdvH+jgY4NYT5eDuPbFQYUNWFe8MNDqY2sCbWb5kIaQvvwuQRWIi+iUEkN89BXKxmE7W4DyW9Fo+7A1nVnCo0wOPW9XY8ENK+eOGcL/vU7MVxCWbrdTo+eI37uaWN1mzeKHivtbGaVnxtJSahTcqodWF3j+ljzYQOnoPI4QS6gosEiwKciHtMAHjP1BOmgeWuuq9DYurYmExcRs1G8z7k2UbH30Bdb5by1yRcslcsaySohhxD1XBrwDvqEbxBHNIrBLPlr+1/9+HoQhnzVyyXvj2Rk+F0h3Q8Lz3wr5/lKI2pIJgsIMEV1DzBTp0JEACPJrEp/fEWtNovjeIxstmJM49EauuvQmkG2KED90Mqn28T4KIMQo0gIc6gavjk6RjLOmd/HA3MyqYXBJQ9ZzF1IGHFK0IuqOEF2ClPXiGDrBNDxQmfyXfKdwRhgDZaCteBnSgELEMfxF7/56tmJqIbUv/l28A75xO7ZBO1Etg2mFnY9GUzFSbz49D3CpCuLPg+w8PrRN6MYGn4TXp+B/Ft9+jkiR7AXYtFiosul2Xx8lrGt7WZtWDtHPlY3O6GLA+mCNyVUpZw= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 20:Z4Jlias9qk+ifFIL1xVQvCVkBlcw/dgnqib/ERB3Iivus3pHQrnBZJYSFDHMOP6Tcyo9FtUhvjODwQIs/EPwWhw4poc0xv0iLQFs4mNP4cHnRgl6BRrXKRclzF3Chp9Wfd/HrCSBvZ8iQTOgxgw8q97ws3HKLC2wpmcCaD6XXbV4aAGfcEW+HKUcrRAqsGyn2TjuU9iR4xpAsT3MxUGuQ8FK1Jdi7Q/7NALz0GQIgq3CYwwMTWsNfC2b7p4gLIS6WpgT7KzFHbsRqhtQYgRLkYTc9ObYZc7MjfrvgaKPMFzIzAMY9Q5V6LZ0oUxb7SiZG+GRdG2Md4OFOkAKL/q4Cp40A1fSPYejwIDTlpYBVoh0GnhQTT/2AG90wj/RS83SZwCCSc61+4yTlrJ+gM0jqLfWAbadcn/V7RmtMxuEUQ4emXAs6GA7GBUUfpnRmHeSCRJG5chICKGUegDdUjMzwpR7mbiE2HsuOScwsLJVCUU7s19ytomMJBiTPCjPThGvimc9UUgGNvlKCyL5cjbcdiH3ocTpI7xljG3QAqZXCGA7lfRjyw9KMWIDHsjFfI9MqL6Usvi4LpjD5JEXsk3MsDAHHkVtHUDYt4sX+zf+YbY= X-Microsoft-Antispam-PRVS: <BLUPR0701MB171360D221BF7D03D6C590D2812A0@BLUPR0701MB1713.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BLUPR0701MB1713; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 4:zCCksmnzAF7hbhyXKFv0+EvM6SRrppxAY1fRSrC3AY/rV6Evpz7DQMPlBi8/uNGupKYEJNdhNV3g+vlGQkVrU8NVXxKCJxzRUX/1y4b6R0L5TIosz/933muE5+TEpH6MtW6Sh+9VdvtUXAW00Bjr7HEp6ddtMYLbDAGvPvvFyDufCYmuvMEP1e0+fsExgQfWlKaYo645TsnDhCMfqtJ5iV1dayj3x21zgVp7hAKv/fSgCBw2htGA9Q4q7H694ghMn9QXdM7FDa5L1Ory7UzeY/6STJUOsOiQx3Lm5iQHILDPK/5XfhteIx/4Hy55K/aOHRzdAewdl3qwI4nVpZoL/MZAlKp1c9YeeoBfa/zF/1cims8wYORt39sdFcngW2suBpLb51a/73k2+qm9waWqqolRcnIvdpcKc6ATmGsGiT37m5l4oraarNK657dzDuzP X-Forefront-PRVS: 09796A1B83 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(377454003)(13464003)(377424004)(199003)(189002)(24454002)(33656002)(66066001)(46406003)(6116002)(3846002)(9686002)(586003)(101416001)(47776003)(105586002)(97756001)(50466002)(106356001)(68736007)(83506001)(23726003)(2950100001)(77096005)(61506002)(7846002)(19580395003)(19580405001)(76176999)(54356999)(110136002)(81156014)(189998001)(97736004)(50986999)(1076002)(42186005)(92566002)(4326007)(93886004)(2906002)(5004730100002)(8666005)(81166006)(4001350100001)(8676002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1713; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; CAT:NONE; LANG:en; CAT:NONE; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1713; 23:K/BhFGR1Lt/RbYSxTgkvDfsTjWMZiWWvo+8NSNY?= =?us-ascii?Q?12XtJCcw8NmBMkE30nErQsCSoC+Bo3ZV5N87iK6B/Td5E+KTytkQyTE4Ox26?= =?us-ascii?Q?jObWWlcRRZ0STjfS9Rbl8SMoz2R8dr7AdMorCe6S3kL/4VrsHr6u/OhjieO9?= =?us-ascii?Q?7OIITMYc7Cwe2ICx8TePO/ms+nJKYHcsG4u4P3ToAZhf6JIDXsznJbq+Y1ey?= =?us-ascii?Q?bG99K+PB7tWrRpK/pIRtfTGmPx+97mZQuoSVXTcO+aWshKkGSa5A6AoC9Qxl?= =?us-ascii?Q?1yJQf2lhNcpfNk5QpuHRhSBkvMZ+p9zOcP4P9F9C684SoSgPMi+S6TrqD491?= =?us-ascii?Q?ufSpUUsKo+r/rm80d63vGuhKmT53GrLstU/vju1tTHqIO1R/deQsvK2SfBF5?= =?us-ascii?Q?10EnDFNsRLwSYnVzWBEgJGRsnY9dSOkiUiliq2DPNQzVEGY64meLjej7yIXv?= =?us-ascii?Q?Wfk481vQLX0qZHmqWlMEyfCoFjluQ3fL5CGlHCAjfxB7Tr/ldrWbbDoyIm94?= =?us-ascii?Q?1Ku/NYMsNNpBuOIFc43nIYk0Q/OwVY1JIOTcv2PGeaNdKr4hZEmyiKWII68P?= =?us-ascii?Q?FkTjzmhMybaXHgCKHrETjx7vxFqnASzhHvwh+e1ckMQkZhCW+cBfDbX44L2b?= =?us-ascii?Q?IRfioVO0DgqZggq+cJvAZocRxcVSZs9ZEl+1A342BGt0yAvkEJmfWAqEbsWF?= =?us-ascii?Q?Hbw8zbBHfwsuTcOM8m3WczEK4fdAhIAPziK8IwQkjylRkxs8PaLU4b8owO9/?= =?us-ascii?Q?2xj7UpQDDw/EZXC5NdeW4DyuJkmszl3U8uW0LE6lOvVUBETdaysWD0hibhj7?= =?us-ascii?Q?ZGXoIt9vE0RyGjTLiqJI2pMX/mj/7+s1j5kykuYZhHJSz5E+mh/5zX7JjmLt?= =?us-ascii?Q?pAUq3Rt5WPGVa04WjBxhpxGVwYNxx7jmWb+nL7uZyzTMJBvUA6JmPNjE8Euu?= =?us-ascii?Q?/3D4ukgae/Rh0JaNwc45nfR5hvTeoeLmwnJtXj/eKUvy9b8M+Jl6iLna6r/K?= =?us-ascii?Q?HZC9s6eohsrMYTtj7sM3xgsXqbcKwKYMNH3Vi/kNQJO3Bx7d2M37KjYsMxra?= =?us-ascii?Q?Pxzm9HYTG5U4lZxhv82+HYDLr8ONMXdt4oE2pbNLRTpL7cugzeEF187O97i0?= =?us-ascii?Q?G4kf6TOvkZpoAjMMtT/rWPhUHPEAIbrF1OcMgyo081pOubburGsWTObt9qNa?= =?us-ascii?Q?jbGWAnmOnrzhu/Vwq5UWLl2O2v1aRpC60EosnWhwl4GKrVPvZxx4MnXNeKKF?= =?us-ascii?Q?94tQiby+G1uqH1DzxazFx4tbvf3imOpLg2FiH3XWG?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 6:WdAa8i5XMRIC8G4wPCL9v1xSZbShlSLvqGPUfITBV0jhmIOChEKZSpTmyKtgtPaboeCs/hanivUC7P3PcxeW4SDFyeXIzwJ7+nbUsY74g6zC+Ln/IWT2cG6Cw4T7n6cIkutLyAGBfbg6MxuYRe5jDi6kdp7xJsTrRBG9Ax2/tFllXNaWBx7WUkzIewtNz15JRkjD32NGX9AJdfWD6RH7qzc+aeWAm9rBQut/VWnotx00efcUGGZMintXHCqgmWSdBq9vwIn8qCQNwnRZVepU0W9qYpqDKTUxmEhkkX9YLwc=; 5:YuDbRaWkyPgA1i3w3l55bxjaft111flKl6csQjvCWCeOOoE84TCsip/50oYVoGh8VKxJvl1HaMw5+Kr4MGET73VOj81fs0zf7g+Mn57gZxLveGmMUNofg6xd2wu6ZG9Un5i056Wu4qs0p/c20lkGWQ==; 24:S3ItabC5KmdQ+Q/pUgNe7fgDa+P1g4KtYNPKmw8V5pvWXNmwVaAWHfMb1gdmTEAc8G2X+xEdkXS4RIC32S9kOxrt6vtC70cW22PS1b8jxgI=; 7:y151to1tZga2Z8Bo4pB4yt1+n/l9kqL8mUX8R5BtVGoBr8hwzz4buOXLJkcm2UTZlnzFbXxr3Gae7nsuoqX2+opB/C4f3gC8JV4++LUZ4M4i19EtufDUAzOfYSHkmRNmqh33n1ZTwuKSwEpj+V7CbQDRECd4n8slInpQheq7MMcubvCUMNXXmWkUAx+jmhOqGJGmuW3PHB8jedTiEgMrdQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2016 14:22:25.9346 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1713 Subject: Re: [dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 20 Jun 2016 14:22:30 -0000 On Mon, Jun 20, 2016 at 01:58:04PM +0000, Ananyev, Konstantin wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Monday, June 20, 2016 2:54 PM > > To: Jerin Jacob > > Cc: dev@dpdk.org; Hunt, David; olivier.matz@6wind.com; viktorin@rehivetech.com; shreyansh.jain@nxp.com > > Subject: Re: [dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler > > > > 2016-06-20 18:55, Jerin Jacob: > > > On Mon, Jun 20, 2016 at 02:08:10PM +0100, David Hunt wrote: > > > > This is a mempool handler that is useful for pipelining apps, where > > > > the mempool cache doesn't really work - example, where we have one > > > > core doing rx (and alloc), and another core doing Tx (and return). In > > > > such a case, the mempool ring simply cycles through all the mbufs, > > > > resulting in a LLC miss on every mbuf allocated when the number of > > > > mbufs is large. A stack recycles buffers more effectively in this > > > > case. > > > > > > > > Signed-off-by: David Hunt <david.hunt@intel.com> > > > > --- > > > > lib/librte_mempool/Makefile | 1 + > > > > lib/librte_mempool/rte_mempool_stack.c | 145 +++++++++++++++++++++++++++++++++ > > > > > > How about moving new mempool handlers to drivers/mempool? (or similar). > > > In future, adding HW specific handlers in lib/librte_mempool/ may be bad idea. > > > > You're probably right. > > However we need to check and understand what a HW mempool handler will be. > > I imagine the first of them will have to move handlers in drivers/ > > Does it mean it we'll have to move mbuf into drivers too? > Again other libs do use mempool too. > Why not just lib/librte_mempool/arch/<arch_specific_dir_here> > ? I was proposing only to move only the new handler(lib/librte_mempool/rte_mempool_stack.c). Not any library or any other common code. Just like DPDK crypto device, Even if it is software implementation its better to move in driver/crypto instead of lib/librte_cryptodev "lib/librte_mempool/arch/" is not correct place as it is platform specific not architecture specific and HW mempool device may be PCIe or platform device. > Konstantin > > > > Jerin, are you volunteer?