From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E745FB3D4 for ; Tue, 21 Jun 2016 13:30:38 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 21 Jun 2016 04:30:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,503,1459839600"; d="scan'208";a="125915342" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.108]) by fmsmga004.fm.intel.com with SMTP; 21 Jun 2016 04:30:28 -0700 Received: by (sSMTP sendmail emulation); Tue, 21 Jun 2016 12:30:27 +0025 Date: Tue, 21 Jun 2016 12:30:27 +0100 From: Bruce Richardson To: Beilei Xing Cc: jingjing.wu@intel.com, dev@dpdk.org Message-ID: <20160621113027.GB19572@bricha3-MOBL3> References: <1464247695-4694-1-git-send-email-beilei.xing@intel.com> <1465805012-2907-1-git-send-email-beilei.xing@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465805012-2907-1-git-send-email-beilei.xing@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 11:30:39 -0000 On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote: > In current i40e codebase, if single VLAN header is added in a packet, > it's treated as inner VLAN. Generally, a single VLAN header is > treated as the outer VLAN header. So change corresponding register > for single VLAN. > At the meanwhile, change the meanings of inner VLAN and outer VLAN. > > Signed-off-by: Beilei Xing > --- > v2 changes: > Combine corresponding i40e driver changes into this patch. > > doc/guides/rel_notes/release_16_07.rst | 3 +++ > drivers/net/i40e/i40e_ethdev.c | 29 ++++++++++++++++++++--------- > lib/librte_ether/rte_ethdev.h | 4 ++-- > 3 files changed, 25 insertions(+), 11 deletions(-) > > diff --git a/doc/guides/rel_notes/release_16_07.rst b/doc/guides/rel_notes/release_16_07.rst > index c0f6b02..ae02824 100644 > --- a/doc/guides/rel_notes/release_16_07.rst > +++ b/doc/guides/rel_notes/release_16_07.rst > @@ -135,6 +135,9 @@ API Changes > ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss, > tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff. > > +* The meanings of ``ETH_VLAN_TYPE_INNER`` and ``ETH_VLAN_TYPE_OUTER`` in > + ``rte_vlan_type`` are changed. > + This change of meaning is not a general change across the whole API but is just for the i40e driver. Rather than noting it as an API change, I think it's better documenting it as a "fixed issue" in the i40e driver. Also, I think it is better explained as a change in the type of a single vlan tag, rather than referring to it as a switch in meaning of inner and outer tags generally. Can you reword the message, please. /Bruce