From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 04B60B44D for ; Tue, 21 Jun 2016 16:40:18 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 21 Jun 2016 07:40:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,504,1459839600"; d="scan'208";a="992184389" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.108]) by fmsmga001.fm.intel.com with SMTP; 21 Jun 2016 07:40:16 -0700 Received: by (sSMTP sendmail emulation); Tue, 21 Jun 2016 15:40:15 +0025 Date: Tue, 21 Jun 2016 15:40:15 +0100 From: Bruce Richardson To: Beilei Xing Cc: wenzhuo.lu@intel.com, dev@dpdk.org Message-ID: <20160621144015.GC12008@bricha3-MOBL3> References: <1465887596-10346-1-git-send-email-beilei.xing@intel.com> <1465977220-3970-1-git-send-email-beilei.xing@intel.com> <1465977220-3970-3-git-send-email-beilei.xing@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465977220-3970-3-git-send-email-beilei.xing@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 02/30] ixgbe/base: add sgmii link for X550 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 14:40:19 -0000 On Wed, Jun 15, 2016 at 03:53:12PM +0800, Beilei Xing wrote: > It adds sgmii link for X550. > A commit message like this which just restates the commit title can just be omitted. However, it would be nice to have a little more detail about the patch in the commit message. Regards, /Bruce