From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id DC727C12E
 for <dev@dpdk.org>; Tue, 21 Jun 2016 18:19:52 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga103.jf.intel.com with ESMTP; 21 Jun 2016 09:19:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,504,1459839600"; d="scan'208";a="126072505"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.108])
 by fmsmga004.fm.intel.com with SMTP; 21 Jun 2016 09:19:49 -0700
Received: by  (sSMTP sendmail emulation); Tue, 21 Jun 2016 17:19:48 +0025
Date: Tue, 21 Jun 2016 17:19:48 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Beilei Xing <beilei.xing@intel.com>
Cc: wenzhuo.lu@intel.com, dev@dpdk.org
Message-ID: <20160621161948.GA10676@bricha3-MOBL3>
References: <1465887596-10346-1-git-send-email-beilei.xing@intel.com>
 <1465977220-3970-1-git-send-email-beilei.xing@intel.com>
 <1465977220-3970-16-git-send-email-beilei.xing@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1465977220-3970-16-git-send-email-beilei.xing@intel.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v3 15/30] ixgbe/base: refactor NW management
 interface ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jun 2016 16:19:53 -0000

On Wed, Jun 15, 2016 at 03:53:25PM +0800, Beilei Xing wrote:
> This patch adds ixgbe_read_mng_if_sel_x550em to read NW_MNG_IF_SEL
> register and save fields such as PHY MDIO_ADD.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

NW == "network" or something else? Please expand the acronym.

Also, this commit message is describing what is happening in the changes in the
patch, but it doesn't give any details as to why. Can this message be expanded
to give more details on the reason for change.

Thanks,
/Bruce