From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0081.outbound.protection.outlook.com [207.46.100.81]) by dpdk.org (Postfix) with ESMTP id CA8058F9B for ; Wed, 22 Jun 2016 05:31:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jM0Idp8TdgJldVK1hnZ7buzgD1DhkKnKQavldmA0NBM=; b=TF/q6TFrQ1fJuXY44Qwq6Vp7M/9ZpJJ1fdUTJK4ZuwuFanrtG95yitgtZKq+WxMOgirRP2rDOOmhAsXOiTHQsjSTzSjD0FW3ELOCyZWUcZ8CjaDvNNOlmN2fE4+oURaxMY+X0QknVU7jWJ4ihaHboIPSFO3PGkxfbtMonDE8gvA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.167.156.79) by BY1PR0701MB1723.namprd07.prod.outlook.com (10.162.111.142) with Microsoft SMTP Server (TLS) id 15.1.523.12; Wed, 22 Jun 2016 03:31:10 +0000 Date: Wed, 22 Jun 2016 09:00:49 +0530 From: Jerin Jacob To: Thomas Monjalon CC: , , , Message-ID: <20160622033048.GA5200@localhost.localdomain> References: <1459250409-5123-2-git-send-email-jerin.jacob@caviumnetworks.com> <1459371063-7376-1-git-send-email-jerin.jacob@caviumnetworks.com> <1459371063-7376-2-git-send-email-jerin.jacob@caviumnetworks.com> <2207246.eroZTxtGRd@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2207246.eroZTxtGRd@xps13> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [122.167.156.79] X-ClientProxiedBy: BM1PR01CA0064.INDPRD01.PROD.OUTLOOK.COM (10.163.199.36) To BY1PR0701MB1723.namprd07.prod.outlook.com (10.162.111.142) X-MS-Office365-Filtering-Correlation-Id: 84bd7850-ff00-4e00-6403-08d39a4da926 X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 2:rcZBuIATQnSOT+aERWh+ImQjlVhVV16/bXh6hbRB2TiBIT6LszPLkhU43/g9Fy6Y2ag+apEjzr7iSLJQGNoh0eqrwZi9SOXUtgqkB0i8IvGtWs9ZS1uOexAwYBAuncIZ0kD/ea/yowWEp9eVnVbhVurPNhj5z0Usp1B1RSPkv9+MuAjVTmNuRqswvIQzkO9w; 3:ZV5Nrxq9oQYLgocDeQ6gTWew6QvzLLHjODb8bNCEIsK7xnuoM6PjNhW/MezdmPw/h5kBZNK+lORXObd8gVBuwSZVW9Igge2twFOuXLJBVZejzPW4FfP2lWnY/4wdhol1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1723; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 25:KJPOEstwFiW6zqIHVarUzcW3l+zNUcKPN8x6fbh78TK2zxnMHWpSCuANRL/1WGOLVs0jygZQXBd4zR99mdsc8lWuHnQplaNpcqpAt1auLTb9/fcQx9k7Jx8HDb6p7AK5O9ZXSLXyf6eGZLyWwgyFW5uDD2w1Sq41/Yrm/7khc79QeCV6T2BWz9ffbKqjHoEaB2046Ca3lxJIal8ABgIGGMgr5XQdofdsJsZgameAzASr6g3P6zTEjNT5Z38uFQgEQpTjpeuXuh95vZFbq0Dzf4X3ffE/JHCpMKE+KSaUwawSvKUhpSgH5XPkljKo8XggKFqmZmiRwWmRFnwiZrCZ6RUefvgOFM1TNzrdU+Af70B12xl3DCWyuyTsHxOS4uFNgR+Zyztr7fUrX+QvExNXzVHiCeyEcm2e7ZnPwMSiT2h4hbB/E7Zb8x+5Zl9YUA57g1FPcST+2ZxSPgE/B3qitpZAWKv5I3f1PZp83FcLmAkktJ4IrM48Ieh+4ns1hKMFPTuE23JAcF0O7v/MA57r+qb02YEoX+dJhlXTsuLLs3JyVuVrtya4nYZodVxeZ227CX5JRET/jB4S5srIw1lmcJMthZ2HR+S0n9/nyOikQv4Yz9giPyxuHOE6MeASq3oUo3/6tqOLI+uwuxJi7r/ggVXf17GrFQGEUHcAhr4o/mEgK0+cNEWG1jZ5RcOBhJa0J6Emror11vHi4f33b21eXi1pX5ulyeoKbYYqinmyinfLlfLGs5bhWHQMfXDSjd5o/CojqE11o0tAYuq1YOeJdQ== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 20:AIeyKUJc1BCEac1qmjU8KKo4aUK0UkMffh8r08ob4QXaWsR1qJktE7leG6IOBcfzGEMjAW2Ts8eLPEPctd+1jzly1j1dLGFJjIYgm7nUq2VnGvpHrvx8y9+OrEpeGO00txm3ErZZ6briBRNC/sj+kX+XFt0Qbz69V3TJP1GSyzB+2NMfPUvwZXAH3LYXXSHNqVg1EAOLPQFQAVqGNtxpaIp69sI3I37yu9KDDR8tJUTfI2q5lVdBfReH5KxyhrUmlJOxUkxkQC0MVrl/85TU8EjHhayM2Htmmei03HsTC8ELYafldgNFIIJfeQbTaPeSHl/i67qlidUMLeF3mB9IGulHsZMZ/wPyW9P7z+1w4J3BkM0dFj1eK2ZRoWCjVsrYA6nyoBUhcrehk8POj1R1zWvFSk3MEuyWFry7TRk4RDfNTi2alSvXHCKSZWTY7qvJn86JqAWpsm+L4E732fEGnR/zIFI8WYAtikR8SKZwenDmvAUBkhu3gufCa56sYr4vxeT8SFJkaJ5tsahz76il6ZFACY5O4Ng4aAHvKBihROCkAaH0QjN9H5NWT82J4uYPfKaOMgv1x/aScW0glZBcL2vHnkD2qUW/Oufspj1phZE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:BY1PR0701MB1723; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1723; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 4:neHdqwUa2QoNNGKqdeBqDe4y8YiXftOOmPNEJfqBTpCVXcgieKEzf7jEzCiZ9LyfPT4qbXCldtxYxPinozfZN2WJwY75RXncak9NujgXt7Nwm7eXBJPOWmqOsKoZesMm9qRdBDiXdGR+5EM1ZG8+1FYIrAjuGgvjOLkjYKHH/dA0jQDT03EIxufNk3rzYybCk1v73LBJ+CLvwxNwT+bfZs775SZx9T01DbjGPR6pahP3Yo4W9JgK2N5jo6nFHhBXhwyFLVQqXkXHRc+6ZKm9qKdW3Ofwjk1LxpBrHDNfw1sN7omQ5jRmqPNa7c4yU+j4Xrw6VpdOQCqVJ+IfAP+zWmgHoDyoqnvI97v094zBIDTg+y42auHJwfeGCEZ0cN2e X-Forefront-PRVS: 0981815F2F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(199003)(24454002)(377424004)(189002)(83506001)(42186005)(33656002)(101416001)(61506002)(106356001)(9686002)(1076002)(110136002)(7846002)(97756001)(586003)(105586002)(2906002)(46406003)(189998001)(66066001)(47776003)(23726003)(50466002)(7736002)(81166006)(81156014)(68736007)(76176999)(54356999)(50986999)(3846002)(97736004)(4326007)(8676002)(4001350100001)(93886004)(77096005)(92566002)(6116002)(2950100001)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1723; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1723; 23:zp5pncNUn6bCYNJ1SfoacevcwnY+yRUC4keH2mX?= =?us-ascii?Q?FXytJFYHM/COmF4t5/zpFusSmRBd5ZOTcx8r1eL+FgU8lSURv1+Snj8m4TnW?= =?us-ascii?Q?nhEJmJjF1iz3A6+etS9N1osvbCcFJnB2iajiA9lvVbtSZuaHt4YpUGkTP6IX?= =?us-ascii?Q?69P5gCUX6d7To0hOZmEVOlWYrVhhh1/Uvvi5cO+QJqXRb2HDxrE1mEivjPDK?= =?us-ascii?Q?Uph7LXTRtExXjVezvaXyzQerK5HKLIz+ifIwTvfu9fiDp4i7nSLNr1yFf4xE?= =?us-ascii?Q?E12rDdLlwaq3gM5BHNy1lfHL1Moezdok92J0zUCgHfBhCNwL67zmG59fgZVK?= =?us-ascii?Q?sJ44rqH69Uhfofjwoy7/vBCYCzUWeiFvqFqJ9Xduw0+C0TV1qZeUWFy3nM88?= =?us-ascii?Q?LATULF77qaRaAf8Rpc6ka2HjWDCqOoe5nkj6XKojQFgPuHnFuJxFTVvoXlga?= =?us-ascii?Q?EgnWRi3s4sgQXcNfSflWpKMmyyEFFry9wRrdZYwAj+u9xQfLYF/PllAUgg3R?= =?us-ascii?Q?YhkZV8f1Ui9JXhTWWH+NCfhDBPBDxBezOjajyaWLHhNEeZoRP3N0gvvs+XqB?= =?us-ascii?Q?j5+36TDbZFFQ/9SimH3Z6bltak92h5w2XIE6qI//REoQ/LPnEHUEcITUNQsm?= =?us-ascii?Q?xL0zkXI8z7CfIt5YIOihfHki0uOO9yuIcRaF4NXiJ/25imMLte+sy0S8rECB?= =?us-ascii?Q?CrADafq+o4Qb6tpsmHeUPch6DmUOomOPB7vaTsjk8xuEjobzOUBowZLyFvdj?= =?us-ascii?Q?yssMjCsbEZ0S8bNqmdVntE2iDsER9g8lZrEZfhwSTRSfptFArHU1pHopmwwr?= =?us-ascii?Q?UTC4z2nphePlFez1l/YsjVjBo5+3RPIeDBGxbD6NYS/k48yET2YbXj8jMWO7?= =?us-ascii?Q?HyAwAuabA2QFZ1rMNh5EwiJIewLcJfXqfHIuy47DQ8WtSihFVHF3YECGsxBQ?= =?us-ascii?Q?mtMO2n6jm4u/ZKWaf142irPb//AcFl6Zu33UVLgRpm3CuCbR3iSKKbQwH+FR?= =?us-ascii?Q?ha+l/dfuQWNg8nbHUbx/xmwSC85YVD3Ec3rxVUW6cTE3leSg5rbTw7nzoHtI?= =?us-ascii?Q?qleb+AoOvwjviqr4WvSPdYNmjGz8sJD4uBC1s7S70T6HTNnabUGK1w2+llXY?= =?us-ascii?Q?fVKRtNr2mS7GBIOMzrzFfwt1Fo0oAJv7F?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 6:HJbWgz4gQO9FGt8OHlJ4q5NGtEQGRPh1VjgcP5pRiD4CObCIhdu9IWTTO+DY8ZYxZnP4/lx9glOFMAQTCGJ5LVrhshj+BL6mkAAkqWLYYw9GpES0Sk/152xkskB9i92rO/uSqKLGmxGu+v7W+l0cYKpO/+oU+wSvu0LlU5pqQpwEchP3kw+PcJK6IfyVVgsvFE95QjUbqT5ZPi1KkL9NrGvCCSepVwCz03AOM7AhUFAnQ2AjxfCYMzs98K0fx/DUp88/T90RTKe/H/qViQRl7sdE889YSULHzp4qr1y71W4=; 5:irWXSdVAP3rAo55Xx1v4OcWe0Iq+N3rsjJGZYkXMPkEOedDeQAgAFj1zJf8fS6FJtc3Qk0Gn3OWwmxiVffTYvIahlNllL9i+K+/yerJUUknCg75F5+on1jORJcFjgeQb2DPOCkTIluSHKCW72jzLHQ==; 24:2SJhidYlbZ/5Fi+JeoSWTjHE5vkfWGb72+62wajy1BrFK/r0oQnrUodeXudhBnUf1ivNrVR+wSBfL+mcdXvP34V+yboslTJjijqefIIUM5I=; 7:qHQr4zg/Bj4SuvIvIPrz1iKBK2JR2O1vna+no/zsNtnokHmzamLFLv8u7sR2yO4qDx4n/ziZYpLg1ETqJrvsFusLjO8+fs97ZTzyy54sXw+O8ntEx3QVo3t3jE5+4NjUe9hS3NDaLnm9wtJK9I1NmHKhyfUz04PtzJUIgjIppOzqdNJP9bKcQ7Zo04p7ujHG9NnWXuUJDim4a5vb7cUdSyyO6cMOfft0+PeAdVxmdJaUnAYcrFOREOMZTYno4JS4 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 03:31:10.9337 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1723 Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add tunnel and port RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 03:31:15 -0000 On Tue, Jun 21, 2016 at 11:02:59PM +0200, Thomas Monjalon wrote: > Hi Jerin, Hi Thomas, > > I wanted to push this patch which is now a dependency of ThunderX > but I do not fully understand it. > > 2016-03-31 02:21, Jerin Jacob: > > - added VXLAN, GENEVE and NVGRE tunnel flow types > > - added PORT flow type for accounting physical/virtual > > port or channel number in flow creation > [...] > > --- a/lib/librte_ether/rte_eth_ctrl.h > > +++ b/lib/librte_ether/rte_eth_ctrl.h > > @@ -74,7 +74,11 @@ extern "C" { > > #define RTE_ETH_FLOW_IPV6_EX 15 > > #define RTE_ETH_FLOW_IPV6_TCP_EX 16 > > #define RTE_ETH_FLOW_IPV6_UDP_EX 17 > > -#define RTE_ETH_FLOW_MAX 18 > > +#define RTE_ETH_FLOW_PORT 18 > > +#define RTE_ETH_FLOW_VXLAN 19 > > +#define RTE_ETH_FLOW_GENEVE 20 > > +#define RTE_ETH_FLOW_NVGRE 21 > > +#define RTE_ETH_FLOW_MAX 22 > > Please could you explain more what is PORT flow? For example, a NIC card with two physical port where application configures RTE_ETH_FLOW_IPV4 for both, In that case HW generate same RSS value for a similar IPV4 packet, However, in-case if application want to generate a flow that account physical port also then it can configure with RTE_ETH_FLOW_IPV4 | RTE_ETH_FLOW_PORT. RTE_ETH_FLOW_PORT useful for the case where one physical port assigned for INBOUND traffic and other-one for OUTBOUND traffic etc > Does it need a comment in the code? Not sure, commit log has description. Jerin