From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0066.outbound.protection.outlook.com [207.46.100.66]) by dpdk.org (Postfix) with ESMTP id 5A132ADE0 for ; Wed, 22 Jun 2016 08:10:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8FApQoAsHTCn/HZB6xNobwPOCaRtj5+s9WOid6SJ1N4=; b=N1FhSRJkbMNli/hZcyCaX8v7NB70PugE87EvwtvjYMcaGBWsmW7qja8D9TwdQbO/Qa3mGYJ3sb8J55VhfMBaiBsnXdW2csb2aCHjxDnB9ySmayZuqwGVgjHrMlPup6VXgbLs3VonNKadi8UbuMOEkH69QoXHOCmEWPo8hLjl2Vo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.171.34.83) by BN3PR0701MB1720.namprd07.prod.outlook.com (10.163.39.19) with Microsoft SMTP Server (TLS) id 15.1.523.12; Wed, 22 Jun 2016 06:10:21 +0000 Date: Wed, 22 Jun 2016 11:40:02 +0530 From: Jerin Jacob To: "Lu, Wenzhuo" CC: "Ananyev, Konstantin" , Stephen Hemminger , "dev@dpdk.org" , "Richardson, Bruce" , "Chen, Jing D" , "Liang, Cunming" , "Wu, Jingjing" , "Zhang, Helin" , "thomas.monjalon@6wind.com" Message-ID: <20160622061000.GA8698@localhost.localdomain> References: <20160621105751.GA737@localhost.localdomain> <2601191342CEEE43887BDE71AB97725836B74226@irsmsx105.ger.corp.intel.com> <20160621133041.GA7509@localhost.localdomain> <2601191342CEEE43887BDE71AB97725836B7433B@irsmsx105.ger.corp.intel.com> <20160621142924.GA8670@localhost.localdomain> <6A0DE07E22DDAD4C9103DF62FEBC09090348971F@shsmsx102.ccr.corp.intel.com> <20160622023745.GA4437@localhost.localdomain> <6A0DE07E22DDAD4C9103DF62FEBC0909034897FC@shsmsx102.ccr.corp.intel.com> <20160622041431.GA6219@localhost.localdomain> <6A0DE07E22DDAD4C9103DF62FEBC090903489838@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC090903489838@shsmsx102.ccr.corp.intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [122.171.34.83] X-ClientProxiedBy: BM1PR01CA0034.INDPRD01.PROD.OUTLOOK.COM (10.163.198.169) To BN3PR0701MB1720.namprd07.prod.outlook.com (10.163.39.19) X-MS-Office365-Filtering-Correlation-Id: 052d697c-47ba-456a-22a8-08d39a63e754 X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 2:qs+hr7cH24Hhy7kUr4gAgpn5XTCxoeODSvrFIyBimp6RIpHtUp0q1aGlGfyKerDO2KuvrmQu/ODT4RxkX/p5iOtv0qjdd21/+Yjam3PbiS2MmRDVBP8vob3qyTN831sewHXbvmMOHuyWB/AOngW4zN4mMy9gO9IxW4yV2XVysrbMVtm1S5aXOWo8Xzn5EXMV; 3:ZoQWYGdV4RP+E9sohJ3wLTQJf8jZpoj1PElUOgIJ3N7YYGQG5yNVeJWO4FwOltVuWdkzM+rVwYuY5xohRWaYRWwS3S+Oy9IiTEKfXyWV60q9jmRhREouKZByAlf7mfbz X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1720; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 25:M+ODzDvGUWg4Ie0wQ5pUlkvYze6lSID71Dr4u6+dgNJyplQIQMqeLTviaMJ9FkaoL63aC8AaNLbZIdJNlKyBMeKaAoU/qbkEF9PaqKuoNkMUbtr+gsWYq0m7YmQicYJY+eHrhN2Jf3OPbf3VmX1koECu3m3ju41E0qYIVqrLBD/F5rqeo7hs7tSOF0/FpWQh8N1CXbaZisOnH8q14w02UCSLxPlUjpqRBALAprr8EMVhqlkMiNRg7t/PUcfR7TLWedHYFVa3a21N6BZlNYd/RTgQpv+Y425+3kkHcIWWyqoDU9vG8GKuRjlYqfzZsPEvNWj7m1XZlYnCPD25ZFHrqdM5Ih2T4aqOAY/tgAlcsrYYnonVCXjFV+dokIz73FSwmAvy4jCBnfeMbtFcpChTzw2BZOW8JsP2SMQaWNs4dY3Oa5gfdOvjhGN2vQZKIJxB3ku+XPN9DzQ4S7gsF/e/mQ44eI8BXtV4tdnHusebz/T3D79GFKmhsow08F61s/LoD7yZRe3Yk29VVu3uIxGCMsmd4edgJ/+QOC8Oi1vXvHtg24+V5XezTa2CLDRAIehkPp8mkV2Q9X/Pbw9iylSiP68RA2ox6XD9r02kPvsC6/rgkzbuDh8KO6N49kV9G8o9V1rYJPkTg0d9E3bM0wD/3BbXboTlSfy9JcqU72lGuB7+4/ezZInjqqDViv8tTG7zssYvFqPKY2KNjNPVTm6d1Szmy4HXX8JIIma20NoIdyfn035Ps5BGiowHoMVrYiiRqnh9hduRh/oNEiSIAKxAog== X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 20:1pf5ekvXsJSPfB83HxjGY4tAW/lKPInvaCPjcmhUqjqDzHce6arIOcCrvazRxSRRGWe8gD9k4XdMBQQMT3AQP1Ou/nmEcW6dXClyzuxU6ek8XhmXXtC/3ItQRd2DQKyThf+cN7O2m61f73uMbky39DOM5nz1/zzpRmpdO4yugsmdWTugN6bHdQhkLsfYZFfde0LK7yRGGGUbd8DKj1YwQyievJ5bBYLDY0IL/nre5RHQFZ2PtINVP3n6x1bIfTzl4TDmbpffNdMR7MFi72n70pBtAjwOApkaYLfKifZxzWFNpsXKnDQMIQiGbBqAJhSgCpR6YhddmgCui4ij3LpExnLqnYM3kQlmjhikkoO727SRopyK5mpFLyHrxHy33ESUzbK9ts7a2oGw2JA0JR5adPkrO0XiCKmI4YAV6xaEVc5WBW2fTHHEOEIqhKJ7jsSBVocvQukJ2r2QEqG798/VjaQfxDy79SYOz+LK8UQrdjNgKn5csFnydhAK8b9QyVdDFDnVYTG3i9Z7iVvdnohc6+043HbvJb2P1RDr4m+j7pNl4zKtc59IXKBHg6K2PpNuSFnwnvKINUk6f+jewZ5HPSTvICav3k5vzuuZfRQ8pEI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(21532816269658); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BN3PR0701MB1720; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1720; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 4:xltBt1DKHWOdIGnacELZq79HSB1lzlQoO7MFCuzFhMJZ3H807m5csxYj6vSys0M4+1M8j7gcf0mdS40GgwzbgO4A7RfytTXJZWpD09fIUGkLEY4w0ZobCZOLgM+dGp/sU35b7WPMe+P4/Jq8mglNuJLPNonvPqhseL7Ej6pr+Zhq5J6CGLyF4xFPYZXv2IzxsHv2virFkCUFQpZDePET3qIkS2/zMKEReBeY+ignppRsUxhzzZVZGUaa92jJr/Prwwpw/GKGApIOmLbKAMxcKa8vvz+UCcjHPkt1Utkd27Q5Ul23fMwFy+LeI2FrMQ+ypV3+e+Ew+ZiWD1PBy5UqWR8i25QsYwt7Jp8zKeLSfHiPbfsOSAwRJ04a/13C/D0vYDa1+6J+ucNAgcX7/AX8t960q2xy6MsKvubhSAVgjHY= X-Forefront-PRVS: 0981815F2F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(199003)(13464003)(189002)(24454002)(377454003)(7846002)(6116002)(23726003)(586003)(7736002)(4326007)(1076002)(97756001)(3846002)(83506001)(66066001)(4001350100001)(93886004)(68736007)(33656002)(2906002)(97736004)(189998001)(42186005)(77096005)(110136002)(61506002)(47776003)(46406003)(92566002)(50466002)(101416001)(81166006)(8676002)(19580395003)(81156014)(105586002)(19580405001)(50986999)(106356001)(2950100001)(76176999)(54356999)(9686002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1720; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1720; 23:aHhKjIe44ZLs/RBhIOvTAsq+ENvuk1EB+uTb1pE?= =?us-ascii?Q?o3EX/HKhzNFewRF0jPv+lIbYzFc1C8J8d72LDtKZqOHJJ2V1eQPOJKmQp57o?= =?us-ascii?Q?M4lc2hpOET7LvxNtN/qeTYEO7dVSbAMBMbo9BMDLhPeFLvNlbSDDCgYEC0j4?= =?us-ascii?Q?N+gblwsyJphSbB4c+Jw5Yrgz4XSrE5qzGM9v7IcTtbdkzWSCdc2Xetf6uw2O?= =?us-ascii?Q?Z7zwrhgNjYgrXA3tfEh4pQqdEmaAcVfTddpFCM2LhiiC+yzY57Sgb2RupElh?= =?us-ascii?Q?CBnvlrvrLWUM6ZGrsj977HsQ2/zmeM3EwBLHd49wfiPt+OaOYl3oNeSFMjc6?= =?us-ascii?Q?m2ywnrSquczrwVq9fYAHYyhXiSrm6FCAHGVialDhpPr6GrJ61P7QDggv0TqT?= =?us-ascii?Q?rpcg10E0OQvVgyzGrahXk1RFws4Incz3BlrVevayWSK28RAfZcT6mYRceMMy?= =?us-ascii?Q?FdwlmTJ+E7OBedq+V5IiHngBYwadATrWFZjYIqLSFN+fakR4rNpis6ffEzts?= =?us-ascii?Q?f/nvze0RSnyf20jAzue/vxc/MIFM3OxTix2bD3OkOnHCXd0siu6pl3oPrdzo?= =?us-ascii?Q?SPchJrj7WDicZF2/TG9cdEOFlS33R7aMSYQ7BAt9GqpaBIM/20++h5MpE1D8?= =?us-ascii?Q?t4jBf3GrZVEEQyq41dAOLPRBjUG+vqiexbulW/ngg228eS/uYsGVCBhYVRE9?= =?us-ascii?Q?eZjkLujzBy8uj4p3TvfzCyPH2CL8D639Lr4dTw4Z1lwXJGHL47SCMjn0NSws?= =?us-ascii?Q?MNNX5kA/ie+xJqAoaOfab/KXdThBOaAlEMRWJmO81gfABFPi4ntYtXvH1zkM?= =?us-ascii?Q?FsIFIj47ww1oRkdgdnmM/rccacAxarSYLktMFf5GCsjO5CC6rL8poXKcsLJl?= =?us-ascii?Q?jRTRzBXEV/Ami9KHpm8VdSu1ysoHtpZCCGpkSsS2yYt9jAR3wnn1VRv3E0x+?= =?us-ascii?Q?wEDSCir4rmvcJg8tk9orI77mJK4WRLtCx0ieqSF5VNGLMNMiyWS773F1b9zD?= =?us-ascii?Q?j5IunAeVZkv4JnfQPapmSeOewR8DO7WMwVC9OS1GeZIfr050ohRoj7muCwnr?= =?us-ascii?Q?Xo5sW9QB5mRiMQZRYeA3MT/EozqkvW9COULXlCqVHp6T3IKqtpefm1drgIeR?= =?us-ascii?Q?5/Xbnd9NabE2o9pudQsJ40aONrIGI9O+yQfS/glNAO14PMMyWhDQzA7keZLx?= =?us-ascii?Q?I1irff0wMr+F4FVw=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 6:pp9WytOiUGcDi7NuP2zC4DKaSl8N5Yvv/v4vmN9MUKn9UIadtstHBFinMj9fzuGrzLEN3MuD4VJZTg8cKKJt6cdySDksC1XHwnVFFU1DklzzpJkD2pBZ89QpWBEFtb9GPPeXInpZMO3a/SbIjECMPunV8d1jRSf8IFIYuFa5xcku+4AtRu6lYoxGj5bb9OZWFkbQXNciJY+/lthM+Mu0zXQkRuV8jAf4egfagnFaB8iZIicloW7Ez3zUS9xG34T+8Ql2Nu9K284jzg3g7EGxjNsxpu4oHoBkCw7BFsM31peG7daD1iGTEwLbGuXGIDbQ; 5:SerFOH4GO+BkpwA7U8Xkia9HQueUIJ2OMhVvYELi+CorKHu14u3OxtMaZb2z1Gl+CH2aZOoZp0qveB2CaYOpwG8GuRX7fZJWXQpXe3F86saKrZVxoaqFVg2k6eHbJrpU8Uu+y9KtRmZMH3DLkuqNrw==; 24:E+SLEA8+RrAPJCSFfF0kLs2496perKolMqtv9kGYqPrVH6sPiGQpsugFqJr0pY11FOxON+fqDZQn1sFS9aGULTseBhT72DyaIzqvjyMoIUY=; 7:c9yIFGP+l1xLLPpBF4a6Ad09zPml2qfZg7JjLwQ2blxWWgGGmzS3I7bDryYu/fzV8eBr9XRJudkn/DMUlJ109b9RhhoQyhoo7EEj5yU5HwGfWACgTUcghF9u9fJWkHhPAw6rkToJho4buPtc0/nsf1xAf/5LDPnVNxrJHO+UjSbPSr10qx1x548qtt+UAkSUz7yk2g1E38wjeusVh8yGPL8T8qoroQtLn/97Q88j1TUtXoItt1DaFHlPBf8ZTNqAMkvFcC26bnnxfBwZcPKPTw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 06:10:21.8856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1720 Subject: Re: [dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 06:10:30 -0000 On Wed, Jun 22, 2016 at 05:05:14AM +0000, Lu, Wenzhuo wrote: > > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Wednesday, June 22, 2016 12:15 PM > > To: Lu, Wenzhuo > > Cc: Ananyev, Konstantin; Stephen Hemminger; dev@dpdk.org; Richardson, > > Bruce; Chen, Jing D; Liang, Cunming; Wu, Jingjing; Zhang, Helin; > > thomas.monjalon@6wind.com > > Subject: Re: [dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset > > > > On Wed, Jun 22, 2016 at 03:32:16AM +0000, Lu, Wenzhuo wrote: > > > Lost here. I think these RTE_ETH_EVENTs are used to connect the APP call > > back functions with the events. > > > Actually I want the APP to register a callback function reset_event_callback for > > the reset event. Like this, > > > /* register reset interrupt callback */ > > > rte_eth_dev_callback_register(portid, > > > RTE_ETH_EVENT_INTR_RESET, reset_event_callback, > > NULL); And when the > > > VF driver finds PF link down/up, it should use > > _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET) to run into > > the callback which is provided by APP. Means reset_event_callback here. > > > > me too. Their is existing RTE_ETH_EVENT_INTR_RESET event to notify the PF > > reset.I guess it is not for the PF link change or it isfor generic VF reset request > > initiated by PF for everything. > I think this event is for device reset not only for PF but also can for VF. I think we can use this event when the driver want the APP to reset the device. The PF link down/up caused VF reset is one of the cases. Then please correct description for the RTE_ETH_EVENT_INTR_RESET in lib/librte_ether/rte_ethdev.h "/**< reset interrupt event, sent to VF on PF reset */" > > > > > file: lib/librte_ether/rte_ethdev.h > > RTE_ETH_EVENT_INTR_RESET, > > /**< reset interrupt event, sent to VF on PF reset */ > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > if application need to call rte_ethdev_reset() on RTE_ETH_EVENT_INTR_RESET > > event then please mention it commit log or API description. > Good suggestion. I'll try to find where's the good place to add more explanation. I guess then reset API can be changed to rte_ethdev_process_reset_intr() or similar to reflect the use case(API called by application on reset event from PF) The PMDs were PF does not generate the RTE_ETH_EVENT_INTR_RESET to VF then VF's reset PMD callback shall be a 'nop' Jerin > > >