From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0093.outbound.protection.outlook.com [207.46.100.93]) by dpdk.org (Postfix) with ESMTP id B24E4C12C for ; Wed, 22 Jun 2016 09:16:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=w5Vt3X2a9fOypevQw3CSy6/0jiENLq1Jh0C29oq1owQ=; b=oQTS+QEdwAPS5vLtcYcxkW2DzC9SszIrKoD/KJtaJsR1zSGo9+SkdOU+u+WtwufWUj0P2WaZZiBvLfN1l8KemzDj0kdw6tGv7TVnXjpOvMt3JwzqGhTLgOdveHzU6QCTXXxH+egfhYWCFA5hA6nEANd8ZItgibceuNWPiniuQUQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.171.34.83) by BN3PR0701MB1719.namprd07.prod.outlook.com (10.163.39.18) with Microsoft SMTP Server (TLS) id 15.1.523.12; Wed, 22 Jun 2016 07:16:15 +0000 Date: Wed, 22 Jun 2016 12:45:54 +0530 From: Jerin Jacob To: Thomas Monjalon CC: , , , Message-ID: <20160622071553.GA9860@localhost.localdomain> References: <1459250409-5123-2-git-send-email-jerin.jacob@caviumnetworks.com> <2207246.eroZTxtGRd@xps13> <20160622033048.GA5200@localhost.localdomain> <19576009.SQKuele073@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <19576009.SQKuele073@xps13> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [122.171.34.83] X-ClientProxiedBy: PN1PR01CA0049.INDPRD01.PROD.OUTLOOK.COM (10.164.136.149) To BN3PR0701MB1719.namprd07.prod.outlook.com (10.163.39.18) X-MS-Office365-Filtering-Correlation-Id: 96262066-20eb-440e-f960-08d39a6d1a99 X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 2:3g+PsQOcf+PL6VlajywBgcRinO7FRszmm0vELM2HvCH/kK654O5tSaFWX7QfX1RoQ+Uu0hBE1138TMv1uxI5smEPGhS9YMm2aRQJXeM4/g8uS1V8kh/VEfBbh4DFwCaoX0VjRj+DlAKlYxfs5PgIhu7D0TIdFk2vz2sWfD5Kw+caaGQfVsWMxdsezgUuL4iX; 3:WuJcUd39joWW96ff+RkkZfCeAHEVyj8Mo7cZsZVfbEBIit8sW4Pcoi97sUMYQWH59Xs7hvICwSRmQjteX71PZwmV1c558UaDsr9logRCZ4sOHN0fXeWZOA3fqoOpMQ/j X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1719; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 25:TYi7kOevpBu7CdKhmTEAK1PRmnVlDq/TSyL1rmXZsJ+WeLUOZJuAJm2JI+cxIVx9dtsFL7lsxNK48v8r0bBn3j7XHtfQU2iYUrMkjwxlmfdyuEy7kTUtW+Hiwmocr+1RVE7YPLJYbZK10l2DYv8gd5TfRtaWYCB6gyVDKyz1jGm96egooeAqp7hOmPt37AfwGmfCVF/49plNsqSwxkGahqJ+HiD7vyBmVnE+Ot2i5b9aoVmiGr7r0PWsAwKiRoTYOjDPkkqAC9AEz5ezHMjVqUKFscpkJyHSguVDRvGafo0JYWVR/otTmv/79KiP2a7YAlb62a3gbLvtMaqaF1cKj5cDWvrCG2RLI51kQQD8TDcaoEkokMblUCTJ83hSZpi0HJWVdgqeFw8BCxyCmVBrCU/GdVbVSXJwG1mOrH9m+k+j5A0ImNccIA3oTGbaOBRp566loxfKEZYHtKUwlnO4tvdo0Uyc4O64nkhZ9potffCEU3ZWe9vQAV+AaqaxgaOzhBTdpXKOGUZGEXzYXLOEMJPx3IPj4mZaEDw1DcgW+dcCJ+6Km8rD99Ar27MO1qkF36zuRbFFh1djbNMwrNnnIPOSd9nHHIhMnJdWDPEoYx0fzcGdmnjB79VXF7kjqjNd9Qg/2ODjAK15WIgwPcH7jVzIjxJzM6rIJePR9XHZIu8K6fUXgOGogZ40vlNoyGqtm54irvFkMsDZdhBIppa39HdidHZj4LCfJIc2X9KtRXgmZLaH0X2OTGsfx/O7A4TVM+wQijyeqaoIe0CfMBVBew== X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 20:b8/x/0qgLACvtIbpXxHFvunabyq1ryYw3X3/oF+d3ZMMhVd5qKYWrC4EQUgpN4G/biC8/UfqyNHRhSbuPyGsRYZRBX/9yza6QtjQl0Vz6na81Kc2JZMRGHkp7IgbKpCYtfieXK1s1F5J9/dEYIT4ORd2xUd6DF2jgm2Q5Q4GexTb0VYUdeC4CvfrNsx68G27paGqX7P+P5MoWn555Ab27Y49NtcdxZY6dhKKLOYr05RjOe11WFnvvvsIBU0O+0UUIXdembzRdGurv1LaHsCaiTpZ8vgk7r53FFVwekBMXWZRqfI1l3CpDdazter+qp7ouTVaOoglIdnFEFbzORAT8VwO8ERewNFAU0BHiuock8V/QI9jPMtR11yBJnAt7CtjjJ1IX1bW5qbILOfcf8eL6/Wjy7MTJcVgLjfeDXyXCMFDit8DeWpezbXf/NwIPwDNYQXwHFoMxZ/fT3txh8fHU5r5MNImiajmgUTQqZNhEstK+/sSaMozprLFbYyrHs3etcYNXz+MFYL3RTNq4yjju6CnbpSvWv1S9AGmWUcTA7jzsi6/4AASWlQCE+8ZXgp9fKBOZsXGf/b01R5qxxJHGclsyAKpnaopUZkG3/7p1f8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BN3PR0701MB1719; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1719; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 4:PeWVnjNV1Oh2iyKFwVwvJs+bPvJLV/XTYYenKNF4bO81kUf+EwrpvurBwpF4IL1UQtLlq197DMwue4V+G0rmm7IvrTW8xAkwF/thizOXEKXDF/dQqap0JhWnKxS90V4UUalcm7t8xBnnVRUvxMFYI9X0ouZuOXR3VIpu/AjJOtm0WiNn9dKg5Z2Z5Btcc8HiH7ILyAyURWbKb/ue/1p63mITuEiqZu+Nh2McVXGjtty8jBHUtNYqPH6uuYfCY1bZuXOKjWaE6EaICk/TYG2w/sLWkEMEaGkgMfNbGPyqxUDgX2IYZJFLA1dzCB/RdMk2o9kblnkne3QBhfx/CF544x0WPVXnUzhVBOJiay5wxumU9KV1978dwBnpadHrKNpN X-Forefront-PRVS: 0981815F2F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(377424004)(199003)(24454002)(189002)(4001350100001)(110136002)(97736004)(46406003)(4326007)(83506001)(101416001)(47776003)(97756001)(7846002)(7736002)(8676002)(66066001)(77096005)(189998001)(76176999)(6116002)(9686002)(81156014)(2950100001)(54356999)(105586002)(3846002)(106356001)(68736007)(92566002)(586003)(33656002)(2906002)(81166006)(61506002)(50466002)(42186005)(23726003)(1076002)(93886004)(50986999); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1719; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1719; 23:L2yf3EEsjpsQBbA8P6ZxeuR0IynadUSdoVBj5CU?= =?us-ascii?Q?0PzCzjWnlT6OdTCeTTX5maTxfq13+o5QRpxuKCjftJDvzjXu34GL2B5Mu9cD?= =?us-ascii?Q?CxIMvm7Bz6D/n2PJbbO/iwMSDDp0vWf5EoW6gyNjM0qoZTMQ4yeDWiR/lgqf?= =?us-ascii?Q?y30eKmxSGO8flUcz5A6e6i/gz8uqlLhOpZYNnF+XmP2u5Anc6jUMUOdOpALg?= =?us-ascii?Q?j+fiDrv1H5YmRa2oxO3nERYPKGH+9/P4Fzi3LEccqqFuwgFf7hBEh+AB/eOE?= =?us-ascii?Q?rc1Km+Vj+w2DR2fvXoAku81UOZOEYg/IvOiNqzNCrSpeiRzyFPurKmzGV50y?= =?us-ascii?Q?tCbzflwdRYpd824dFeR27jEI5iZYcYpSfQeqTcanwqIJBWTeuveR/Jj6WTz5?= =?us-ascii?Q?1LJZDApYQVSsfgpYLtjMeuHnoj7IEz/ckgW6xlweSASMy1XUgSW4/MQvuCOU?= =?us-ascii?Q?93AtVaYlv7nQvS+3aj8S9zTi3+6YegyUCLXdx9NepjSSfLuBeusZWTV6Idb0?= =?us-ascii?Q?35Z6RO9Cs/YBD8ZEsqt7thig/+4kyQBfSb12FBwmYSKBNJdX/7hLhL772zQJ?= =?us-ascii?Q?f+qJblYgtzurd/4gB1sayzOSe2z/b4vzyMHRv4ndEwVbKH6LueVYUXkLd5rL?= =?us-ascii?Q?73E579OIdUsXUbEVK0XQD1yDGo3d9SvNXDbjnTPx7elTGjp7uzG/MTXt2v2z?= =?us-ascii?Q?b9KkeSXVp4y1ISQoO8sJKPerPAdPq8TOYutDY3LMBVqi4RTE6EMv4PL5ECt3?= =?us-ascii?Q?F6hMOP/BAGAl1Dhly8WFKEUCMTY1HhhZkAzFE0f/qotfILZAmgZgHbfOLRQr?= =?us-ascii?Q?3N3cCNzOF5twPtITUwzsE3bPC2YE08wTnPL6WoVL1A03C1bYbNRrQ+s9lfmH?= =?us-ascii?Q?UYvAUV6NGrds6FP8c0Jq7s29oL+cNK31gads7kK67/1F+t4zWqbX7xatxTg0?= =?us-ascii?Q?gTuOB0otrwNIw7SCQCfNYP7bqpyDbPG4F8OHhORKD9aF4LtY5qcvVf1FgCG3?= =?us-ascii?Q?BFvyU3I7vVH905hSsvDeY4fr7AVOKyMKAfkO0a1PKkFpJUuqLpDWXOdHFYs1?= =?us-ascii?Q?/9zcqMAK4esKtaD4Rlqb7EEstbzPfEFgQ2K6s1kVLRlvDQotNCPqmmR7qZLz?= =?us-ascii?Q?LAsr264fLjVI=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 6:oOJaqoFuuAHWCfplKpdZo38iSVT7i4dlMcwbzPoumhonT+ufKraFPpVdJyh3lGzxepYJG9AgMrsEqzXNeqRZkbXuv0GeQb9yjMWi9bRXdGUtN+b/M/lohNJcfVikqwindJf9f1Sro+LFYc8sQZu5sJLgQRoeOvqALgeLLsPWP4s8aedeqQr+kHmHuVXO7VlqQuH4i0Ji3XcEAnFdHScb7a1KP7mVikyqwl/Jra5473vl1LPYbloFDk40YiNqll+dVn22GBNAgR+KXCvr3bG8z/FT1yHs2N5FzyzggmzbnQCkehlHVgl5JldYsN1bSFTL; 5:LSJFVzEFRcrKLVNrjfK4e2M+bCbJYZXnyjXJ8kfyBoYK3mXk6GYw6S18m+Ur2eCiUG6Z1qdxpsOc0kanTQeJWjaO2toaIuSbOd4Hj2sLX1LKHRMY9No8mKo5fwOz3GpR3eDDfzkJ+EoFV7CeTS5rBg==; 24:YnjfYk7xE28Ln7vEjuEeKbB0/Pe00kaOQfszF2Y2b8EzhH47HPijJLdhysou3qYynOT1cEUhL+tNlmVqB4tYeGOTeJYp6RMXFRsoZ7PXl9I=; 7:qwIPY6AUsHrZlMeWkRllwmibyKbqDIhahhY0y1U1jCPwoxzY0kQrjuSNc6dVkSosLfftbXUG25KPwER5Kb/S0oa83hDeC36qTdaTYFqjNt3yWQxrbu4CQF2Nyqqv0GIgwwuP9rDqocZBWc+rjuWdT2EXmkO9hQ4Qg9//Ju/2Jbvq1mLncS3vzcZ9ZPsUT4Riu66bInF9Pyq48CG+BkmFBJ3NbIc8nCAbBpwjIOAY21nZvQL2IoDvTWUEE7aGeXdV9tws5FMvAvfSSjUhlCfM+w== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 07:16:15.3343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1719 Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add tunnel and port RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 07:16:20 -0000 On Wed, Jun 22, 2016 at 08:43:52AM +0200, Thomas Monjalon wrote: > 2016-06-22 09:00, Jerin Jacob: > > On Tue, Jun 21, 2016 at 11:02:59PM +0200, Thomas Monjalon wrote: > > > Hi Jerin, > > > > Hi Thomas, > > > > > > > > I wanted to push this patch which is now a dependency of ThunderX > > > but I do not fully understand it. > > > > > > 2016-03-31 02:21, Jerin Jacob: > > > > - added VXLAN, GENEVE and NVGRE tunnel flow types > > > > - added PORT flow type for accounting physical/virtual > > > > port or channel number in flow creation > > > [...] > > > > --- a/lib/librte_ether/rte_eth_ctrl.h > > > > +++ b/lib/librte_ether/rte_eth_ctrl.h > > > > @@ -74,7 +74,11 @@ extern "C" { > > > > #define RTE_ETH_FLOW_IPV6_EX 15 > > > > #define RTE_ETH_FLOW_IPV6_TCP_EX 16 > > > > #define RTE_ETH_FLOW_IPV6_UDP_EX 17 > > > > -#define RTE_ETH_FLOW_MAX 18 > > > > +#define RTE_ETH_FLOW_PORT 18 > > > > +#define RTE_ETH_FLOW_VXLAN 19 > > > > +#define RTE_ETH_FLOW_GENEVE 20 > > > > +#define RTE_ETH_FLOW_NVGRE 21 > > > > +#define RTE_ETH_FLOW_MAX 22 > > > > > > Please could you explain more what is PORT flow? > > > > For example, a NIC card with two physical port where application > > configures RTE_ETH_FLOW_IPV4 for both, In that case > > HW generate same RSS value for a similar IPV4 packet, However, in-case if > > application want to generate a flow that account physical port also then > > it can configure with RTE_ETH_FLOW_IPV4 | RTE_ETH_FLOW_PORT. > > > > RTE_ETH_FLOW_PORT useful for the case where one physical port assigned for > > INBOUND traffic and other-one for OUTBOUND traffic etc > > OK > > > > Does it need a comment in the code? > > Not sure, commit log has description. > > How do you expect the user to understand this new value in the API? > Users do not check in the git history. > They use doxygen, headers comments and/or examples. The reason why I said because none of flow type has comments in the list. If you think RTE_ETH_FLOW_PORT needs a doxygen comment then I can add it. It would be nice some else could add the comments for following, RTE_ETH_FLOW_RAW, RTE_ETH_FLOW_L2_PAYLOAD