From: Bruce Richardson <bruce.richardson@intel.com>
To: Nelson Escobar <neescoba@cisco.com>
Cc: dev@dpdk.org, johndale@cisco.com
Subject: Re: [dpdk-dev] [PATCH] enic: fix free function to actually free memory
Date: Thu, 23 Jun 2016 12:36:09 +0100 [thread overview]
Message-ID: <20160623113608.GH5024@bricha3-MOBL3> (raw)
In-Reply-To: <1465948494-13380-1-git-send-email-neescoba@cisco.com>
On Tue, Jun 14, 2016 at 04:54:54PM -0700, Nelson Escobar wrote:
> enic_alloc_consistent() allocated memory, but enic_free_consistent()
> was an empty function, so allocated memory was never freed.
>
The additions to track memzones also needs to be described in the commit message,
since this patch does more than just provide an implementation for the
free function.
Regards,
/Bruce
next prev parent reply other threads:[~2016-06-23 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 23:54 Nelson Escobar
2016-06-23 11:36 ` Bruce Richardson [this message]
2016-06-23 23:14 ` [dpdk-dev] [PATCH v2] " Nelson Escobar
2016-06-28 11:09 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623113608.GH5024@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=neescoba@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).