From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8994DC4DA for ; Thu, 23 Jun 2016 13:36:12 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 23 Jun 2016 04:36:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,516,1459839600"; d="scan'208";a="993583936" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.161]) by fmsmga001.fm.intel.com with SMTP; 23 Jun 2016 04:36:09 -0700 Received: by (sSMTP sendmail emulation); Thu, 23 Jun 2016 12:36:09 +0025 Date: Thu, 23 Jun 2016 12:36:09 +0100 From: Bruce Richardson To: Nelson Escobar Cc: dev@dpdk.org, johndale@cisco.com Message-ID: <20160623113608.GH5024@bricha3-MOBL3> References: <1465948494-13380-1-git-send-email-neescoba@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465948494-13380-1-git-send-email-neescoba@cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] enic: fix free function to actually free memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2016 11:36:12 -0000 On Tue, Jun 14, 2016 at 04:54:54PM -0700, Nelson Escobar wrote: > enic_alloc_consistent() allocated memory, but enic_free_consistent() > was an empty function, so allocated memory was never freed. > The additions to track memzones also needs to be described in the commit message, since this patch does more than just provide an implementation for the free function. Regards, /Bruce