From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 49171C5BE for ; Thu, 23 Jun 2016 19:06:07 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id v199so134667479wmv.0 for ; Thu, 23 Jun 2016 10:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VZhx3f5AxSV8zSPJHCpB8wLIAgM+GJqpcLZ8lZV2V4I=; b=XPdMhE6e2Tu1cY5uCKTZRjjqLEMUgdrDCzz322tRWb5O+rTqaLq1xFff7TIy+uqrxL D42SzjyhuCkSce3TzI+DdzTtr8UegYZ6otSJr8+ga13onDKgUavDgXBIH90EnzH6m14x ClijOURIKgK+TaTojg8m98KejJfwHmeiWQNKX8QLFcJ3dK/v+oxNv0pukra9ju9y6FMh Bvz8rzLouqLuAlgMdsRlehB6PwrVulVGI7XRT+9lEmq8dVSL2vTgiryWSgAuRthE4pHV 33X7UniEJwa00W1EOYDZ8HJrTLX/EDbYRIineq1eyd9YdTL7SkBMucLq7cDXCsGIy5Yo xVnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VZhx3f5AxSV8zSPJHCpB8wLIAgM+GJqpcLZ8lZV2V4I=; b=QzyNXMTXBzWiw+RSg6DWFoYAFkJ6sxvdFA2TbJnsVZPTkwVKTemJFyoMjPjuJJCh3c eAWZXSNyK/wa/vZAG/3IY4gohOTayxPGv2rEgRV/viE/0MR+Z+fTFW2ncqpo9zZR99nC JesESHcUBIu3j7B1/W1i52vGGrTsXEqRtjPKsyJ0zWw1XdbDH9Ni4IwLkoL7T6iwl5nL rSO55eySxjil9VxWW6n9xLNFdY+S5ZjDn2ghdDu3YrYvG+ygjv5ZeQgbUcI2rT1RarHf wyF3GuhANXEYCdRa6YUZ+1YWlfC6XPKaQP3VQWtyhb35E0oRsUuAQ97IbcuQItYWD7el Gf2g== X-Gm-Message-State: ALyK8tLdKRLrXi7aRsjOTejuMFRyMTt98OueoSq4G6iwl2yUG4fyYac2dwsy92vmkBAGeIcv X-Received: by 10.28.141.4 with SMTP id p4mr15019849wmd.46.1466701566932; Thu, 23 Jun 2016 10:06:06 -0700 (PDT) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id q63sm4770644wma.0.2016.06.23.10.06.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Jun 2016 10:06:06 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Ferruh Yigit , Adrien Mazarguil Date: Thu, 23 Jun 2016 19:05:21 +0200 Message-Id: <1466700801-10383-11-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1466700801-10383-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1466586355-30777-1-git-send-email-nelio.laranjeiro@6wind.com> <1466700801-10383-1-git-send-email-nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH v5 23/25] mlx5: remove redundant Rx queue initialization code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2016 17:06:07 -0000 Content-Type: text/plain; charset="UTF-8" Message-ID: <20160623170521.ZKhAHkKEh4yda3rBEf6dVHnrUg4FAfTWyLYtXD8ljUc@z> From: Adrien Mazarguil Toggling RX checksum offloads is already done at initialization time. This code does not belong in rxq_rehash(). Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index b2f8f9a..fbf14fa 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -798,7 +798,6 @@ rxq_cleanup(struct rxq_ctrl *rxq_ctrl) int rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) { - struct priv *priv = rxq_ctrl->priv; struct rxq_ctrl tmpl = *rxq_ctrl; unsigned int mbuf_n; unsigned int desc_n; @@ -811,16 +810,6 @@ rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) /* Number of descriptors and mbufs currently allocated. */ desc_n = tmpl.rxq.elts_n; mbuf_n = desc_n; - /* Toggle RX checksum offload if hardware supports it. */ - if (priv->hw_csum) { - tmpl.rxq.csum = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum = tmpl.rxq.csum; - } - if (priv->hw_csum_l2tun) { - tmpl.rxq.csum_l2tun = - !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum_l2tun = tmpl.rxq.csum_l2tun; - } /* From now on, any failure will render the queue unusable. * Reinitialize WQ. */ mod = (struct ibv_exp_wq_attr){ -- 2.1.4