From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DB11BC44A for ; Fri, 24 Jun 2016 13:53:38 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 24 Jun 2016 04:52:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,520,1459839600"; d="scan'208";a="982524145" Received: from singalsu-mobl4.ger.corp.intel.com ([10.252.31.226]) by orsmga001.jf.intel.com with SMTP; 24 Jun 2016 04:52:40 -0700 Received: by (sSMTP sendmail emulation); Fri, 24 Jun 2016 12:52:40 +0025 Date: Fri, 24 Jun 2016 12:52:39 +0100 From: Bruce Richardson To: Jan Medala Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20160624115239.GI13456@bricha3-MOBL3> References: <1466099690-28085-1-git-send-email-jan@semihalf.com> <1466510763-19569-1-git-send-email-jan@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466510763-19569-1-git-send-email-jan@semihalf.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 0/6] ena: update PMD to cooperate with latest ENA firmware X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2016 11:53:39 -0000 On Tue, Jun 21, 2016 at 02:05:57PM +0200, Jan Medala wrote: > As requested, big patch splitted into logical pieces for easier review. > Improved style and fixed icc compiler issues. > Thanks for the patch split. However, many of the patches don't have a commit message describing (at a high level), what the goal of that patch is and how it goes about implementing the changes to achieve that goal. Can you add a paragraph or two of commit message to each patch on the set to help anyone looking at the code understand what is happening in each patch. Regards, /Bruce > Jan Medala (6): > ena: update of ENA communication layer > ena: add debug area and host information > ena: disable readless communication regarding to HW revision > ena: allocate coherent memory in node-aware way > ena: fix memory management issue > ena: fix for icc compiler > > drivers/net/ena/base/ena_com.c | 254 +++++++------- > drivers/net/ena/base/ena_com.h | 82 +++-- > drivers/net/ena/base/ena_defs/ena_admin_defs.h | 107 +----- > drivers/net/ena/base/ena_defs/ena_eth_io_defs.h | 436 ++++++------------------ > drivers/net/ena/base/ena_defs/ena_gen_info.h | 4 +- > drivers/net/ena/base/ena_eth_com.c | 32 +- > drivers/net/ena/base/ena_eth_com.h | 14 + > drivers/net/ena/base/ena_plat_dpdk.h | 42 ++- > drivers/net/ena/ena_ethdev.c | 275 ++++++++++++++- > drivers/net/ena/ena_ethdev.h | 40 +++ > 10 files changed, 675 insertions(+), 611 deletions(-) > > -- > 2.8.2 >