DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Keith Wiles <keith.wiles@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/2] fix building with clang-3.8.0 compiler
Date: Mon, 27 Jun 2016 09:46:49 +0100	[thread overview]
Message-ID: <20160627084649.GB19588@bricha3-MOBL3> (raw)
In-Reply-To: <1466956452-91772-2-git-send-email-keith.wiles@intel.com>

On Sun, Jun 26, 2016 at 10:54:12AM -0500, Keith Wiles wrote:
> Latest clang compiler 3.8.0 on latest update of Ubuntu
> creates a few more warnings on -Warray-bounds and extra
> () around 'if' expressions.
> 
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  app/test-pmd/Makefile                | 3 +++
>  app/test/Makefile                    | 3 +++
>  drivers/net/bonding/Makefile         | 4 ++++
>  drivers/net/fm10k/Makefile           | 2 ++
>  drivers/net/i40e/Makefile            | 2 ++
>  lib/librte_cmdline/Makefile          | 6 ++++++
>  lib/librte_eal/linuxapp/eal/Makefile | 8 ++++++++
>  7 files changed, 28 insertions(+)
> 
All the fixes in this patch seem to be just disabling the compiler warnings, which
should really be the last resort in cases like this. Can some of the issues be
fixed by actually fixing the issues in the code?

/Bruce

  reply	other threads:[~2016-06-27  8:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-26 15:32 [dpdk-dev] [PATCH 1/2] e1000:fix gcc test for clang builds Keith Wiles
2016-06-26 15:32 ` [dpdk-dev] [PATCH 2/2] fix building with clang-3.8.0 compiler Keith Wiles
2016-06-26 15:50   ` Wiles, Keith
2016-06-26 15:54     ` [dpdk-dev] [PATCH v2 1/2] e1000:fix gcc test for clang builds Keith Wiles
2016-06-26 15:54     ` [dpdk-dev] [PATCH v2 2/2] fix building with clang-3.8.0 compiler Keith Wiles
2016-06-27  8:46       ` Bruce Richardson [this message]
2016-06-27 12:58         ` Wiles, Keith
2016-06-27 16:29           ` Wiles, Keith
2016-06-27 16:40             ` Bruce Richardson
2016-06-27 16:51               ` Wiles, Keith
2016-06-27 17:13                 ` Thomas Monjalon
2016-06-27  8:48       ` Thomas Monjalon
2016-06-26 15:49 ` [dpdk-dev] [PATCH 1/2] e1000:fix gcc test for clang builds Wiles, Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160627084649.GB19588@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).