From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <adrien.mazarguil@6wind.com> Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id B93545939 for <dev@dpdk.org>; Mon, 27 Jun 2016 14:27:31 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id v199so98080065wmv.0 for <dev@dpdk.org>; Mon, 27 Jun 2016 05:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=2qpLG0f14fDGpBI9W9n2WVJJX91Aht3rx/BWqoFDeNQ=; b=lSedIHIg+TWvSBfmQWVgtiCtCOEr+ahDc9z0H+iTQkLlSENaGXaT6T1wIruD7dnZL/ QscfPILseYIC3J38Rj9S4qktPk3pqI0ttHx6fL+/4pQcLUgWGOCo6aivwlsbvMN4lc+O VxAj2PjAkyhQSQd+g8i9wX8SqMx5uUlM7wjWttP1c65IKmA/mPf81BnP9kAQPeexLQ1/ djBkoVsJOBHZTlVCMTLeSWyP0yWV/ceVgRbNcla9LGvczVjcIS9iO9l4y/QHSqVtve69 Zxv/eEV7sagBRMPV4SRZtoKRblU3j9x9qOeeoXaJGHBetfu7pAbyCZ7lVsuZySgMcycl 38fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=2qpLG0f14fDGpBI9W9n2WVJJX91Aht3rx/BWqoFDeNQ=; b=VdR8jyWimT7q8iOx+sKuqpuy0qFGhx5QBlRWfIiXNmPeecFtO0HZp61qIdhOE3k6Ct jI6mJgALu7UZ9LTd8SKo3umR1+QuxWs+9I2PvJVqDbZZmzcAGTmA5vywjPTgHIY/3grP YF3odiEWS8EyEXg8ld6PNsdmImMj1BmGFlUO77VRRkcBwELKdkA3b3Ow5GkbWqE7nEz2 krSzK29nSHGBLR1DmVeXP+zHoAx7JHK1Imm3QLs1gFC0iMABYNi4FVxP5fVGSi0lPC5n RJuW2cbX1KNipq6p4Dhmok3D6BbqrzaPl3rD86SP8DUSn4PO6Y2x6mAMOZD4AUQb+fSk A7ig== X-Gm-Message-State: ALyK8tItziSccpP4WSYoMUK9BusIaOWjmqCFzv29WkNRAtWLWE5tqwePIeGcrpcaPL+gB849 X-Received: by 10.28.195.135 with SMTP id t129mr10543112wmf.78.1467030451563; Mon, 27 Jun 2016 05:27:31 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id j4sm1022616wjg.20.2016.06.27.05.27.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jun 2016 05:27:30 -0700 (PDT) Date: Mon, 27 Jun 2016 14:27:29 +0200 From: Adrien Mazarguil <adrien.mazarguil@6wind.com> To: Bruce Richardson <bruce.richardson@intel.com> Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <20160627122729.GR7621@6wind.com> Mail-Followup-To: Bruce Richardson <bruce.richardson@intel.com>, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com> References: <1466758261-25986-1-git-send-email-nelio.laranjeiro@6wind.com> <1466774284-20932-1-git-send-email-nelio.laranjeiro@6wind.com> <1466774284-20932-23-git-send-email-nelio.laranjeiro@6wind.com> <20160627121215.GA15684@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160627121215.GA15684@bricha3-MOBL3> Subject: Re: [dpdk-dev] [PATCH v7 22/25] mlx5: work around spurious compilation errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 27 Jun 2016 12:27:31 -0000 On Mon, Jun 27, 2016 at 01:12:15PM +0100, Bruce Richardson wrote: > On Fri, Jun 24, 2016 at 03:18:01PM +0200, Nelio Laranjeiro wrote: > > From: Adrien Mazarguil <adrien.mazarguil@6wind.com> > > > > Since commit "mlx5: resurrect Tx gather support", older GCC versions (such > > as 4.8.5) may complain about the following: > > > > mlx5_rxtx.c: In function `mlx5_tx_burst': > > mlx5_rxtx.c:705:25: error: `wqe' may be used uninitialized in this > > function [-Werror=maybe-uninitialized] > > > > mlx5_rxtx.c: In function `mlx5_tx_burst_inline': > > mlx5_rxtx.c:864:25: error: `wqe' may be used uninitialized in this > > function [-Werror=maybe-uninitialized] > > > > In both cases, this code cannot be reached when wqe is not initialized. > > > > Considering older GCC versions are still widely used, work around this > > issue by initializing wqe preemptively, even if it should not be necessary. > > > > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> > > Since the previous patch is known to break the build on older compilers, I think > it would be better to merge this patch into the previous to prevent the break > from occurring in the first place. That will help with any future git-bisects > that people run. Makes sense, in fact I only kept it separate to decribe why setting these variables was necessary, in case someone wondered. > If there is no objection, and no other issues appear requiring a new rev of > this patchset, I'll merge patches 21 and 22 on apply. That's fine by me. -- Adrien Mazarguil 6WIND