From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 209125424 for ; Mon, 27 Jun 2016 18:29:53 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP; 27 Jun 2016 09:29:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,537,1459839600"; d="scan'208";a="836043727" Received: from dcarleto-mobl4.ger.corp.intel.com ([10.252.0.127]) by orsmga003.jf.intel.com with SMTP; 27 Jun 2016 09:29:36 -0700 Received: by (sSMTP sendmail emulation); Mon, 27 Jun 2016 17:29:35 +0025 Date: Mon, 27 Jun 2016 17:29:35 +0100 From: Bruce Richardson To: Daniel Mrzyglod Cc: konstantin.ananyev@intel.com, helin.zhang@intel.com, dev@dpdk.org Message-ID: <20160627162934.GD17808@bricha3-MOBL3> References: <1464883282-75631-1-git-send-email-danielx.t.mrzyglod@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464883282-75631-1-git-send-email-danielx.t.mrzyglod@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix unused value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2016 16:29:54 -0000 On Thu, Jun 02, 2016 at 06:01:22PM +0200, Daniel Mrzyglod wrote: > An assigned value that is never used may represent unnecessary computation, > an incorrect algorithm, or possibly the need for cleanup or refactoring. > > In reassemble_packets: A value assigned to a variable is never used. > > Fixes: cf4b4708a88a ("ixgbe: improve slow-path perf with vector scattered Rx") > Coverity ID 13335 > > Signed-off-by: Daniel Mrzyglod > --- Fix now needs to be applied to ixgbe_rxtx_vec_common.h since the ixgbe vector rework, but since it's only a one-line change it's easy enough to fix on apply. Acked-by: Bruce Richardson