* [dpdk-dev] [PATCH] ixgbe: fix unused value
@ 2016-06-02 16:01 Daniel Mrzyglod
2016-06-27 16:29 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mrzyglod @ 2016-06-02 16:01 UTC (permalink / raw)
To: konstantin.ananyev, bruce.richardson, helin.zhang; +Cc: dev, Daniel Mrzyglod
An assigned value that is never used may represent unnecessary computation,
an incorrect algorithm, or possibly the need for cleanup or refactoring.
In reassemble_packets: A value assigned to a variable is never used.
Fixes: cf4b4708a88a ("ixgbe: improve slow-path perf with vector scattered Rx")
Coverity ID 13335
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
drivers/net/ixgbe/ixgbe_rxtx_vec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c b/drivers/net/ixgbe/ixgbe_rxtx_vec.c
index e97ea82..61c7aad 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec.c
@@ -458,7 +458,6 @@ reassemble_packets(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_bufs,
end->data_len);
secondlast->next = NULL;
rte_pktmbuf_free_seg(end);
- end = secondlast;
}
pkts[pkt_idx++] = start;
start = end = NULL;
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] ixgbe: fix unused value
2016-06-02 16:01 [dpdk-dev] [PATCH] ixgbe: fix unused value Daniel Mrzyglod
@ 2016-06-27 16:29 ` Bruce Richardson
2016-06-27 16:33 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2016-06-27 16:29 UTC (permalink / raw)
To: Daniel Mrzyglod; +Cc: konstantin.ananyev, helin.zhang, dev
On Thu, Jun 02, 2016 at 06:01:22PM +0200, Daniel Mrzyglod wrote:
> An assigned value that is never used may represent unnecessary computation,
> an incorrect algorithm, or possibly the need for cleanup or refactoring.
>
> In reassemble_packets: A value assigned to a variable is never used.
>
> Fixes: cf4b4708a88a ("ixgbe: improve slow-path perf with vector scattered Rx")
> Coverity ID 13335
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
Fix now needs to be applied to ixgbe_rxtx_vec_common.h since the ixgbe vector
rework, but since it's only a one-line change it's easy enough to fix on apply.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] ixgbe: fix unused value
2016-06-27 16:29 ` Bruce Richardson
@ 2016-06-27 16:33 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2016-06-27 16:33 UTC (permalink / raw)
To: Daniel Mrzyglod; +Cc: konstantin.ananyev, helin.zhang, dev
On Mon, Jun 27, 2016 at 05:29:35PM +0100, Bruce Richardson wrote:
> On Thu, Jun 02, 2016 at 06:01:22PM +0200, Daniel Mrzyglod wrote:
> > An assigned value that is never used may represent unnecessary computation,
> > an incorrect algorithm, or possibly the need for cleanup or refactoring.
> >
> > In reassemble_packets: A value assigned to a variable is never used.
> >
> > Fixes: cf4b4708a88a ("ixgbe: improve slow-path perf with vector scattered Rx")
> > Coverity ID 13335
> >
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> > ---
> Fix now needs to be applied to ixgbe_rxtx_vec_common.h since the ixgbe vector
> rework, but since it's only a one-line change it's easy enough to fix on apply.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
Applied to dpdk-next-net/rel_16_07 with updated commit message.
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-27 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02 16:01 [dpdk-dev] [PATCH] ixgbe: fix unused value Daniel Mrzyglod
2016-06-27 16:29 ` Bruce Richardson
2016-06-27 16:33 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).