From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id ADF8429C7
 for <dev@dpdk.org>; Tue, 28 Jun 2016 13:13:00 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga101.jf.intel.com with ESMTP; 28 Jun 2016 04:12:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,541,1459839600"; d="scan'208";a="726183560"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.92])
 by FMSMGA003.fm.intel.com with SMTP; 28 Jun 2016 04:12:59 -0700
Received: by  (sSMTP sendmail emulation); Tue, 28 Jun 2016 12:12:57 +0025
Date: Tue, 28 Jun 2016 12:12:57 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Nelson Escobar <neescoba@cisco.com>
Cc: dev@dpdk.org
Message-ID: <20160628111256.GD22860@bricha3-MOBL3>
References: <1466807997-21403-1-git-send-email-neescoba@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1466807997-21403-1-git-send-email-neescoba@cisco.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] enic: fix issues when using Rx scatter with
	multiple RQs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jun 2016 11:13:01 -0000

On Fri, Jun 24, 2016 at 03:39:57PM -0700, Nelson Escobar wrote:
> The Rx scatter patch failed to make a few changes and resulted
> in problems when using multiple RQs since the wrong RQ or CQ
> was being used.
> 

I think you might need to expand on what the "few changes" are.
Also, please expand out the terms RQ and CQ are.

Thanks,
/Bruce

> Fixes: 14a261bf0520 ("enic: add scattered Rx support")
> 
> Signed-off-by: Nelson Escobar <neescoba@cisco.com>
> Reviewed-by: John Daley <johndale@cisco.com>
> ---
>  drivers/net/enic/enic.h      |  2 +-
>  drivers/net/enic/enic_main.c | 10 ++++++----
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
> index ed5f18d..15b1d45 100644
> --- a/drivers/net/enic/enic.h
> +++ b/drivers/net/enic/enic.h
> @@ -174,7 +174,7 @@ static inline unsigned int enic_vnic_rq_count(struct enic *enic)
>  
>  static inline unsigned int enic_cq_rq(__rte_unused struct enic *enic, unsigned int rq)
>  {
> -	return rq;
> +	return rq / 2;

This looks like it might need a comment explaning why you divide by 2.