From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D67FD2B8C
 for <dev@dpdk.org>; Wed, 29 Jun 2016 12:15:57 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga101.jf.intel.com with ESMTP; 29 Jun 2016 03:15:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,546,1459839600"; d="scan'208";a="726749348"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.81])
 by FMSMGA003.fm.intel.com with SMTP; 29 Jun 2016 03:15:53 -0700
Received: by  (sSMTP sendmail emulation); Wed, 29 Jun 2016 11:15:52 +0025
Date: Wed, 29 Jun 2016 11:15:52 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Olivier Matz <olivier.matz@6wind.com>, konstantin.ananyev@intel.com,
 dev@dpdk.org, helin.zhang@intel.com, amint@icsi.berkeley.edu
Message-ID: <20160629101552.GE4720@bricha3-MOBL3>
References: <1467042269-22703-1-git-send-email-olivier.matz@6wind.com>
 <1569745.6sBGvsO00c@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1569745.6sBGvsO00c@xps13>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix compilation when offload flags
 disabled
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2016 10:15:58 -0000

On Mon, Jun 27, 2016 at 07:05:45PM +0200, Thomas Monjalon wrote:
> 2016-06-27 17:44, Olivier Matz:
> > The ixgbe driver does not compile if CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n
> > because the macro has not the proper number of parameters.
> 
> We really need to understand why this build option is needed.
> Target: zero build option.

Agreed. However, we are where we are right now, and this build option is there.

Olivier, can you do a V2 of this patch based on dpdk-next-net/rel_16_07, since
the code in question has actually moved on that branch.

Out of interest, can you perhaps also give a little more detail on how to
reproduce the issue, as turning off the setting fails to show up a build
problem for me with either gcc or clang, at -O3 or -O0.

/Bruce