From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
dev@dpdk.org, thomas.monjalon@6wind.com
Subject: Re: [dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc
Date: Wed, 29 Jun 2016 11:39:07 +0100 [thread overview]
Message-ID: <20160629103907.GG4720@bricha3-MOBL3> (raw)
In-Reply-To: <57723B9B.8070209@intel.com>
On Tue, Jun 28, 2016 at 09:55:55AM +0100, Ferruh Yigit wrote:
> On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> > 'fno-prefetch-loop-arrays' optimization flag is not supported with clang
> >
> > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions")
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> check-git-log gives following errors:
>
> Wrong 'Fixes' reference:
> Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx
> functions")
>
> This looks like because of missing " in the beginning
Yes, but I can fix that on apply.
Other very minor nit is that the standard for fixes lines is to use a 12-char
commit id, rather than 8. Per contributors guide:
git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'"
/Bruce
next prev parent reply other threads:[~2016-06-29 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 16:16 Jerin Jacob
2016-06-27 16:16 ` [dpdk-dev] [PATCH 2/2] net/thunderx: fix unused function nicvf_mbox_msg_str error Jerin Jacob
2016-06-28 8:56 ` Ferruh Yigit
2016-06-29 10:39 ` Bruce Richardson
2016-06-29 10:43 ` Bruce Richardson
2016-06-28 8:55 ` [dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc Ferruh Yigit
2016-06-29 10:39 ` Bruce Richardson [this message]
2016-06-29 10:43 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629103907.GG4720@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).