[dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc

[dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc

[Jerin Jacob]

'fno-prefetch-loop-arrays' optimization flag is not supported with clang

Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions")

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/thunderx/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/thunderx/Makefile b/drivers/net/thunderx/Makefile
index 9079b5b..078237e 100644
--- a/drivers/net/thunderx/Makefile
+++ b/drivers/net/thunderx/Makefile
@@ -56,7 +56,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += nicvf_hw.c
 SRCS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += nicvf_mbox.c
 SRCS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += nicvf_ethdev.c
 
-CFLAGS_nicvf_rxtx.o += -fno-prefetch-loop-arrays -Ofast
+ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
+CFLAGS_nicvf_rxtx.o += -fno-prefetch-loop-arrays
+endif
+CFLAGS_nicvf_rxtx.o += -Ofast
 
 # this lib depends upon:
 DEPDIRS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += lib/librte_eal lib/librte_ether
-- 
2.5.5

[dpdk-dev] [PATCH 2/2] net/thunderx: fix unused function nicvf_mbox_msg_str error

[Jerin Jacob]

Fix the following error with clang
	error: unused function 'nicvf_mbox_msg_str'

The nicvf_mbox_msg_str() maybe unused, based on DEBUG
compilation option selected. Mark __attribute__((unused)) on
this function, to inform compiler that this function may be unused

Fixes: e93592f1 ("net/thunderx/base: add mbox APIs for PF/VF communication")

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/thunderx/base/nicvf_mbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/thunderx/base/nicvf_mbox.c b/drivers/net/thunderx/base/nicvf_mbox.c
index 3067331..9c5cd83 100644
--- a/drivers/net/thunderx/base/nicvf_mbox.c
+++ b/drivers/net/thunderx/base/nicvf_mbox.c
@@ -64,7 +64,7 @@ static const char *mbox_message[NIC_MBOX_MSG_MAX] =  {
 	[NIC_MBOX_MSG_SHUTDOWN]           = "NIC_MBOX_MSG_SHUTDOWN",
 };
 
-static inline const char *
+static inline const char * __attribute__((unused))
 nicvf_mbox_msg_str(int msg)
 {
 	assert(msg >= 0 && msg < NIC_MBOX_MSG_MAX);
-- 
2.5.5

Re: [dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc

[Ferruh Yigit]

On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> 'fno-prefetch-loop-arrays' optimization flag is not supported with clang
> 
> Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>

check-git-log gives following errors:

Wrong 'Fixes' reference:
        Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx
functions")

This looks like because of missing " in the beginning

Re: [dpdk-dev] [PATCH 2/2] net/thunderx: fix unused function nicvf_mbox_msg_str error

[Ferruh Yigit]

On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> Fix the following error with clang
> 	error: unused function 'nicvf_mbox_msg_str'
> 
> The nicvf_mbox_msg_str() maybe unused, based on DEBUG
> compilation option selected. Mark __attribute__((unused)) on
> this function, to inform compiler that this function may be unused
> 
> Fixes: e93592f1 ("net/thunderx/base: add mbox APIs for PF/VF communication")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>

...

> -static inline const char *
> +static inline const char * __attribute__((unused))
it is possible to use __rte_unused macro here, although not required,
and moving it before return type can prevent checkpatch error


>  nicvf_mbox_msg_str(int msg)
>  {
>  	assert(msg >= 0 && msg < NIC_MBOX_MSG_MAX);
> 

Checkpatch gives following error:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#39: FILE: drivers/net/thunderx/base/nicvf_mbox.c:67:
+static inline const char * __attribute__((unused))


check-git-log gives following errors:
Wrong headline format:
net/thunderx: fix unused function nicvf_mbox_msg_str error

Re: [dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc

[Bruce Richardson]

On Tue, Jun 28, 2016 at 09:55:55AM +0100, Ferruh Yigit wrote:
> On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> > 'fno-prefetch-loop-arrays' optimization flag is not supported with clang
> > 
> > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions")
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> check-git-log gives following errors:
> 
> Wrong 'Fixes' reference:
>         Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx
> functions")
> 
> This looks like because of missing " in the beginning

Yes, but I can fix that on apply.

Other very minor nit is that the standard for fixes lines is to use a 12-char
commit id, rather than 8. Per contributors guide:
   git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'"

/Bruce

Re: [dpdk-dev] [PATCH 2/2] net/thunderx: fix unused function nicvf_mbox_msg_str error

[Bruce Richardson]

On Tue, Jun 28, 2016 at 09:56:02AM +0100, Ferruh Yigit wrote:
> On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> > Fix the following error with clang
> > 	error: unused function 'nicvf_mbox_msg_str'
> > 
> > The nicvf_mbox_msg_str() maybe unused, based on DEBUG
> > compilation option selected. Mark __attribute__((unused)) on
> > this function, to inform compiler that this function may be unused
> > 
> > Fixes: e93592f1 ("net/thunderx/base: add mbox APIs for PF/VF communication")
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> ...
> 
> > -static inline const char *
> > +static inline const char * __attribute__((unused))
> it is possible to use __rte_unused macro here, although not required,
> and moving it before return type can prevent checkpatch error
> 
> 
> >  nicvf_mbox_msg_str(int msg)
> >  {
> >  	assert(msg >= 0 && msg < NIC_MBOX_MSG_MAX);
> > 
> 
> Checkpatch gives following error:
> ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
> #39: FILE: drivers/net/thunderx/base/nicvf_mbox.c:67:
> +static inline const char * __attribute__((unused))
> 
> 
> check-git-log gives following errors:
> Wrong headline format:
> net/thunderx: fix unused function nicvf_mbox_msg_str error

Thanks for flagging these Ferruh. I'll fix them on apply, no need for V2, unless
you particularly want to do one, Jerin. :-)

/Bruce

Re: [dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc

[Bruce Richardson]

On Wed, Jun 29, 2016 at 11:39:07AM +0100, Bruce Richardson wrote:
> On Tue, Jun 28, 2016 at 09:55:55AM +0100, Ferruh Yigit wrote:
> > On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> > > 'fno-prefetch-loop-arrays' optimization flag is not supported with clang
> > > 
> > > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions")
> > > 
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > check-git-log gives following errors:
> > 
> > Wrong 'Fixes' reference:
> >         Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx
> > functions")
> > 
> > This looks like because of missing " in the beginning
> 
> Yes, but I can fix that on apply.
> 
> Other very minor nit is that the standard for fixes lines is to use a 12-char
> commit id, rather than 8. Per contributors guide:
>    git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'"
> 
> /Bruce

Applied to dpdk-next-net/rel_16_07

/Bruce

Re: [dpdk-dev] [PATCH 2/2] net/thunderx: fix unused function nicvf_mbox_msg_str error

[Bruce Richardson]

On Wed, Jun 29, 2016 at 11:39:51AM +0100, Bruce Richardson wrote:
> On Tue, Jun 28, 2016 at 09:56:02AM +0100, Ferruh Yigit wrote:
> > On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> > > Fix the following error with clang
> > > 	error: unused function 'nicvf_mbox_msg_str'
> > > 
> > > The nicvf_mbox_msg_str() maybe unused, based on DEBUG
> > > compilation option selected. Mark __attribute__((unused)) on
> > > this function, to inform compiler that this function may be unused
> > > 
> > > Fixes: e93592f1 ("net/thunderx/base: add mbox APIs for PF/VF communication")
> > > 
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > ...
> > 
> > > -static inline const char *
> > > +static inline const char * __attribute__((unused))
> > it is possible to use __rte_unused macro here, although not required,
> > and moving it before return type can prevent checkpatch error
> > 
> > 
> > >  nicvf_mbox_msg_str(int msg)
> > >  {
> > >  	assert(msg >= 0 && msg < NIC_MBOX_MSG_MAX);
> > > 
> > 
> > Checkpatch gives following error:
> > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
> > #39: FILE: drivers/net/thunderx/base/nicvf_mbox.c:67:
> > +static inline const char * __attribute__((unused))
> > 
> > 
> > check-git-log gives following errors:
> > Wrong headline format:
> > net/thunderx: fix unused function nicvf_mbox_msg_str error
> 
> Thanks for flagging these Ferruh. I'll fix them on apply, no need for V2, unless
> you particularly want to do one, Jerin. :-)
> 
> /Bruce

Applied to dpdk-next-net/rel_16_07 with the check-git-log.sh issue fixed.
Checkpatch issue is ok to ignore.

/Bruce