From: Bruce Richardson <bruce.richardson@intel.com>
To: Chas Williams <3chas3@gmail.com>
Cc: dev@dpdk.org, harish.patil@qlogic.com,
Sony Chacko <sony.chacko@qlogic.com>,
Rasesh Mody <rasesh.mody@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH] bnx2x: Call bnx2x_init_rte() later
Date: Wed, 29 Jun 2016 11:59:03 +0100 [thread overview]
Message-ID: <20160629105903.GB3624@bricha3-MOBL3> (raw)
In-Reply-To: <1467130490-21245-1-git-send-email-3chas3@gmail.com>
On Tue, Jun 28, 2016 at 12:14:50PM -0400, Chas Williams wrote:
> We need sc->igu_sb_cnt determined before calculating the number of queues
> we can support.
>
> Fixes: a787538ee754 ("bnx2x: fix MSIX vector and VF resource counts")
>
> Signed-off-by: Chas Williams <3chas3@gmail.com>
> ---
Hi Chas,
we generally try to avoid making the commit titles too technical, so we avoid
using function or variable names in the titles. Since this is a bug fix the
best form of title to be used is "fix <description of bug symptoms>", e.g.
"fix incorrect number of supported queues".
Maintainers, any comments or ack for this patch.
/Bruce
next prev parent reply other threads:[~2016-06-29 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 16:14 Chas Williams
2016-06-29 10:59 ` Bruce Richardson [this message]
2016-06-30 20:01 ` Rasesh Mody
2016-07-04 13:32 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629105903.GB3624@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=3chas3@gmail.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).