From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0056.outbound.protection.outlook.com [207.46.100.56]) by dpdk.org (Postfix) with ESMTP id 4F5A72BA7 for ; Wed, 29 Jun 2016 13:28:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9UjDYlRX/Bw/kzckFrt3aiUzZ0i3530Iulh6MdhbHP0=; b=KVGGQREKyv/wiBd3787hcm4jynlDIYoNA2pr+JwKjBjDSJWgOxyPfq7omupIyQfHgFWjQyoS9ozpp2Fc7jVSE4ozAEKke5NWmyP68dDUCdbOSe9tzz1qpyL9gWmfn2boc5+LiYiao2lVhHQQ1FAjOTGyztcMRH9AkNUwTdLCuN0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.167.198.169) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (TLS) id 15.1.523.12; Wed, 29 Jun 2016 11:28:06 +0000 Date: Wed, 29 Jun 2016 16:57:46 +0530 From: Jerin Jacob To: Jianbo Liu CC: , Thomas Monjalon , Bruce Richardson , , Message-ID: <20160629112744.GB5301@localhost.localdomain> References: <1467028448-8914-1-git-send-email-jerin.jacob@caviumnetworks.com> <1467028448-8914-4-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [122.167.198.169] X-ClientProxiedBy: BM1PR01CA0014.INDPRD01.PROD.OUTLOOK.COM (10.163.198.149) To BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) X-MS-Office365-Filtering-Correlation-Id: 61db8831-4ef5-4c1e-50e8-08d3a01072ad X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 2:C+JID1kjt0GWt9YMBfMafNqnDoQ+A7C28R+UcCBsKE+R+h6xDhUvYt7zQppqZHjkN5W5aaGyQlYqD0Zdp9HYfphq/qDsUPqBLLq5cLnmdu+vFkiXI2xlVi7Xq8MaVha+x4K/mUArP5xPPaZXBciNpZFtNEuDSjQkwcybPZHHFiOyaVMnojqLAtgxUqzVdZsO; 3:edbQXUkTbwKInll0DYpQGsuzM8TxpUND30zvB5DWHUSh/1rvufXg1Nm4jbTmkxtBDM2l+0tgB75hwUbpRb3YrciSDq4jBwdRCm2/78ApT9z+fYvNN6EPVO8sDlijD+L1; 25:DbXiFdA+nJsR5ZxwnElDvBWhWybaQ6kKAcwbdS58zX6xGlsjFmrBGJGOEQ9HT3Z1wKhw/b7ljtAcxbI1VGIkBnzJ/1gcbOrAB6JNcXJgB8yQrHRPiPaxSx3LDrW9rkqosupSHRciGvv+EtoLwWNySeUFFbxckR22Aa4hI0UdxzjGpNWe22riiz8Oapbw18CjBgxuAVnWg2TIIiz4kWgBlcV4SBHC22Lb410BqKqxUbQJq3+lRraYgPHWRL0M0sONNh2jWapMPN6D/hSAOPSWg+nplOjpKD2yGsc+yocCKhYm3Sz525EQQz00PCgIx8Q8nKa2GuCKKl8SeJlQXV8T9b2Djz9vSk+mTZcDgIcXPhz88DWt9SCBq9m+sW5BDC07fb/eEGmTjy3PuXrtyPAEaSVWqSabO5cyYvLdoHGUanA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 20:rZBJYfu7xPY8ScTmvUqPkvHKouyO/QRuu2zVzdC1WXmLOICe0Bjj/ugDqim2nC1PNwtsgqV3CrFVmJ6h/+qHh+62/LeYfR51sILk+Kl3qvkDYUKSSGcmPz23kF9blNiI56WxEVI3sHbntNdPnZ6+8VOjV2mJfs22qgOojRCa052s3moJ3DdfXinbRuI7ADU4zsS3p09zMTj24Wl32sR33suBoojI4tq2PHloTlIuant359FekADC7M1twiTqP+B9ERtUQBy/e3oyvz4jMQZpC5dSw0UOhvqQrR9+UPwwCTuDnVyA33dFkQmYtFINF2yBSpq9S0XPd9h28N2aYZ/D1E0NTQMzMGAjQjeyHLgEjOo5+ErB00l7LirQQcaYtPAZ1Kb9tXdI6wV8ZiRD86eNe8MWWmKT6/eP4YpJmOGuSb8i4cdBUr8/JJ1haFF59i7/n4R9uJBjicF8xmA7QGJkJ6tCAZZsoLXzp71Y6CVcN1RHpcWNrsr3g3o4RoeTVt4tPoowPunrlQ8MuTR9pQmbDgS7hsEImp9qMa+yI0Pcigwh9pvReDdYUIXl8/ykP3TKH5n7PrAWGwr1/5j7t4InIIcGGVKYpGDiefBKeyFP/FY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:5sKswO1YLx5dKBI9C8i89dYsjA2A7aUlHnqjY7inD4pYwmYsMt8woYfAjvXUj7SLspAo+i6aYVZRj3UBxe2if9WqqQFpFaB6WzSBnL7QXVf2gV9jTYZT/ryv/MIEkCpM63NjWRo+pkju2xTNwojBAy/7AKJoBdGL3pbE1vIOKBsNHI5UmhJW7NaEp1zUbY8W9OPDbcEAZayKlfsXXw0Ngs2hlt2hCTYEG/jd0CROBUwLd7TeTAZQIjZbY7TW7wq9Xo23rDApqXmwxYuAK2+FCQG8Pj4WGVsJgnWskiw9lCvlNOf1U29Wnqrr5uTlVlBO9iD3okSgES/xAQ3g04WVoREPjWo8WeT1uVQFFluxWHj++aT0ts41zF7qcgvcsxR3 X-Forefront-PRVS: 09888BC01D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(199003)(189002)(24454002)(1076002)(3846002)(50466002)(76176999)(23726003)(6116002)(7736002)(305945005)(4326007)(33656002)(50986999)(54356999)(2906002)(97756001)(83506001)(189998001)(19580405001)(19580395003)(15975445007)(110136002)(68736007)(97736004)(46406003)(8676002)(101416001)(106356001)(7846002)(81156014)(2950100001)(77096005)(92566002)(81166006)(61506002)(586003)(47776003)(4001350100001)(42186005)(105586002)(9686002)(66066001)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714; 23:kE85zXGb6lS6UWEekd71bi5oZMBhG3VkJtCbnYl?= =?us-ascii?Q?UWDJqr99RTkfOwPY8WOWGmmgTUEW1Re35CFHYp5RYYNMGwkOtXh4QOme11SN?= =?us-ascii?Q?gJ5WlZHrZ6u6/ywdi+foCarQ2mIAADKQmUpAcbbHmtABiAMQMCrXFEi2Eddz?= =?us-ascii?Q?mFijNBl2odvmry7NlNWEZB3C5WitmODjumP5UeUOGpVgPCiN237lXzP4hJ+D?= =?us-ascii?Q?N31UxpGxnHxU+wGFv0qkA0T1cE/KM6tQG3EcwxOx6qKom1Qw6nqc2I4zkMYS?= =?us-ascii?Q?m+NzCeiF76tSsgj+So0kz9hck2sAbFjYhglwQXdqwXVPvixjNVlYFEzHpptM?= =?us-ascii?Q?YdzB7Aovly6/EQCbyxoXRCb+voNvH2WOoD6jcZPWnGz+Kp4jGawMcqcnVu1G?= =?us-ascii?Q?fA/z6xMoQxYIT+um0XNouA/Qj280jagSvyKeaB+ISI1gag9o0nAC3N0SgH19?= =?us-ascii?Q?vfMA5kFEwyfYUxPgBhgcgRBHy8M9ypVS9DS9ESgJI+4YL2Hk1D5EWOGXPXlZ?= =?us-ascii?Q?kKQDw7RkEGN3wMC60q8etV0YnifZ5OBzhBTbU+jDxjExvL5ldDF/r+lq7Pez?= =?us-ascii?Q?LsgWisL89G4wD08v51SqskPpX2UiBHelDN/mgskWV6X1cerr8TvqM6X2H7FJ?= =?us-ascii?Q?SCy4w0F/+pXmLhSbwmh3gObgOVpKyfGpLpRGnL9Q27BI5e61HLRqL30x3Oft?= =?us-ascii?Q?rURCDgj1XO0d1KThVBtC0r8l8xj2CAjGUHr85Z3tuDkr8F0mgD9mFffh4X+l?= =?us-ascii?Q?9KBTzkaFFFgcJcvC8I+1vKQXHBISiHEpAUI+RQ0UW7g7+91dZBzbMra7sr+O?= =?us-ascii?Q?ITka0Wu8qtwHZvlT4QhDTI7SuF6tQcpidA39h7hJ2mXgJlS8i88lJpgr8dj6?= =?us-ascii?Q?QIqy1mW57dOCASXp58ANQMvV43t6r5tPMqJqK1ZumFa8IWc9E/e+0CSuGPKK?= =?us-ascii?Q?hjfDymuFm94OLKpPWoQvZ6Byta/P4goFAsgQSy7MIiWsJGvXCrNSYZK7UjvM?= =?us-ascii?Q?S04WmJJOfc1Dof5dhr2XlI+AniSMyhdBZo6mJg4VVfVLR0rn1975r/8WqSCX?= =?us-ascii?Q?SUcsaHCZg7CS6OGSWaE5ckCfGy7Fg7EvKpBUxEwpSmscODPdx5fWuncfLnZr?= =?us-ascii?Q?jX+dXE7VNV8Y5Zga0QYy/J/c7gSg3ecVsERkX2GeTl3VWncuhc/ARTvawrrX?= =?us-ascii?Q?b8hCsHQgo7NtjSN/za20A76tJW/zot4z7bvZ5?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 6:3/0tb6ynvY7Pq4plHGPVCl24idYYOtKVsl27Yy7hhEmdNMfORjGIlXt+x7sGTp0TsJQRa14gHEk7x87CseWKzEMQ3m4AIDW9ToxBPYl8/yjQtVGHqaWRdkrYfDPh79CuPsK/+Xj2o9a4ThopZnWNz177p/qLRERVMLwwpwzLABvkHNQ4f6HVIVwecin2awFKmP/EaSTfjRMDrP35FbUct+SCmHW7mVV3nFixA9C8HtvtdhX0h+5DUrLaige9f10rchuvH7TUxRsfsU9K6uzD4JCdDC2EI6PYAPWvRf4V/vEIliTkvc2M7IyWn9MpMQtz; 5:Gzisk2E0nCM7WCIgSNipWn44X5gemvrA1/xRYKJGs5KFW5zGXJSoCD/ANmOiQH7f+1uUDowp6R5SZF5sL9raRBIeugu3CwSeyYovgzENyGQ+nBTul9ZhsSBIlNV5hJfWd15ntrCen5TH9i6MOKajCA==; 24:x0sXCSUAlpCFmeT923GtyPxzwYNx3ZOz1SKqjwJ7fiMw/wxOQIHBp7iBROEEZu9tBJm/Ilcp5zjyv4BPNX0xL/ngSGnoUvnZqpn0qO54W8s=; 7:6DbNuAtZNhaNsIFfA9NufhHx7SW4QcNaMD4vjTksEnG6Ua4KfmBX7g0G522eLUwxxQUQwLQf+ialKMG3bKxmOGBiEH9AX3k76pPMILOr9FGnjq7bTZIPLlenISaWP7SF5rE8ROP9FU5TULDeptnKUtFc1qFBlG1v755mNTVzNc3MkkEY5nup+rYLGCzVER+E1NAKwSYr1Ko/YN4rTUfBZck0TllSXAvb7d7/evfreHJCzNsLaGIXjePVtcA40Pk7YrbOoionK/GbKvoNPgXSeg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2016 11:28:06.4988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Subject: Re: [dpdk-dev] [PATCH 3/4] virtio: move SSE based Rx implementation to separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2016 11:28:12 -0000 On Tue, Jun 28, 2016 at 02:17:41PM +0800, Jianbo Liu wrote: > On 27 June 2016 at 19:54, Jerin Jacob wrote: > > split out SSE instruction based virtio simple rx > > implementation to a separate file > > > > Signed-off-by: Jerin Jacob > > --- > > drivers/net/virtio/virtio_rxtx_simple.c | 166 +------------------- > > drivers/net/virtio/virtio_rxtx_simple_sse.h | 225 ++++++++++++++++++++++++++++ > > 2 files changed, 226 insertions(+), 165 deletions(-) > > create mode 100644 drivers/net/virtio/virtio_rxtx_simple_sse.h > > > I think it's better to move sse implementation to a C file, > as Bruce pointed out at > http://www.dpdk.org/ml/archives/dev/2016-April/037937.html I can move to C file, That would call for further restructuring of the code by Introducing a new file drivers/net/virtio/virtio_rxtx_simple.h and moving all static inline functions of virtio_rxtx_simple.c so that virtio_rxtx_simple_sse.c and virtio_rxtx_simple_neon.c can include it. Huawei,Yuanhan,All, Are you OK with above restructuring? Jerin > > Jianbo