From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0084.outbound.protection.outlook.com [207.46.100.84]) by dpdk.org (Postfix) with ESMTP id 6E14C2BA7 for ; Wed, 29 Jun 2016 13:40:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GAEEYOqd9Axj+11l3U2KIHRO46AnXrz5KVZ4ihZ7Byg=; b=Zgc47rnFw5UgiwGDMFfuoQS6yIXbG2ox+YDlMxepNwpr5jOdmB3cHgEjdeKFl6sLJ0JFjpD9/g2U6HqmIC1lushfAJ0KdEwma9JxUkly0k8SfsoMU4JnDxl2ENGLmxtOyKvAefNxO+jlsdL4ydmM/7pEPUsV8YbEf5Q8nKHoGlw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.167.198.169) by BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) with Microsoft SMTP Server (TLS) id 15.1.523.12; Wed, 29 Jun 2016 11:40:47 +0000 Date: Wed, 29 Jun 2016 17:10:31 +0530 From: Jerin Jacob To: Thomas Monjalon CC: , , , , Message-ID: <20160629114030.GC5301@localhost.localdomain> References: <1467028448-8914-1-git-send-email-jerin.jacob@caviumnetworks.com> <3436400.asiby3BQPB@xps13> <20160629111848.GA5301@localhost.localdomain> <6020070.DOjM99b0E6@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6020070.DOjM99b0E6@xps13> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [122.167.198.169] X-ClientProxiedBy: MA1PR01CA0022.INDPRD01.PROD.OUTLOOK.COM (10.164.117.29) To BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) X-MS-Office365-Filtering-Correlation-Id: 0ac4fba6-7c33-4adf-2c90-08d3a0123828 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 2:hIfykvMSFwcT9az6xro8/giTTwgNVCFuDkqu5RPR2F5ZhuCaZHdh/Trln56a1yNOrmOrFETto1uhXSTkNDRBzxKVAEYDHhnTE5w2Zl6VBM3j4KahAMovblWsLCQVJ9RBe4/+xhnnjlbrkCV6iQJlvhovFRnX4hmXfxOjNyrsJDFxzNEpsS20ZK8gmIRNW5zt; 3:xMSKqHujL++TT47vcOr1XeY2m5IcUuu2RQCGwHgmSr/i/JNc5/2bbkMN9KEfiYOw42hqTlLpcudq3gZcfqKKf1NID6bYc20gY892qobQ80aHLLAuNDGdBPrlzXPIT6Tj X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 25:NzPsqFA1wO0X1oqLmUsvGPwZDM2Vrx18QirR+Aq0sSrR7kkMuGoYXWzdmDMnoC4P72iqB/Qn7fwSo8hECz4fpG7Odbtat4PvnlmgsTVx03z4Djb2qVOCwRtaBVErubE3J6kDQym8lNJ7ps9C0o7H42K5S1fu94oFgZ/R9gNI68BDUzsigWWv8ZPlmcs2Sr65zn1SvsyZc/IrGUKvhYwZle9nOMCfelLcYbyD0lnZsHAIlBdPZgqxaPdO5YJXwMZ2xFA+vcP+vrUoEk8RFlToCb5yR+6QrTFY9sAD6ebfA5Zj6hTknOT3fU/WbxMHXmvmRCSsEuBnzRnK0WP7+G1o0U26god11gnyvw4azo15i+GdRhlZiMMqvUUZZedYxHrckFYoy1HAKkZ0bBtCI47/eOOxN30I4Wg18n/V9ZcHKoV4kls0nkm3xCxmXffIFq4HyWHlOGAsm11toVUZ80NnrRFP6E6Nv2Cq+C4ELLYeis0YTpnkaXXWgRcTD50IQmNXW46U9FLATCkT8VAhLE0SflkuQwy7D1qRNdiiGMHCT2ksAog1V9ChG1MhIrUk9TcVr7bDWEbDTtPTeluhE5elf1KsLLSUkF71oZ7JPdrnzwBH4jOzVVTla52wURsifjTDwBGIqWhwtaBbAH1V8DztOxr7z/NjbcYYl835MdBgeQm7c8kytAcKR5JE8FWMOBM7N5G0bRAGq5SvwvCO+rBdxpAT63+/S3ryAhiyiAm33dX4HQAr9FeVokgbgN4y+r5cX6VpP/7O8Oi1c6YGNQOtXQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 20:uQ71TG+HvZ3lAFGxkDSd2OGwD3YLEHqpXHldkGGo7dp9kIw7qtiOyFvrNKIlFsy8wnqXFLTlSQ1F3180tSqHlmLvG5+Bnh3b7keW0GSRQ6NXOW2cY5j/XsClfZerF1XWEA6b7zwQBwRYx47RfUTfv1yzZw+jPRF5ZWCCTKSG22fz2gmj64aBdiM3EmjvL2QVt/WYzIsH6P1O5IbB5OOr+l9MdF/cBcXOwPIXfjpJa1+xNKxTF66R6sIS7QjI66swIZAfHTBFhkINP5UrA7uZBBcBIyNqD/h9Mc+5swaDjmKxrofViJi9GcslkM5tu/+3EdCJip8PRLBNqFOvhspq7on+zSdbQHxscwT4fZv/N/vAMTUcqotacMiWd5H3sTB+vLPTnHWiLsi+DA7tassEfxNbhtlKKu8VW49xMcCvx8Ed2FCig89MjFTfsbpLEfpalByh+KKn8yFx4BfJRLU0CcfmUIgKwzuII9kIstQWotWDLZiBv7rNRwJFPOxxRWbOtsyXw6zXzFidW19E2JOJCPwuXZ84Mh9sd0VE+Ko0/f47OCTz9o/6MyJdA1GlzLXTmKru+ExW96oaswCDYbL7ElVScsOxhZtP9ABi5H/GLK8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BLUPR0701MB1713; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 4:I+hzQUIv81FN4oY964lMAaIAtBRV04Z3qQQTt8QUSShueKcL7UMNlVGqB6EJ9Yf5MhpWXaz2h3NWv65oNmfYEFnUw3TMVTFZUfKWqqMwqMp10NUuDzsyordzS/SiTMeHjAppzfqcCOE3VmlIn22XksDLv+8H6OWFhWMmySHBlRzqhFfUTBAGV/Dya+zY9GxUorta2ZWnLEFLKYqQSh0VI8S56BVz27ZQI6MnCSvCwuCZFcvZT22Hv19rb7wNysCPjkB8kCHbNEZfGPVlenGyPvwdPztKto04UMAqpZxH7cEffqF2ulrGwQYS6b8DdFLEPLUida7g3oNmx6WPltXrXUG3TkJDtVL+o5H5M6/GBqnk21Is092b/iO0UKwJOzvq X-Forefront-PRVS: 09888BC01D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(979002)(6069001)(6009001)(7916002)(377424004)(24454002)(189002)(199003)(54356999)(76176999)(50986999)(83506001)(93886004)(106356001)(47776003)(33656002)(66066001)(9686002)(97756001)(105586002)(81166006)(68736007)(8676002)(92566002)(101416001)(46406003)(81156014)(3846002)(7846002)(6116002)(586003)(7736002)(2950100001)(77096005)(305945005)(50466002)(2906002)(42186005)(110136002)(23726003)(97736004)(4001350100001)(189998001)(4326007)(1076002)(61506002)(7099028)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1713; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1713; 23:iROAfrUn0Z05xWAuTGW7nCIa6iG6mStP/ozRtw1?= =?us-ascii?Q?RRAh0jF2cpCSxip8yn2ycSU13aj4C4H2i36tTCV4GJBVm7OSCSZtudbRmlI7?= =?us-ascii?Q?hEUj7jofes56G2s5Op+o+n26XJo6ECeEXSeEIVVVF2gX3kfdGSZHORgkhcWq?= =?us-ascii?Q?SCSOspn3eiTcFBBr2KHtgcHIhXmc5kegqxsgmNLeLCDcsF9Gi+2e6yygU6XQ?= =?us-ascii?Q?A5/fjBoGyLwBv0U+xvPUtsHnEvz8ktuhBLCsTneAuDoQHTzQSqClYcpQs42W?= =?us-ascii?Q?I3A37pvKg5MNLUREuBvTnzYItnK7Bhx2XGEhAAnswzqdwVqlPV8RwMeerbSO?= =?us-ascii?Q?1txuyGJToqmq9sPcuk9zWzduQ+ztlf/co9D4rNJYkQfhgeuiOCgTcmMl/e7r?= =?us-ascii?Q?Tg6P6Q+kvVxv5ZHQWh23goSM+ju9QR8tmKHRotjH+CVMlWZTTyppV3f+d9yt?= =?us-ascii?Q?v/gOT0izx8+PUhh+qQXoa0LpsWgnBttGJ3frAmkJy8iZ7Bixyfid4vPiPqq6?= =?us-ascii?Q?NTiaNp4tEv5UQFOJB3oGQVqATE+IiyDanejBjj2K8i6LRRr/Etle5qvOxQla?= =?us-ascii?Q?0dZ8K+JUgr6zQt4U90gP62TC1iks/FwT8zlyoOafdHtrPHXBXnQRDsQdDaMs?= =?us-ascii?Q?s00uamBVTYyheyj5tMPz4VINXEBIgDYuGhh64musq2WXMAMWsrUYRZcLGCN2?= =?us-ascii?Q?Gro3SrwG9GVfpqgATSL8J0U+GRQ6+ELx3bo2+zsPm1PNRHoiE9f4dcrL81ur?= =?us-ascii?Q?qsChHg86eNLVaUqS6JiEvK2jlEPRDTuxWRXizjbOXT1nBPIvr5vMrTWC+7W9?= =?us-ascii?Q?kJtk8LbDXt5+/XfvDxJcjHaH/1vTV3ktYdL9A/fpFMYSUurHdWOOUJ87OST4?= =?us-ascii?Q?7E5pRSKBI2vERKEKYcGnUMxwSmzQAAbbB6KObdrilmjM9Vkt3f65YwE0toiQ?= =?us-ascii?Q?Q9AZu9wk4kd+Q8Ul2FY/+LiI9gSNd/1WqN38NYtPTLK7R++SzSSJXpeiJmjm?= =?us-ascii?Q?N8Vum2w69LXV2jfhb/na3l1y9XJMml7EY1mFJBHrZUltH7gxfCw/B7l6/f2/?= =?us-ascii?Q?H1Mrs3DbRo2wTegw5vt3hw50xSQQujHUc37T2wcBna3EWHCr6g6JkIt4ce3J?= =?us-ascii?Q?xkCHUOusM4QwCmmMx5VwRm4c5Rq7AMxenGVBDIHGQzXFbYuSTuFPlcZc1xy9?= =?us-ascii?Q?EDO0kmfD7fE+6kyblyHtB8icCLB/dYvk1xmEIAPSAh0b4xTk2oBJ3o4fzO9D?= =?us-ascii?Q?VZk6Fm/clkF7Bc+D/Ur8=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 6:iOZCkd4MpQEWytxcVfkk4RZ5HrtHlZ1FpXI6o0F1GTB2n3Lp89rSDamI4aUjTWemsEh8kK9StwGRwxXWLePaPXQrGkRKXZYRnH8P3+Iu+8dY80DJdgmFVxi2IryeUz0UVnHJYPxA+Rq194/QPHVyb5jUALoFHuLuvrVzZy6Ee9f/YaAl++oU0oJDzd+b3GDHeBSnL+OqpZgrp0j1sK+rY2rzY9zrjyaOcWCcFfTFAjlqFburloGqTnZDMa6z8IBXK0H1+7Xfrdr413DWIVS2RIThcSaZGlTbw0eGaSIMmZJXdcxd/NHoPYRtdXkMfPsX; 5:oI15E1KJyLYQX6s8iUsWS190t7y486vG645Qhu+uyYmtPZe0k5agqlGCTD/HmS3cdZj7pNQ8OIQO4BesmPHnA795n5lgCBqoM363zsymFidB1KDE8zptUi9cIHs4ReIS3n6BcftsI0aCHAcWVNxfSQ==; 24:4TcO4CZtuTzPfA8r/o4bFdLH7j4C0sbhU3rKpUHsOjigvFXFwiZiNG/sDcTxCR82bKnTl81xgFyKyJRJ+CYfmNhGk8jkjdIKEyU9yEIQTEI=; 7:yEhwsRdwnfX+quVQYxMMA7naneLKdk7iOa5TAwW3n+bvlj6sBinrRbmL1iTRlakuBZ8bffwrRcTpVlsB5iKf8moejSj7gETyBJlHV/0sbHKLtvF4W+6BqEuq4A4clvwZwhFWHjZPlZ50FtInZ68IjL5nAIGcoahcUWsm3liQT3gfyBLjVGf5Y4hKFg4O6+U3TWBBAKR6S3PN0GNDwPqVkRwXmpb+YILXxZZnYpWAJPCi+vsUP4TfnukQWacs8oSFIm4g7QCyVeKpxmbq4qjT0Q== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2016 11:40:47.7552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1713 Subject: Re: [dpdk-dev] [PATCH 2/4] virtio: introduce RTE_LIBRTE_VIRTIO_INC_VECTOR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2016 11:40:52 -0000 On Wed, Jun 29, 2016 at 01:25:35PM +0200, Thomas Monjalon wrote: > 2016-06-29 16:48, Jerin Jacob: > > On Mon, Jun 27, 2016 at 04:59:42PM +0200, Thomas Monjalon wrote: > > > 2016-06-27 20:18, Jerin Jacob: > > > > On Mon, Jun 27, 2016 at 04:19:57PM +0200, Thomas Monjalon wrote: > > > > > 2016-06-27 17:24, Jerin Jacob: > > > > > > --- a/config/common_base > > > > > > +++ b/config/common_base > > > > > > @@ -267,6 +267,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n > > > > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n > > > > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n > > > > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n > > > > > > +CONFIG_RTE_LIBRTE_VIRTIO_INC_VECTOR=y > > > > > > > > > > I don't remember what means INC_VECTOR? > > > > > Why a config option is needed for vector implementations? > > > > > > > > I thought of adding additional configuration option(INC_VECTOR) _apart_ from > > > > cpu flag based scheme in the patch because even though if a given platform > > > > has cpu instruction support, in some platforms scalar version may > > > > perform well wrt vector version(based on instruction latency, emulation required or not > > > > etc). So a top level flag INC_VECTOR, can override the vector selection > > > > for a given platform if required. > > > > > > Isn't it a runtime driver option needed to disable vector virtio? > > > > > > > Regarding INC_VECTOR(INC in vector configuration name, I have no idea, I > > > > followed the existing flags) > > > > $ grep "INC_VECTOR" config/common_base > > > > CONFIG_RTE_IXGBE_INC_VECTOR=y > > > > CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y > > > > CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y > > > > > > If the flag is really needed I would suggest VIRTIO_VECTOR. > > > > OK I will change to VIRTIO_VECTOR > > I would prefer a runtime option. OK The platform I test their was NO need for additional VIRTIO_VECTOR configuration as NEON versions outperforms than scalar version. I thought of adding this option to override for any platform if it need to accommodate such platform differences NEON vs scalar versions. I will change completely to run-time detection based on cpuflags for IA and ARM. Any objections? Jerin