* [dpdk-dev] [PATCH] scripts: check for commit msgs starting with 'It'
@ 2016-06-28 11:27 Bruce Richardson
2016-06-29 11:23 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2016-06-28 11:27 UTC (permalink / raw)
To: dev; +Cc: thomas.monjalon, Bruce Richardson
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
scripts/check-git-log.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index 153f378..87b122f 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -114,6 +114,12 @@ bad=$(echo "$headlines" | awk 'length>60 {print}' | sed 's,^,\t,')
bad=$(echo "$bodylines" | awk 'length>75 {print}' | sed 's,^,\t,')
[ -z "$bad" ] || printf "Line too long:\n$bad\n"
+# check starting commit message with "It"
+bad=$(echo "$bodylines" | head -n1 | grep -E --color=always \
+ -e '^It' \
+ | sed 's,^,\t,')
+[ -z "$bad" ] || printf "Wrong beginning of commit message :\n$bad\n"
+
# check tags spelling
bad=$(echo "$tags" |
grep -v '^\(Reported\|Suggested\|Signed-off\|Acked\|Reviewed\|Tested\)-by: [^,]* <.*@.*>$' |
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] scripts: check for commit msgs starting with 'It'
2016-06-28 11:27 [dpdk-dev] [PATCH] scripts: check for commit msgs starting with 'It' Bruce Richardson
@ 2016-06-29 11:23 ` Thomas Monjalon
2016-06-29 12:31 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2016-06-29 11:23 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied with -i case option to catch also lowercase form.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] scripts: check for commit msgs starting with 'It'
2016-06-29 11:23 ` Thomas Monjalon
@ 2016-06-29 12:31 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2016-06-29 12:31 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Wed, Jun 29, 2016 at 01:23:48PM +0200, Thomas Monjalon wrote:
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Applied with -i case option to catch also lowercase form.
Which suggests another good check to add, would be to check that the commmit
message starts with a capital letter.
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-29 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-28 11:27 [dpdk-dev] [PATCH] scripts: check for commit msgs starting with 'It' Bruce Richardson
2016-06-29 11:23 ` Thomas Monjalon
2016-06-29 12:31 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).