From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 0729A2B84
 for <dev@dpdk.org>; Thu, 30 Jun 2016 14:08:56 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 30 Jun 2016 05:08:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,552,1459839600"; d="scan'208";a="986311867"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.99])
 by orsmga001.jf.intel.com with SMTP; 30 Jun 2016 05:08:54 -0700
Received: by  (sSMTP sendmail emulation); Thu, 30 Jun 2016 13:08:53 +0025
Date: Thu, 30 Jun 2016 13:08:53 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com, keith.wiles@intel.com
Message-ID: <20160630120852.GA15232@bricha3-MOBL3>
References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com>
 <1467217635-19766-1-git-send-email-bruce.richardson@intel.com>
 <1585831.LcblvschXd@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1585831.LcblvschXd@xps13>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2] mempool: rename functions with confusing
 names
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2016 12:08:57 -0000

On Thu, Jun 30, 2016 at 02:00:16PM +0200, Thomas Monjalon wrote:
> 2016-06-29 17:27, Bruce Richardson:
> > Fix this by introducing two new functions to replace the old ones,
> > * rte_mempool_avail_count to replace rte_mempool_count
> > * rte_mempool_in_use_count to replace rte_mempool_free_count
> 
> This patch needs to be rebased please.
> 
> > --- a/lib/librte_mempool/rte_mempool_version.map
> > +++ b/lib/librte_mempool/rte_mempool_version.map
> > @@ -32,5 +32,6 @@ DPDK_16.07 {
> >  	rte_mempool_populate_virt;
> >  	rte_mempool_register_ops;
> >  	rte_mempool_set_ops_byname;
> > +	rte_mempool_avail_count;
> 
> The "in_use_count" function is missing.
> Please keep alphabetical order.

We need a search-replace function that is smart enough to reorder things for us!