From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 6A1A22949
 for <dev@dpdk.org>; Thu, 30 Jun 2016 14:09:55 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP; 30 Jun 2016 05:09:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,552,1459839600"; d="scan'208";a="986312289"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.99])
 by orsmga001.jf.intel.com with SMTP; 30 Jun 2016 05:09:51 -0700
Received: by  (sSMTP sendmail emulation); Thu, 30 Jun 2016 13:09:50 +0025
Date: Thu, 30 Jun 2016 13:09:50 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org,
 olivier.matz@6wind.com, keith.wiles@intel.com
Message-ID: <20160630120950.GB15232@bricha3-MOBL3>
References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com>
 <1467217635-19766-1-git-send-email-bruce.richardson@intel.com>
 <1585831.LcblvschXd@xps13>
 <98f41037-a666-53b6-efce-65a73a218d29@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <98f41037-a666-53b6-efce-65a73a218d29@redhat.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2] mempool: rename functions with confusing
 names
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2016 12:09:55 -0000

On Thu, Jun 30, 2016 at 03:02:22PM +0300, Panu Matilainen wrote:
> On 06/30/2016 03:00 PM, Thomas Monjalon wrote:
> >2016-06-29 17:27, Bruce Richardson:
> >>Fix this by introducing two new functions to replace the old ones,
> >>* rte_mempool_avail_count to replace rte_mempool_count
> >>* rte_mempool_in_use_count to replace rte_mempool_free_count
> >
> >This patch needs to be rebased please.
> >
> >>--- a/lib/librte_mempool/rte_mempool_version.map
> >>+++ b/lib/librte_mempool/rte_mempool_version.map
> >>@@ -32,5 +32,6 @@ DPDK_16.07 {
> >> 	rte_mempool_populate_virt;
> >> 	rte_mempool_register_ops;
> >> 	rte_mempool_set_ops_byname;
> >>+	rte_mempool_avail_count;
> >
> >The "in_use_count" function is missing.
> 
> Its missing because the function is static inline. If you ask me, this would
> be as fine time as any to remove that inlining ;)
> 
> 	- Panu -
> 
Yep, and yep.
V3 needed, I'll see what I can do.

/Bruce

> >Please keep alphabetical order.
> >
> 
>