From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 22F0A1C52
 for <dev@dpdk.org>; Fri,  1 Jul 2016 03:55:34 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga103.jf.intel.com with ESMTP; 30 Jun 2016 18:55:33 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,554,1459839600"; d="scan'208";a="838402758"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga003.jf.intel.com with ESMTP; 30 Jun 2016 18:55:32 -0700
Date: Fri, 1 Jul 2016 09:56:12 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Xie, Huawei" <huawei.xie@intel.com>
Message-ID: <20160701015612.GL2831@yliu-dev.sh.intel.com>
References: <1467086311-13527-1-git-send-email-yuanhan.liu@linux.intel.com>
 <B27915DBBA3421428155699D51E4CFE2025899FD@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2025899FD@IRSMSX103.ger.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH 0/3] vhost coverity issue fixes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jul 2016 01:55:34 -0000

On Thu, Jun 30, 2016 at 03:58:31PM +0000, Mcnamara, John wrote:
> > -----Original Message-----
> > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> > Sent: Tuesday, June 28, 2016 4:58 AM
> > To: dev@dpdk.org
> > Cc: Xie, Huawei <huawei.xie@intel.com>; Mcnamara, John
> > <john.mcnamara@intel.com>; Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Subject: [PATCH 0/3] vhost coverity issue fixes
> > 
> > This is a small series fixes 3 coverity issues.
> > 
> > John, I'm wondering maybe maybe we could add the next-net and next-virtio
> > tree into the coverity test as well? So that we could catch those errors
> > as earlier as possible, say, at least before they got merged into
> > mainline.
> 
> Hi Yuanhan,
> 
> Good suggestion. I can do that.

John, Great!

> Are there any additional configs that should
> be enabled? Currently the check runs with:
> 
>     CONFIG_RTE_LIBRTE_PMD_PCAP=y
>     CONFIG_RTE_LIBRTE_PMD_QAT=y
>     CONFIG_RTE_LIBRTE_PMD_AESNI_MB=y
>     CONFIG_RTE_LIBRTE_PMD_AESNI_GCM=y
>     CONFIG_RTE_LIBRTE_PMD_SNOW3G=y

Non of them are related to vhost/virtio, thus we may don't need them
for next-virtio tree. And I just think of one that should be enabled:

	CONFIG_RTE_LIBRTE_VHOST_NUMA=y

OTOH, I'm wondering is it worth to enable those debug options, to cover
more codes?

One more question: will it cover all branches? I have 2 branches there,
master and for-testing. It would be great if the coverity test can cover
the two branches. However, it does not matter at all if it just covers
one branch only: master.

Thanks.

	--yliu